Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed additional props warning #89

Closed
wants to merge 2 commits into from
Closed

Fixed additional props warning #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0436bd
Removed `...props` from SubmitField section
zeroasterisk Aug 4, 2016
83f0cff
Bootstrap packages using filterDOMProps(props)
zeroasterisk Aug 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/uniforms-bootstrap3/src/components/fields/ErrorsField.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {nothing} from 'uniforms';

const ErrorsField = ({className, children, ...props}, {uniforms: {error, schema}}) =>
(!error && !children) ? nothing : (
<section className={classnames('panel panel-danger', className)} {...props}>
<section className={classnames('panel panel-danger', className)} {...filterDOMProps(props)}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You haven't imported this helper - ESlint fails.

<section className="panel-body">
{children}

Expand Down
2 changes: 1 addition & 1 deletion packages/uniforms-bootstrap3/src/components/fields/SubmitField.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const SubmitField = ({
wrapClassName,
...props
}, {uniforms: {error, state: {disabled, grid}}}) =>
<section className={classnames(className, {'has-danger': error, row: grid})} {...props}>
<section className={classnames(className, {'has-danger': error, row: grid})} {...filterDOMProps(props)}>
{(grid || wrapClassName) && (
<label className={classnames('form-control-label', gridClassName(grid, 'label'))}>
&nbsp;
Expand Down
2 changes: 1 addition & 1 deletion packages/uniforms-bootstrap4/src/components/fields/ErrorsField.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {nothing} from 'uniforms';

const ErrorsField = ({className, children, ...props}, {uniforms: {error, schema}}) =>
(!error && !children) ? nothing : (
<section className={classnames('card', className)} {...props}>
<section className={classnames('card', className)} {...filterDOMProps(props)}>
<section className="card-block">
{children}

Expand Down
2 changes: 1 addition & 1 deletion packages/uniforms-bootstrap4/src/components/fields/SubmitField.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const SubmitField = ({
wrapClassName,
...props
}, {uniforms: {error, state: {disabled, grid}}}) =>
<section className={classnames(className, {'has-danger': error, row: grid})} {...props}>
<section className={classnames(className, {'has-danger': error, row: grid})} {...filterDOMProps(props)}>
{(grid || wrapClassName) && (
<label className={classnames('form-control-label', gridClassName(grid, 'label'))}>
&nbsp;
Expand Down