Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented recursive $ref resolution (fixes #1006). #1012

Merged
merged 2 commits into from
Sep 13, 2021

Conversation

wadamek65
Copy link
Contributor

@wadamek65 wadamek65 commented Sep 6, 2021

This PR adds recursive $ref resolution in JSON Schema Bridge. Previously, only the first $ref was resolved so $ref pointing to another $ref caused errors. Also added tests for this case.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@wadamek65 wadamek65 self-assigned this Sep 6, 2021
@wadamek65 wadamek65 added the Type: Bug Bug reports and their fixes label Sep 6, 2021
@wadamek65 wadamek65 linked an issue Sep 10, 2021 that may be closed by this pull request
@wadamek65 wadamek65 marked this pull request as ready for review September 13, 2021 13:19
@wadamek65 wadamek65 requested a review from radekmie as a code owner September 13, 2021 13:19
@radekmie radekmie changed the title Added test & an attempt at recursive $ref resolution. Implemented recursive $ref resolution (fixes #1006). Sep 13, 2021
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #1012 (20ab5f1) into master (8dd2d74) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1012   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         202      202           
  Lines        3150     3150           
  Branches      796      796           
=======================================
  Hits         3118     3118           
  Partials       32       32           
Impacted Files Coverage Δ
...niforms-bridge-json-schema/src/JSONSchemaBridge.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dd2d74...20ab5f1. Read the comment docs.

@radekmie radekmie added this to the v3.6 milestone Sep 13, 2021
@radekmie radekmie merged commit ceeb8b6 into master Sep 13, 2021
@radekmie radekmie deleted the recursive-ref-resolution branch September 13, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug reports and their fixes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Unsupported field type: undefined
2 participants