Allow deselection of optional SelectField #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radekmie
approved these changes
Oct 28, 2016
|
It looks great! I'm waiting for the rest. |
|
might want to wait to publish, I have a minor PR I am going to submit for BS4 today. |
radekmie
suggested changes
Oct 28, 2016
| @@ -33,7 +33,7 @@ const renderCheckboxes = ({allowedValues, disabled, fieldType, id, name, onChang | |||
| ) | |||
| ; | |||
|
|
|||
| const renderSelect = ({allowedValues, disabled, id, inputRef, name, onChange, placeholder, transform, value}) => | |||
| const renderSelect = ({allowedValues, disabled, id, inputRef, label, name, onChange, placeholder, required, transform, value}) => | |||
There was a problem hiding this comment.
This line is not passing ESLint.
| @@ -30,7 +30,7 @@ const renderCheckboxes = ({allowedValues, disabled, fieldType, id, name, onChang | |||
| ) | |||
| ; | |||
|
|
|||
| const renderSelect = ({allowedValues, disabled, id, inputRef, name, onChange, placeholder, transform, value}) => | |||
| const renderSelect = ({allowedValues, disabled, id, inputRef, label, name, onChange, placeholder, required, transform, value}) => | |||
radekmie
suggested changes
Oct 28, 2016
| @@ -64,4 +64,3 @@ const Select = props => | |||
| ; | |||
|
|
|||
| export default connectField(Select); | |||
|
|
|||
There was a problem hiding this comment.
not sure why the commit removed the line, its showing in my editor, but its not committing it back with the newline at the end, strange.
There was a problem hiding this comment.
our OS must handle it differently, I am seeing the newline in my editor and the line count on Github indicates the newline is there
| @@ -64,4 +64,3 @@ const Select = props => | |||
| ; | |||
|
|
|||
| export default connectField(Select); | |||
|
|
|||
| {transform ? transform(value) : value} | ||
| </option> | ||
| )} | ||
| </select> |
There was a problem hiding this comment.
Could you please do it exactly the same like in the other places? Like here.
| {transform ? transform(value) : value} | ||
| </option> | ||
| )} | ||
| </select> |
radekmie
approved these changes
Oct 28, 2016
|
Great job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue: #119
Tested with optional, required, with and without placeholders. Also tested with Nested objects and arrays of objects.
If this looks acceptable, I will commit more to this PR/branch for the other 3 UI packages.