Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated RadioField tests to @testing-library/react #1258

Merged
merged 7 commits into from
May 19, 2023
Merged

Migrated RadioField tests to @testing-library/react #1258

merged 7 commits into from
May 19, 2023

Conversation

ErnestTeluk
Copy link
Contributor

@ErnestTeluk ErnestTeluk commented Apr 25, 2023 •
edited
Loading

Rewrite RadioField tests to @testing library/react. Also added a helper to antd to support data-* attributes.

@github-actions github-actions bot added Area: Core Affects the uniforms package Area: Theme Affects some of the theme packages Theme: AntD Affects the uniforms-antd package Theme: Bootstrap 3 Affects the uniforms-bootstrap3 package Theme: Bootstrap 4 Affects the uniforms-bootstrap4 package Theme: Bootstrap 5 Affects the uniforms-bootstrap5 package Theme: Material-UI Affects the uniforms-material package Theme: MUI Affects the uniforms-mui package Theme: Semantic UI Affects the uniforms-semantic package Theme: Unstyled Affects the uniforms-unstyled package labels Apr 25, 2023
@ErnestTeluk ErnestTeluk marked this pull request as ready for review May 5, 2023 12:21
@ErnestTeluk ErnestTeluk requested a review from radekmie May 12, 2023 12:54
@codecov
Copy link

codecov bot commented May 12, 2023 •
edited
Loading

Codecov Report

Merging #1258 (0a29497) into master (e046d87) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1258      +/-   ##
==========================================
- Coverage   97.63%   97.48%   -0.16%     
==========================================
  Files         231      231              
  Lines        3812     3821       +9     
  Branches     1028     1031       +3     
==========================================
+ Hits         3722     3725       +3     
  Misses          4        4              
- Partials       86       92       +6
Impacted Files Coverage Δ
packages/uniforms-antd/src/RadioField.tsx 83.33% <100.00%> (+3.33%) ⬆️
packages/uniforms-material/src/RadioField.tsx 80.76% <100.00%> (-10.54%) ⬇️
packages/uniforms-mui/src/RadioField.tsx 91.30% <100.00%> (+1.30%) ⬆️

... and 4 files with indirect coverage changes

@radekmie radekmie merged commit cfaf81a into master May 19, 2023
@radekmie radekmie deleted the RadioField-to-@testing-library/react branch May 19, 2023 11:27
@kestarumper kestarumper mentioned this pull request Feb 9, 2024
Closed
@kestarumper kestarumper changed the title Migrate RadioField tests to @testing-library/react Migrated RadioField tests to @testing-library/react Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radekmie radekmie radekmie approved these changes

@wadamek65 wadamek65 Awaiting requested review from wadamek65 wadamek65 is a code owner

Assignees
No one assigned
Labels
Area: Core Affects the uniforms package Area: Theme Affects some of the theme packages Theme: AntD Affects the uniforms-antd package Theme: Bootstrap 3 Affects the uniforms-bootstrap3 package Theme: Bootstrap 4 Affects the uniforms-bootstrap4 package Theme: Bootstrap 5 Affects the uniforms-bootstrap5 package Theme: Material-UI Affects the uniforms-material package Theme: MUI Affects the uniforms-mui package Theme: Semantic UI Affects the uniforms-semantic package Theme: Unstyled Affects the uniforms-unstyled package
Projects
Open Source
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ErnestTeluk @radekmie