Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mantine theme #1287

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Add mantine theme #1287

wants to merge 10 commits into from

Conversation

ErnestTeluk
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the Area: Infra Affects the repository itself (e.g., CI, dependencies) label Oct 10, 2023
package.json Outdated Show resolved Hide resolved
packages/uniforms-mantine/README.md Show resolved Hide resolved
packages/uniforms-mantine/__tests__/index.ts Show resolved Hide resolved
packages/uniforms-mantine/package.json Outdated Show resolved Hide resolved
packages/uniforms-mantine/src/AutoField.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Area: Docs Affects the documentation or reproductions seed label Oct 10, 2023
@MDrooker
Copy link

MDrooker commented Mar 7, 2024

Was this abandoned?

@ErnestTeluk
Copy link
Contributor Author

ErnestTeluk commented Mar 8, 2024

No, I will get back to it next week. We must wait for the bump React to v18.

@ErnestTeluk ErnestTeluk self-assigned this Mar 15, 2024
Copy link
Collaborator

@piotrpospiech piotrpospiech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. List items should be full width.
image
  1. Delete button in the ListField has weird position.
image
  1. NestField label is <p> tag. We usually use label there. Only in the material and MUI we used a different tag - legend.

packages/uniforms-mantine/src/BaseForm.tsx Outdated Show resolved Hide resolved
packages/uniforms-mantine/src/ListDelField.tsx Outdated Show resolved Hide resolved
packages/uniforms-mantine/src/ListField.tsx Show resolved Hide resolved
packages/uniforms-mantine/src/SelectField.tsx Outdated Show resolved Hide resolved
packages/uniforms-mantine/src/SelectField.tsx Outdated Show resolved Hide resolved
packages/uniforms-mantine/src/SubmitField.tsx Outdated Show resolved Hide resolved
packages/uniforms-mantine/src/TextField.tsx Outdated Show resolved Hide resolved
packages/uniforms-mantine/src/TextField.tsx Outdated Show resolved Hide resolved
packages/uniforms-mantine/src/TextField.tsx Show resolved Hide resolved
@github-actions github-actions bot added Area: Theme Affects some of the theme packages Theme: MUI Affects the uniforms-mui package labels Jun 14, 2024
{children}
<Box mt={20}>
<Box pos="absolute" right={0} top={10}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can those styles be moved to the ListDelField component? We can avoid additional nesting with Box.


import AutoField from './AutoField';
import ListDelField from './ListDelField';

export type ListItemFieldProps = { children?: ReactNode; value?: unknown };

function ListItem({
children = <AutoField label={null} name="" />,
children = <AutoField label={null} name="" style={{ width: '100%' }} />,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test it with custom children? We don't want to pass width manually to every child component.

@@ -18,7 +19,7 @@ function Nest({
}: NestFieldProps) {
return (
<div {...filterDOMProps(props)}>
{label && <Text>{label}</Text>}
{label && <Label>{label}</Label>}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, it should be updated also in other fields e.g. RadioField.

@kestarumper kestarumper added this to the v4.x milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Docs Affects the documentation or reproductions seed Area: Infra Affects the repository itself (e.g., CI, dependencies) Area: Theme Affects some of the theme packages Theme: MUI Affects the uniforms-mui package
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

5 participants