-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build workflow job with concentrated docs artefact #1310
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1310 +/- ##
=======================================
Coverage 94.37% 94.37%
=======================================
Files 229 229
Lines 3754 3754
Branches 1011 1011
=======================================
Hits 3543 3543
Misses 81 81
Partials 130 130 ☔ View full report in Codecov by Sentry. |
scripts/concatenateDocs.sh
Outdated
#!/bin/bash | ||
|
||
# Check if the correct number of arguments are passed | ||
if [ "$#" -ne 2 ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we write this in .js or something to make this OS-agnostic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main purpose is to use it in the CI, so I don't know if it is really needed, but it won't hurt for sure, so I made it.
This pull request updates the CI workflow by decoupling the documentation build and deployment steps from the integrity checks. We have introduced a new job that only runs after the CI checks have successfully completed. In the previous setup, there was a possibility that the documentation could be deployed when using Node.js version 20.x, even if tests failed in other versions within the matrix. This issue has now been addressed and prevented. Additionally, we have included an artifact that compiles all documentation into a single file. This compiled document is intended for use with the uniforms assistant custom GPT model.