-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include filterDOMProps in fields #211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, keep imports aligned and correctly spaced.
Oops. Sorry. Fixed. |
@@ -8,7 +8,6 @@ const SubmitField = ({className, inputRef, value, ...props}, {uniforms: {error, | |||
htmlType="submit" | |||
ref={inputRef} | |||
type="primary" | |||
{...props} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why have you removed it? We shouldn't use filterDOMProps
here as it's not wrapped with connectField
, but it's still needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh. Sorry. That was just a typo of working on to many things at once.. My bad.
@janowsiany I was also considering #207 but still wanted to experiment with it. I'll do some tests later today then we can combine it in this PR. @radekmie what do you think of including |
We have to choose one way somewhere in the future (2.0.0 probably, as it will be a breaking change): where all unused props go. To the wrapper? To the input? To the inner wrapper (if any)? To nowhere (discard)? Right now, it's depending on the theme and field. |
I struggle to see how it will not be dependant on the theme and field. However, I think its a case of either assigning props to the wrapper or to the field on schema level - which will mean a breaking change or we can say to include a object for wrapper props and all other props are assigned on field level.
Where |
Yep, there's also #185. All in all - it shouldn't be discussed here. |
Solves #203