Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Pull Request #404 using wrapperStyle #416

Merged
merged 1 commit into from
Apr 25, 2018

Conversation

webpn
Copy link
Contributor

@webpn webpn commented Apr 24, 2018

Since the "style" prop is affected by a serious issues (see #404 (comment)), I updated the prop name into "wrapperStyle".

This PR fixes #414

Since the "style" prop is affected by a serious issues (see vazco#404 (comment)), I updated the prop name into "wrapperStyle".
@webpn webpn requested a review from radekmie as a code owner April 24, 2018 21:40
@radekmie radekmie added the Type: Bug Bug reports and their fixes label Apr 24, 2018
@codecov
Copy link

codecov bot commented Apr 24, 2018

Codecov Report

Merging #416 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #416   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         157    157           
  Lines        1396   1396           
=====================================
  Hits         1396   1396
Impacted Files Coverage Δ
packages/uniforms-antd/src/wrapField.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 215e76a...6fe8e27. Read the comment docs.

Copy link
Contributor

@radekmie radekmie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've discussed it internally and here's our final statement: previous change added a new feature and introduced a bug (well, a bigger breaking change, but still a negligible one) and this is a fix for it.

@radekmie radekmie merged commit d9f4d59 into vazco:master Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug reports and their fixes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants