Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added top level $ref suppport in JSONSchemaBridge. #508

Merged
merged 5 commits into from
Jan 17, 2019
Merged

Added top level $ref suppport in JSONSchemaBridge. #508

merged 5 commits into from
Jan 17, 2019

Conversation

janowsiany
Copy link
Contributor

Fixes #507

@janowsiany janowsiany requested a review from radekmie as a code owner January 15, 2019 20:01
@codecov
Copy link

codecov bot commented Jan 15, 2019 •
edited
Loading

Codecov Report

Merging #508 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #508   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         158    158           
  Lines        1484   1493    +9     
=====================================
+ Hits         1484   1493    +9
Impacted Files Coverage Δ
packages/uniforms/src/JSONSchemaBridge.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8976e6f...d68b371. Read the comment docs.

radekmie
radekmie suggested changes Jan 15, 2019
View reviewed changes
packages/uniforms/__tests__/JSONSchemaBridge.js Outdated Show resolved Hide resolved
packages/uniforms/src/JSONSchemaBridge.js Outdated Show resolved Hide resolved
@radekmie radekmie added the Type: Feature New features and feature requests label Jan 17, 2019
radekmie
radekmie suggested changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@radekmie radekmie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last small thing.

packages/uniforms/src/JSONSchemaBridge.js Outdated Show resolved Hide resolved
@radekmie radekmie merged commit 32765bf into vazco:master Jan 17, 2019
@janowsiany janowsiany deleted the issue-507 branch January 17, 2019 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radekmie radekmie radekmie approved these changes

Assignees
No one assigned
Labels
Type: Feature New features and feature requests
Projects
Open Source
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janowsiany @radekmie