Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct attribute id format (fixes #671). #672

Merged
merged 2 commits into from
Dec 18, 2019
Merged

Correct attribute id format (fixes #671). #672

merged 2 commits into from
Dec 18, 2019

Conversation

kestarumper
Copy link
Member

This pull request fixes #671 by escaping select item names with its base64 encoding.

@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #672 into master will decrease coverage by 0.98%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #672      +/-   ##
==========================================
- Coverage   99.32%   98.34%   -0.99%     
==========================================
  Files         163      163              
  Lines        1781     1808      +27     
  Branches      551      560       +9     
==========================================
+ Hits         1769     1778       +9     
- Misses          1       10       +9     
- Partials       11       20       +9
Impacted Files Coverage Δ
packages/uniforms-unstyled/src/SelectField.tsx 92% <33.33%> (-8%) ⬇️
packages/uniforms-bootstrap4/src/RadioField.tsx 75% <33.33%> (-25%) ⬇️
packages/uniforms-semantic/src/SelectField.tsx 92.3% <33.33%> (-7.7%) ⬇️
packages/uniforms-bootstrap3/src/SelectField.tsx 92.3% <33.33%> (-7.7%) ⬇️
packages/uniforms-material/src/SelectField.tsx 95.12% <33.33%> (-4.88%) ⬇️
packages/uniforms-unstyled/src/RadioField.tsx 77.77% <33.33%> (-22.23%) ⬇️
packages/uniforms-bootstrap3/src/RadioField.tsx 77.77% <33.33%> (-22.23%) ⬇️
packages/uniforms-semantic/src/RadioField.tsx 80% <33.33%> (-20%) ⬇️
packages/uniforms-bootstrap4/src/SelectField.tsx 92.3% <33.33%> (-7.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81c554f...1197ecd. Read the comment docs.

Copy link
Contributor

@radekmie radekmie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are aware of the code duplication. It'll be addressed in v3.

@radekmie radekmie added the Type: Bug Bug reports and their fixes label Dec 18, 2019
@radekmie radekmie merged commit 6a30de6 into master Dec 18, 2019
@radekmie radekmie deleted the fix-correct-id branch December 18, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug reports and their fixes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Invalid id
2 participants