Fixed non-string labels (fixes #816). #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #818 +/- ##
==========================================
+ Coverage 97.23% 97.26% +0.02%
==========================================
Files 175 175
Lines 3439 3439
Branches 668 669 +1
==========================================
+ Hits 3344 3345 +1
Misses 8 8
+ Partials 87 86 -1
Continue to review full report at Codecov.
|
|
This will be a nice addition. I was just troubleshooting this when I tried to pass i18n components for label, placeholder, and extra. |
Monteth
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a bug reported in #816 as well as adds a broad set of tests for
labelhandling. We should do the same forplaceholder, but this will come separately.