Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enabled jsx-a11y rules and fixed most linter errors. #895

Merged
merged 10 commits into from
Mar 31, 2021
Merged

Re-enabled jsx-a11y rules and fixed most linter errors. #895

merged 10 commits into from
Mar 31, 2021

Conversation

wadamek65
Copy link
Contributor

@wadamek65 wadamek65 commented Mar 8, 2021 •
edited
Loading

In this PR:

  • Website/docs adjustments
  • Components' adjustments for multiple themes
  • Changed selectors in some tests to more semantic clear ones
  • Updated eslint-config-vazco to version 6.1.1
  • Re-enabled all a11y rules back

@radekmie radekmie added the Type: Feature New features and feature requests label Mar 10, 2021
@radekmie radekmie added this to the v3.3 milestone Mar 10, 2021
@radekmie radekmie linked an issue Mar 10, 2021 that may be closed by this pull request
jsx-a11y accessibility errors #867
Closed
@wadamek65
Refactored event checks in components.
265cd45 
Added example test.

Updated eslint-config Vazco.
@wadamek65 wadamek65 marked this pull request as ready for review March 26, 2021 16:12
@wadamek65 wadamek65 requested review from radekmie and Monteth March 26, 2021 16:13
@codecov
Copy link

codecov bot commented Mar 26, 2021 •
edited
Loading

Codecov Report

Merging #895 (6b5ba81) into master (3dc4d75) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 6b5ba81 differs from pull request most recent head 38d5bf6. Consider uploading reports for the commit 38d5bf6 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #895   +/-   ##
=======================================
  Coverage   97.46%   97.47%           
=======================================
  Files         202      202           
  Lines        3873     3883   +10     
  Branches      769      779   +10     
=======================================
+ Hits         3775     3785   +10     
  Misses         10       10           
  Partials       88       88
Impacted Files Coverage Δ
packages/uniforms-bootstrap3/src/SubmitField.tsx 100.00% <ø> (ø)
packages/uniforms-bootstrap4/src/SubmitField.tsx 100.00% <ø> (ø)
packages/uniforms-bootstrap5/src/SubmitField.tsx 100.00% <ø> (ø)
packages/uniforms-bootstrap3/src/ListAddField.tsx 100.00% <100.00%> (ø)
packages/uniforms-bootstrap3/src/ListDelField.tsx 100.00% <100.00%> (ø)
packages/uniforms-bootstrap4/src/ListAddField.tsx 100.00% <100.00%> (ø)
packages/uniforms-bootstrap4/src/ListDelField.tsx 100.00% <100.00%> (ø)
packages/uniforms-bootstrap5/src/ListAddField.tsx 100.00% <100.00%> (ø)
packages/uniforms-bootstrap5/src/ListDelField.tsx 100.00% <100.00%> (ø)
packages/uniforms-semantic/src/ListAddField.tsx 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dc4d75...38d5bf6. Read the comment docs.

radekmie
radekmie suggested changes Mar 29, 2021
View reviewed changes
@wadamek65
Simplified event types in ListAddField.
38d5bf6 
Regenerated package-lock.json.
@wadamek65 wadamek65 requested a review from radekmie March 30, 2021 15:52
@radekmie radekmie merged commit 9465a6e into master Mar 31, 2021
@radekmie radekmie deleted the a11y-errors branch March 31, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radekmie radekmie radekmie approved these changes

@Monteth Monteth Monteth approved these changes

Assignees
No one assigned
Labels
Type: Feature New features and feature requests
Projects
Open Source
Archived in project
Milestone
v3.3
Development

Successfully merging this pull request may close these issues.

jsx-a11y accessibility errors
3 participants
@wadamek65 @radekmie @Monteth