-
-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added conditional properties and required field assignment in uniforms-bridge-json-schema (closing #919). #936
Conversation
…s-bridge-json-schema.
Codecov Report
@@ Coverage Diff @@
## master #936 +/- ##
==========================================
+ Coverage 97.45% 97.48% +0.03%
==========================================
Files 202 202
Lines 3924 3938 +14
Branches 804 809 +5
==========================================
+ Hits 3824 3839 +15
Misses 11 11
+ Partials 89 88 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add tests, please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, let's add one more test with non-object field with anyOf
that is required.
Co-authored-by: Radosław Miernik <radekmie@gmail.com>
packages/uniforms-bridge-json-schema/__tests__/JSONSchemaBridge.ts
Outdated
Show resolved
Hide resolved
…ms-bridge-json-schema.
Fixed a bug where a field with no computed required subfields gets an empty 'required' prop. The same situation occurs with the 'properties'.