unvis_go: leave unicode unchanged with Unvis() #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the original code for vis() was ported to Go using the []byte{}
notion, this causes issues for multi-rune bytes (which were not
correctly treated -- and caused loss of information).
Fix this by dealing with []rune instead, which better conveys the
concept at hand. In addition, add tests to ensure that this does not
happen again.
Though, we _really_ should move this code into a library which has a
better test suite -- and the parser itself should be reimplemented to be
less ... 80s.
Fixes: #118
Signed-off-by: Aleksa Sarai <asarai@suse.de>
|
I went back and forth on this when porting that code. I'll test this in a bit. |
|
I'm going to be honest, I really just want to rewrite the whole thing and drop the old BSD code entirely. I don't like the fact that the old code is written in such an 80s way -- it's impossible to read. |
|
hahaha. I'm game. I started to, but then wanted it to be cross-compiling sooner, and to ensure it was bug-for-bug compatible went with just a translation. I'll help if we can tackle it incrementally. Either way. |
|
Should I merge this for now? and then the overhaul can begin? |
|
I'd prefer if we merge this now, and then work on the rewrite later. |
|
LGTM |
|
❤️ |
|
:weary_cat:
…On Fri, Feb 10, 2017 at 10:34 AM, Aleksa Sarai ***@***.***> wrote:
❤️
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#119 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAEF6QVALSTlIl5qB0qKg_wLHZEfhY4bks5rbIOKgaJpZM4L9Uj9>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the original code for vis() was ported to Go using the []byte{}
notion, this causes issues for multi-rune bytes (which were not
correctly treated -- and caused loss of information).
Fix this by dealing with []rune instead, which better conveys the
concept at hand. In addition, add tests to ensure that this does not
happen again.
Though, we really should move this code into a library which has a
better test suite -- and the parser itself should be reimplemented to be
less ... 80s.
Fixes: #118
Signed-off-by: Aleksa Sarai asarai@suse.de