*: xattr can Update() #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cyphar |
This is a gnarly patchset that has been mashed together. It uncovered that some aspects of Check were never really working correctly for `xattr` keywords, but also the `Update()` had been left undone for a while. This includes some API changes around the `Keyword` and `KeyVal` types. Also I would like to update the signature for the `UpdateKeywordFunc` to just accept a `KeyVal` as an argugment, rather than a keyword AND the value. with this context there would be no need to guess on the value of what's passed to the xattr update function of whether it needs or already is base64 encoded. Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
|
tests pass. |
|
Sorry for not reviewing this earlier (I had exams the past few days). I'll take a look at this and send a patch if necessary. 😸 |
|
I realized this too, so I didn't wait
…On Tue, Jun 27, 2017, 05:16 Aleksa Sarai ***@***.***> wrote:
Sorry for not reviewing this earlier (I had exams the past few days). I'll
take a look at this and send a patch if necessary. 😸
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#135 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAEF6UJr9woioVIcPr9jmWrPP1BltgXMks5sIMhYgaJpZM4OEaMu>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a gnarly patchset that has been mashed together.
It uncovered that some aspects of Check were never really working
correctly for
xattrkeywords, but also theUpdate()had been leftundone for a while.
This includes some API changes around the
KeywordandKeyValtypes.Also I would like to update the signature for the
UpdateKeywordFunctojust accept a
KeyValas an argugment, rather than a keyword AND thevalue. with this context there would be no need to guess on the value of
what's passed to the xattr update function of whether it needs or
already is base64 encoded.
Signed-off-by: Vincent Batts vbatts@hashbangbash.com