compare: correctly use .Prefix() during comparisons #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It'd also be nice if I could get a patch release for this, so I don't have to vendor a commit ID. 😉 |
During the rework of how xattr fields are handled, the comparison code was not correctly updated. As a result, changes to xattrs would not be detected in any form. This was detected in the umoci integration suite. In addition, fix the dh.UsedKeywords logic so auto-detection works correctly with prefix-based xattrs. Fixes: ed464af ("*: xattr can Update()") Signed-off-by: Aleksa Sarai <asarai@suse.de>
|
good stuff. Thanks Aleksa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the rework of how xattr fields are handled, the comparison code
was not correctly updated. As a result, changes to xattrs would not be
detected in any form. This was detected in the umoci integration suite.
Fixes #140
Fixes: ed464af ("*: xattr can Update()")
Signed-off-by: Aleksa Sarai asarai@suse.de