Carry 199 #201
Open
Carry 199 #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
interesting... It seems the failures were due to the golang tests being run in parallel? I thought it was default to serial unless |
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
|
Oh, still working on this? FWIW, we have created this incomplete awk script that seem to work for our users https://github.com/bazel-contrib/bazel-lib/blob/main/lib/private/modify_mtree.awk and is easier to maintain since the bug fixes directly go into this file and get released with a single tag. |
|
Ah right on!
I was curious if this was still worth merging. I saw that y'all would
pursue the awk script instead. If this mutate has other use, I'm happy
to move forward with it.
…On 01/11/24 10:12 -0700, Sahin Yort wrote:
Oh, still working on this? FWIW, we have created this incomplete awk script that seem to work for our users https://github.com/bazel-contrib/bazel-lib/blob/main/lib/private/modify_mtree.awk and is easier to maintain since the bug fixes directly go into this file and get released with a single tag.
--
Reply to this email directly or view it on GitHub:
#201 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
carry #199 for re-running tests