feat(cacheDir): Add ability to cache optimized images #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @anncwb for vis/review |
xuzaixian
reviewed
Aug 25, 2023
| @@ -30,14 +31,21 @@ export default function (options: VitePluginImageMin = {}) { | |||
| let publicDir: string | |||
| let config: ResolvedConfig | |||
|
|
|||
| const { disable = false, filter = extRE, verbose = true } = options | |||
| const { disable = false, filter = extRE, verbose = true, cacheDir } = options | |||
There was a problem hiding this comment.
It would be nice if you set a default value for cacheDir.
There was a problem hiding this comment.
I think if a user does not provide a value for cacheDir, it might imply they do not wish to use the caching feature. Therefore, it might be better not to set a default value in this case to avoid unintentional use of caching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a la https://github.com/Klathmon/imagemin-webpack-plugin#optionscachefolder