-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tab close by key, fixed: #4132 #4136
Conversation
|
WalkthroughThe recent changes to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/stores/src/modules/tabbar.ts (2 hunks)
Additional comments not posted (2)
packages/stores/src/modules/tabbar.ts (2)
Line range hint
80-87
: Integration ofrouter
parameter in_goToTab
is appropriate.The addition of the
router
parameter allows for navigation, which aligns with the function's purpose. The use ofrouter.replace
is appropriate for replacing the current route with the new tab.
247-256
: Integration ofrouter
parameter incloseTabByKey
is appropriate.The addition of the
router
parameter allows for closing tabs using routing capabilities, which enhances the function's utility. The decoding of thekey
ensures accurate targeting of tabs.
Description
修复closeTabByKey函数的key比较逻辑,解决 #4132
Type of change
Please delete options that are not relevant.
Summary by CodeRabbit
New Features
Bug Fixes