feat: add left and right scroll buttons to Tabs bar #4161 #4162
Conversation
|
WalkthroughThe recent changes enhance the tab components in the UI kit, focusing on accessibility and usability. Key updates include the addition of an Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant TabBar
participant ScrollBar
User->>TabBar: Scroll left/right
TabBar->>ScrollBar: Trigger scroll action
ScrollBar-->>TabBar: Update view
TabBar->>User: Display updated tabs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
Files selected for processing (4)
- packages/@core/ui-kit/tabs-ui/src/components/tabs-chrome/tabs.vue (1 hunks)
- packages/@core/ui-kit/tabs-ui/src/components/tabs/tabs.vue (1 hunks)
- packages/effects/layouts/package.json (1 hunks)
- packages/effects/layouts/src/basic/tabbar/tabbar.vue (4 hunks)
Files skipped from review due to trivial changes (2)
- packages/@core/ui-kit/tabs-ui/src/components/tabs-chrome/tabs.vue
- packages/@core/ui-kit/tabs-ui/src/components/tabs/tabs.vue
Additional comments not posted (4)
packages/effects/layouts/package.json (1)
23-23: Dependency Addition:@radix-icons/vue.The addition of the
@radix-icons/vuepackage is appropriate given the new icon usage in thetabbar.vuecomponent. Ensure that the package is correctly installed and used across the project.packages/effects/layouts/src/basic/tabbar/tabbar.vue (3)
Line range hint
2-17:
New Imports for Scrolling and Icons.The imports for
onMounted,ChevronLeftIcon,ChevronRightIcon, anduseTabViewScrollare appropriate for the new scrolling functionality and icon usage in the tab bar. Ensure these are correctly integrated and utilized throughout the component.
59-68: Scroll Elements Initialization.The
onMountedhook correctly initializes the scroll elements by querying the DOM and setting them withsetScrollBarElandsetScrollViewEl. Ensure that the element selectors are accurate and that the elements exist in the DOM when this code runs.
Line range hint
72-94:
Template Enhancements for Scrolling.The addition of
ChevronLeftIconandChevronRightIconin the template provides intuitive controls for scrolling through tabs. The@clickevents are appropriately set to callscrollDirectionwith the correct parameters. Ensure that thescrollDirectionmethod is implemented correctly to handle these actions.
P2K0
changed the title
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
Files selected for processing (5)
- packages/@core/ui-kit/tabs-ui/src/components/tabs-chrome/tabs.vue (1 hunks)
- packages/@core/ui-kit/tabs-ui/src/components/tabs/tabs.vue (1 hunks)
- packages/effects/layouts/package.json (1 hunks)
- packages/effects/layouts/src/basic/tabbar/tabbar.vue (4 hunks)
- packages/effects/layouts/src/basic/tabbar/use-tab-view-scroll.ts (1 hunks)
Files skipped from review as they are similar to previous changes (4)
- packages/@core/ui-kit/tabs-ui/src/components/tabs-chrome/tabs.vue
- packages/@core/ui-kit/tabs-ui/src/components/tabs/tabs.vue
- packages/effects/layouts/package.json
- packages/effects/layouts/src/basic/tabbar/tabbar.vue
Additional comments not posted (4)
packages/effects/layouts/src/basic/tabbar/use-tab-view-scroll.ts (4)
9-11: LGTM!The
setScrollBarElfunction is straightforward and correctly assigns the element to the reactive reference.
13-15: LGTM!The
setScrollViewElfunction is straightforward and correctly assigns the element to the reactive reference.
17-27: LGTM!The
getScrollClientWidthfunction correctly calculates and returns the client widths of the scrollbar and viewport elements, handling null cases appropriately.
29-43: LGTM!The
scrollDirectionfunction correctly handles scrolling logic with smooth behavior, ensuring checks for element existence and appropriate conditions for scrolling.
Description
Type of change
Please delete options that are not relevant.
pnpm-lock.yamlunless you introduce a new test example.Checklist
pnpm run docs:devcommand.pnpm test.feat:,fix:,perf:,docs:, orchore:.Summary by CodeRabbit
New Features
Improvements
idattribute to the scrollbar components for better accessibility and targeting in styling.