Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update fetch URL to use BASE_URL for version tag retrieval #4448

Merged
merged 2 commits into from
Sep 20, 2024
Merged

fix: update fetch URL to use BASE_URL for version tag retrieval #4448

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ca3d8b
fix: update fetch URL to use BASE_URL for version tag retrieval
Sep 20, 2024
15cb49b
feat: add configurable update check URL for better flexibility
Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/effects/layouts/src/widgets/check-updates/check-updates.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,15 @@ import { ToastAction, useToast } from '@vben-core/shadcn-ui';
interface Props {
// 轮训时间，分钟
checkUpdatesInterval?: number;
// 检查更新的地址
checkUpdateUrl?: string;
}

defineOptions({ name: 'CheckUpdates' });

const props = withDefaults(defineProps<Props>(), {
checkUpdatesInterval: 1,
checkUpdateUrl: import.meta.env.BASE_URL || '/',
});

const lastVersionTag = ref('');
Expand All @@ -28,7 +31,7 @@ async function getVersionTag() {
) {
return null;
}
const response = await fetch('/', {
const response = await fetch(props.checkUpdateUrl, {
cache: 'no-cache',
method: 'HEAD',
});
Expand Down