-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tabView title internationalization switchover problem #4652
Conversation
当tabView被固定或取消固定后,切换国际化,该tabView的title国际化切换失败
|
WalkthroughThe changes in this pull request focus on the Changes
Suggested labels
Suggested reviewers
Poem
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
packages/stores/src/modules/tabbar.ts (1)
309-311
: Consider adding unit tests for the new behaviorThe changes to
pinTab
andunpinTab
methods effectively address the internationalization issue for tab titles. To ensure this behavior is maintained in future updates, consider adding unit tests that verify:
- The tab title is preserved when pinning a tab.
- The tab title is preserved when unpinning a tab.
- The behavior is consistent across different locales.
This will help prevent regressions and document the expected behavior.
Also applies to: 416-418
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- packages/stores/src/modules/tabbar.ts (2 hunks)
🧰 Additional context used
🔇 Additional comments (2)
packages/stores/src/modules/tabbar.ts (2)
309-311
: LGTM: Preserving tab title when pinningThis change addresses the internationalization issue by retaining the original tab title when pinning a tab. It ensures that the localized title is not lost during the pinning process, which aligns with the PR objectives.
416-418
: LGTM: Preserving tab title when unpinningThis change complements the
pinTab
method by retaining the original tab title when unpinning a tab. It ensures consistency in handling localized titles during tab state changes, addressing the internationalization issue mentioned in the PR objectives.
当tabView被固定或取消固定后,切换国际化,该tabView的title国际化切换失败
Description
Type of change
Please delete options that are not relevant.
pnpm-lock.yaml
unless you introduce a new test example.Checklist
pnpm run docs:dev
command.pnpm test
.feat:
,fix:
,perf:
,docs:
, orchore:
.Summary by CodeRabbit
New Features
Bug Fixes