fix: login page brand color does not take effect

[anncwb]

Description

fixed #4651

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

• If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
• Run the tests with pnpm test.
• Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

• New Features

  • Enhanced color toggle functionality to support more specific theme preferences.
  • Improved handling of color updates with separate parameters for color and type.

• Bug Fixes

  • Fixed issues with the previous method signature that limited color update capabilities.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 271d5f4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The pull request modifies the handleUpdate function in the color-toggle.vue component to accept two parameters: colorPrimary (string) and type (BuiltinThemeType), replacing the previous single parameter. The internal logic is adjusted to utilize colorPrimary for updating theme preferences. Additionally, the click event handler for the VbenIconButton component is updated to pass both preset.color and preset.type to the handleUpdate function, enhancing the handling of color updates.

Changes

Files	Change Summary
packages/effects/layouts/src/widgets/color-toggle.vue	Updated handleUpdate function signature to accept colorPrimary and type. Adjusted internal logic to use colorPrimary for theme updates. Modified click event handler to pass both preset.color and preset.type.

Assessment against linked issues

Objective	Addressed	Explanation
Fix theme application on login page (#4651)	✅

Possibly related PRs

• fix: default theme colors cannot be overridden #4636: Involves modifications to how theme colors are handled, specifically related to the colorPrimary property, which connects to the updates made in this PR.

Suggested reviewers

• vince292007

Poem

Hop hop hooray, a change in the hue,
ColorPrimary shines bright, oh what a view!
With type by its side, they dance in delight,
A theme that now glows, from morning till night! 🌈✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)

packages/effects/layouts/src/widgets/color-toggle.vue (1)

16-22: Approved: Function signature update improves theme control

The changes to the handleUpdate function improve the granularity of theme control by separating colorPrimary and type. This aligns well with the PR objective of fixing the theme application issue.

Consider adding a comment explaining the purpose of this function and the significance of separating colorPrimary and type. This would enhance code readability and maintainability.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 850a6af and 271d5f4.

📒 Files selected for processing (1)

• packages/effects/layouts/src/widgets/color-toggle.vue (2 hunks)

🧰 Additional context used

🔇 Additional comments (1)

packages/effects/layouts/src/widgets/color-toggle.vue (1)

Line range hint 1-67: Summary: Changes effectively address the theme application issue

The modifications in this file directly address the PR objective of fixing the bug where the login page's theme color was not being applied correctly. The changes include:

1. Updating the handleUpdate function to accept separate colorPrimary and type parameters.
2. Modifying the template to pass both color and type information when updating the theme.

These changes provide more granular control over theme application and should resolve the issue described in the linked bug report (#4651).

To fully close this issue:

1. Ensure comprehensive testing of the login page theme functionality across different scenarios.
2. Update any relevant documentation to reflect these changes in theme handling.
3. Consider adding a note in the changelog about this bug fix.