fix: when the form is destroyed, the form parameters still exist

[anncwb]

Description

close #4824
fixed #4785
fixed #4752

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

• If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
• Run the tests with pnpm test.
• Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

Release Notes

• Documentation Updates

  • Enhanced documentation for the Vben Vxe Table component, covering features like pagination, sorting, filtering, and custom cell rendering with practical examples.
  • Updated style documentation to reflect new SCSS usage, emphasizing modularity with the @use directive and providing updated examples for style management.

• Bug Fixes

  • Improved form handling by resetting form state upon unmounting.

• New Features

  • Added lifecycle management for cleanup in the use-vxe-grid component.

• Package Updates

  • Updated multiple dependencies to their latest versions for improved performance and security.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 25a1ea9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces extensive updates to the documentation for the Vben Vxe Table component, enhancing clarity and usability. It details features such as pagination, sorting, filtering, and custom cell rendering. The style import syntax across various documentation files has been updated to use the @use directive instead of @import. Additionally, the unmount method in the FormApi class has been modified to reset the form state, and package dependencies have been updated in the pnpm-workspace.yaml file.

Changes

File	Change Summary
docs/src/components/common-ui/vben-vxe-table.md	Updated documentation for Vben Vxe Table, added sections on features, custom cell rendering, and API details. Added functions and types for better integration.
docs/src/en/guide/essentials/styles.md	Updated style import syntax from @import to @use for better modularity.
docs/src/guide/essentials/styles.md	Clarified project structure and updated SCSS usage, including examples and recommendations for BEM naming conventions.
internal/vite-config/src/config/application.ts	Modified createCssOptions function to use @use for global styles in SCSS.
packages/@core/ui-kit/form-ui/src/form-api.ts	Updated unmount method in FormApi to reset form state on unmount.
packages/effects/plugins/src/vxe-table/use-vxe-grid.vue	Added onUnmounted lifecycle hook for cleanup in use-vxe-grid component.
packages/styles/src/global/index.scss	Changed global style import from @import to @use for modularity.
pnpm-workspace.yaml	Updated package versions and added new dependencies.

Assessment against linked issues

Objective	Addressed	Explanation
Fix form parameters not updating (#4824)	❓	It's unclear if the changes directly address the query function's issue with form parameters.
Reset form state when drawer is reopened (#4785)	✅	The addition of resetting form state in the unmount method addresses this issue.
Ensure form search works with modal/drawer (#4752)	✅	Enhancements in form handling should improve search functionality within modals.

Possibly related PRs

• fix: when the form is opened repeatedly, the state is unexpectedly stroyed #4406: Modifies the FormApi class, relevant to changes in form handling.
• fix(@vben/plugins/vxe-table): after resetting the search, the parameters still exist #4577: Fixes a bug related to search parameters in a table component, which aligns with the main PR's goal of ensuring that only relevant form data is carried over when paging.
• fix: form does not take effect in vertical layout #4680: Addresses a bug related to form layout and class application, which may relate to the overall handling of form data and its presentation in the UI.
• fix: form data that is not submitted by the form should not be carried when switching paging #4847: Specifically addresses the issue of form data retention when switching pages, ensuring that only submitted data is carried over.

Suggested reviewers

• vince292007

Poem

🐇 In the meadow where tables grow,
Forms and styles now flow and glow.
With a hop and a skip, we reset the state,
In Vben's world, it's never too late!
Documentation shines bright and clear,
Join us, dear coder, have no fear! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[hebicheng]

这个问题似乎仍然存在，在modal使用带查询的table，第一次打开能正常带参数查询，关闭modal后再打开，再查询就没有参数了，formValues为空。