fix: pages cannot be quickly moved back by hand gestures #4845
Conversation
|
WalkthroughThe pull request introduces several changes primarily focused on styling and dependency management. The Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
packages/@core/base/design/src/css/global.css (1)
Line range hint
98-116: Well-implemented platform detection for scrollbar styles.Good practice using the
[data-platform='macOs']attribute to exclude macOS from custom scrollbar styling. This allows:
- Native macOS scrollbar behavior to work as expected
- Custom scrollbar styling for other platforms
- Consistent with the PR's goal of improving macOS user experience
Consider documenting how the
data-platformattribute is set, to ensure proper platform detection across the application.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (4)
packages/@core/base/design/src/css/global.css(1 hunks)packages/effects/layouts/package.json(1 hunks)packages/effects/layouts/src/index.ts(1 hunks)pnpm-workspace.yaml(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- packages/effects/layouts/src/index.ts
- pnpm-workspace.yaml
🔇 Additional comments (3)
packages/effects/layouts/package.json (2)
40-40: LGTM! Good choice for fixing the trackpad gesture issue.
The addition of default-passive-events is a suitable solution for the macOS trackpad navigation problem. This package helps optimize touch and wheel event handling by making these events passive by default, which should resolve the gesture navigation issues reported in #4830.
40-40: Verify dependency uniqueness across workspace packages.
Let's ensure this dependency isn't already included in other workspace packages to avoid duplication.
✅ Verification successful
Dependency is unique and properly used
The dependency default-passive-events is only present in packages/effects/layouts/package.json and is imported only once in packages/effects/layouts/src/index.ts. There is no duplication across workspace packages.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for potential duplicate dependencies across workspace packages
# Test: Search for default-passive-events in all package.json files
echo "Checking for default-passive-events in all package.json files:"
fd package.json --exec grep -l "default-passive-events"
# Test: Check if the package is already imported elsewhere
echo -e "\nChecking for existing imports of default-passive-events:"
rg "import.*default-passive-events" --type ts
Length of output: 478
packages/@core/base/design/src/css/global.css (1)
34-34: LGTM! This change fixes the macOS trackpad gesture issue.
The removal of overscroll-none from the base styles is the correct fix for issue #4830. This CSS property was preventing the native macOS trackpad gestures from working properly for page navigation.
Description
fixed #4830
Type of change
Please delete options that are not relevant.
pnpm-lock.yamlunless you introduce a new test example.Checklist
pnpm run docs:devcommand.pnpm test.feat:,fix:,perf:,docs:, orchore:.Summary by CodeRabbit
New Features
.outline-boxclass..flex-centerand.flex-col-center.Bug Fixes
inputandtextareato ensure full opacity.Chores
@vben/layoutsto include"default-passive-events": "^2.0.0".@iconify/jsonin the workspace configuration.