-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: clipboard demo not working with a-input #4856
Conversation
|
WalkthroughThe changes in this pull request involve modifying the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
playground/src/views/demos/features/clipboard/index.vue (1)
20-21
: LGTM! The fix correctly implements two-way binding.The changes properly fix the clipboard functionality by adding v-model binding to the Input component and ensuring the copy operation uses the current source value.
Consider enhancing the user experience by:
- Adding error handling for clipboard operations
- Providing visual feedback on successful/failed copy
Here's a suggested implementation:
<Input v-model:value="source" class="mr-3 flex w-[200px]" /> -<Button type="primary" @click="copy(source)"> Copy </Button> +<Button type="primary" @click="async () => { + try { + await copy(source); + message.success('Copied to clipboard!'); + } catch (err) { + message.error('Failed to copy to clipboard'); + } +}"> + Copy +</Button>Don't forget to import the message component:
-import { Button, Card, Input } from 'ant-design-vue'; +import { Button, Card, Input, message } from 'ant-design-vue';
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
playground/src/views/demos/features/clipboard/index.vue
(1 hunks)
🔇 Additional comments (1)
playground/src/views/demos/features/clipboard/index.vue (1)
Line range hint 1-9
: LGTM! Well-structured setup with proper reactive state management.
The script setup follows Vue 3 best practices with proper use of composition API and vueuse's clipboard functionality.
Description
Type of change
Please delete options that are not relevant.
pnpm-lock.yaml
unless you introduce a new test example.Checklist
pnpm run docs:dev
command.pnpm test
.feat:
,fix:
,perf:
,docs:
, orchore:
.Summary by CodeRabbit