fix: vxeTable carry incorrect parameters #4980
Conversation
…correct parameters
|
WalkthroughThe changes in this pull request focus on the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
packages/effects/plugins/src/vxe-table/extends.tsOops! Something went wrong! :( ESLint: 9.15.0 Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/node_modules/@vben/eslint-config/dist/index.mjs' imported from /eslint.config.mjs Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
packages/effects/plugins/src/vxe-table/extends.ts (1)
46-49: Consider translating comments to EnglishWhile the comment provides valuable context about the refresh functionality issue, consider translating it to English to maintain consistency with international open-source practices.
- /** - * 开启toolbarConfig.refresh功能 - * 点击刷新按钮 这里的值为PointerEvent 会携带错误参数 - */ + /** + * When toolbarConfig.refresh is enabled, + * clicking the refresh button passes a PointerEvent here, + * which would carry incorrect parameters if spread + */
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
packages/effects/plugins/src/vxe-table/extends.ts(1 hunks)
🔇 Additional comments (1)
packages/effects/plugins/src/vxe-table/extends.ts (1)
50-50: LGTM! Elegant solution to prevent incorrect parameter propagation
The conditional spread operation effectively prevents the refresh button's PointerEvent from introducing unrelated parameters while maintaining the existing behavior for other cases.
Let's verify the fix addresses all cases:
✅ Verification successful
Let me gather more context about the refresh functionality to ensure this change doesn't have unintended consequences.
The PointerEvent handling fix is correctly implemented and isolated
The verification confirms that:
- The PointerEvent check is only used in this specific refresh button context
- The
customValuesparameter is properly handled in the function signature and spread operation - There are no other instances of PointerEvent handling that could be affected
- The fix specifically targets the documented issue of incorrect parameter propagation during refresh
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for other PointerEvent handling in VxeTable to ensure we're not breaking existing functionality
rg -A 5 "PointerEvent"
# Search for other refresh-related code to ensure consistent handling
ast-grep --pattern 'toolbarConfig.refresh'
Length of output: 663
Script:
#!/bin/bash
# Search for refresh-related code with broader context
rg -A 10 "refresh" packages/effects/plugins/src/vxe-table/
# Look for toolbar configuration patterns
ast-grep --pattern 'toolbar: {
$$$
}'
# Search for customValues usage
rg -A 5 "customValues"
Length of output: 1837
Description
fix #4979
Type of change
Please delete options that are not relevant.
pnpm-lock.yamlunless you introduce a new test example.Checklist
pnpm run docs:devcommand.pnpm test.feat:,fix:,perf:,docs:, orchore:.Summary by CodeRabbit
Bug Fixes
Documentation