fix: modal radius not follow preferences

[mynetfan]

Description

修复Dialog的圆角没有跟随偏好设置的问题

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

• If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
• Run the tests with pnpm test.
• Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

• New Features

  • Enhanced styling flexibility for the modal component with dynamic rounded corners.

• Bug Fixes

  • Improved management of the modal's open state to ensure consistent behavior.

• Refactor

  • Updated the modal's structure and class bindings for better maintainability and readability.

[changeset-bot]

⚠️ No Changeset found

Latest commit: ca65036

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/@core/ui-kit/popup-ui/src/modal/modal.vue

Oops! Something went wrong! :(

ESLint: 9.16.0

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/node_modules/@vben/eslint-config/dist/index.mjs' imported from /eslint.config.mjs
at finalizeResolution (node:internal/modules/esm/resolve:257:11)
at moduleResolve (node:internal/modules/esm/resolve:914:10)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)

Walkthrough

The changes in this pull request focus on the modal.vue component within the UI kit. Key modifications include updates to the styling of the modal's content, specifically changing the class binding to utilize a variable CSS property for rounded corners. The management of the modal's open state has been refined, ensuring proper functionality through updated bindings. Existing event handlers and computed properties related to fullscreen and draggable states have been retained, maintaining the modal's core functionality while improving its presentation.

Changes

File Path	Change Summary
packages/@core/ui-kit/popup-ui/src/modal/modal.vue	Updated class binding for rounded corners, refined modal open state management, and retained event handlers and computed properties.

Possibly related PRs

• chore: update modal.vue #4987: This PR updates the modal.vue file, which is directly related to the main PR's changes in the same file, focusing on enhancing user experience during loading states.
• fix: the onOpenChange event for the modal component does not work as expected #4425: This PR modifies the useVbenModal function in use-modal.ts, which is related to managing the modal's open state, aligning with the main PR's updates to the modal's functionality.
• fix: dialog opened/closed event triggered incorrectly,fixed #4902 #4908: This PR addresses the dialog component's event handling, which is relevant as it deals with the modal's open and close events, similar to the main PR's focus on modal state management.

Suggested labels

bug

Suggested reviewers

• anncwb
• vince292007

🐰 In the modal's cozy nook,
A style update, take a look!
Rounded corners, oh so fine,
With open states that brightly shine.
Event handlers still in play,
Hooray for changes, hip-hip-hooray! 🎉

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between d1862fb and ca65036.

📒 Files selected for processing (1)

• packages/@core/ui-kit/popup-ui/src/modal/modal.vue (1 hunks)

🔇 Additional comments (1)

packages/@core/ui-kit/popup-ui/src/modal/modal.vue (1)

175-175: LGTM! The modal radius now follows theme preferences.

The change from fixed radius (sm:rounded-2xl) to CSS variable (sm:rounded-[var(--radius)]) correctly implements the fix, allowing the modal to respect user preferences for corner radius.

Let's verify the CSS variable definition:

✅ Verification successful

The modal radius change is correctly implemented with proper CSS variable support

The --radius CSS variable is properly defined in the design tokens:

• packages/@core/base/design/src/design-tokens/default.css (light theme)
• packages/@core/base/design/src/design-tokens/dark.css (dark theme)

Both themes set --radius: 0.5rem, which will be correctly applied to the modal through the sm:rounded-[var(--radius)] class.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if --radius CSS variable is properly defined in theme files
# Expected: Find CSS variable definition in theme/style files

# Search for --radius CSS variable definition
rg --type css --type scss --type less "(?:^|\s|;)--radius\s*:" 

Length of output: 93

---

Script:

#!/bin/bash
# Let's try a broader search for --radius definition without file type restrictions
rg --type-add 'styles:*.{css,scss,less,vue,ts,js}' -t styles "(?:^|\s|;)--radius\s*:"

# Also search specifically in the ui-kit package where modal.vue resides
fd . "packages/@core/ui-kit" -e css -e scss -e less -e vue | xargs rg "(?:^|\s|;)--radius\s*:"

# Look for any radius-related CSS custom property definitions
rg "(?:^|\s|;)--.*radius.*:" 

Length of output: 1570

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.