Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: layout overflow style #5066

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Conversation

mynetfan
Copy link
Collaborator

@mynetfan mynetfan commented Dec 7, 2024

Description

修复页面样式调整带来的各种表格布局计算问题。
fix #5058, fix #5065, fix #5028, fix #5027

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
  • Run the tests with pnpm test.
  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

Release Notes

  • Documentation

    • Updated the Page component documentation for improved clarity.
    • Added a new "说明" (Description) column in the Props table.
    • Marked fixedHeader property as "待实现" (To be implemented).
  • New Features

    • Enhanced layout responsiveness and visual behavior in the vben-layout component.
    • Improved dynamic behavior of the layout in response to user interactions, especially in mobile views.
  • Bug Fixes

    • Clarified the handling of the fixedHeader property in the page component, indicating it is not currently implemented.

@mynetfan mynetfan requested review from anncwb, vince292007 and a team as code owners December 7, 2024 04:04
Copy link

changeset-bot bot commented Dec 7, 2024

⚠️ No Changeset found

Latest commit: bc756de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Dec 7, 2024

Caution

Review failed

The pull request is closed.

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/@core/ui-kit/layout-ui/src/vben-layout.vue

Oops! Something went wrong! :(

ESLint: 9.16.0

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/node_modules/@vben/eslint-config/dist/index.mjs' imported from /eslint.config.mjs
at finalizeResolution (node:internal/modules/esm/resolve:257:11)
at moduleResolve (node:internal/modules/esm/resolve:914:10)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)

Walkthrough

The pull request includes updates to the documentation of the Page component, specifically enhancing the Props table with a new "说明" (Description) column and marking the fixedHeader property as "待实现" (To be implemented). Additionally, the vben-layout.vue component has been modified to improve responsiveness and visual behavior, including adjustments to computed properties and watch functions. The fixedHeader property has also been removed from the Props interface in the page.vue component, affecting its interface and expected behavior.

Changes

File Path Change Summary
docs/src/components/layout-ui/page.md Updated Props table to include "说明" column; marked fixedHeader as "待实现" and removed previous description.
packages/@core/ui-kit/layout-ui/src/vben-layout.vue Enhanced layout responsiveness; updated class attributes, computed properties, and watch functions for better behavior.
packages/effects/common-ui/src/components/page/page.vue Removed fixedHeader property from Props interface; commented out its previous declaration.

Assessment against linked issues

Objective Addressed Explanation
Bug: Page组件配合grid使用时样式异常 (#5028)
Bug: 列表页面底部出现滚动条 (#5065) No changes related to scrollbar issues made.
Bug: 窗口宽度改变 表格宽度会缓慢减小 (#5027) Changes do not clarify if this issue is addressed.
Bug: 表格组件(vxe-table)固定列与横向滚动配置失效 (#5058) No modifications related to fixed columns or scrolling.

Possibly related PRs

  • fix: layout overflow style #5066: This PR updates the documentation for the Page component, specifically mentioning the fixedHeader property, which aligns with the main PR's changes regarding the fixedHeader property being marked as "待实现" (To be implemented).
  • fix: Page header class in fixed mode #5023: This PR enhances the Page component's header when in fixed mode, which is directly related to the changes made in the main PR regarding the fixedHeader property.
  • feat: improve page component #5013: This PR introduces the fixed-header attribute to the Page component, which is relevant to the main PR's documentation updates about the fixedHeader property.
  • fix: page prop type check #5067: This PR reintroduces the fixedHeader property in the Props interface of the Page component, which is directly related to the changes made in the main PR regarding the fixedHeader property.
  • chore: remove useless fixedHeader prop for Page #5069: This PR removes the fixedHeader property from the Page component, which is relevant to the main PR's documentation updates about the fixedHeader property being marked as "待实现" (To be implemented).

Suggested reviewers

  • vince292007

Poem

In the layout where we play,
A new column leads the way.
With headers fixed and styles bright,
Our components dance in delight.
For every bug, we mend and fix,
A smoother flow, our clever tricks! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between b75a8e6 and bc756de.

📒 Files selected for processing (3)
  • docs/src/components/layout-ui/page.md (1 hunks)
  • packages/@core/ui-kit/layout-ui/src/vben-layout.vue (1 hunks)
  • packages/effects/common-ui/src/components/page/page.vue (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mynetfan mynetfan merged commit 0fc0f13 into vbenjs:main Dec 7, 2024
9 of 11 checks passed
@mynetfan mynetfan deleted the fix/layout-style branch December 7, 2024 04:05
@anncwb anncwb added the bug Something isn't working label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants