Skip to content

Commit

Permalink
Merge pull request redpanda-data#22733 from rockwotj/clang-18
Browse files Browse the repository at this point in the history
tests: fix some unused parameter warnings in clang-18
  • Loading branch information
rockwotj authored Aug 5, 2024
2 parents b730bcc + 2cc52c5 commit 2c24041
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions src/v/cloud_storage/tests/segment_chunk_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ SEASTAR_THREAD_TEST_CASE(test_eager_chunk_eviction) {
protected:
ss::future<> close_files(
std::vector<ss::lw_shared_ptr<ss::file>> files_to_close,
retry_chain_logger& rtc) override {
retry_chain_logger&) override {
evicted = files_to_close.size();
co_return;
}
Expand Down Expand Up @@ -120,7 +120,7 @@ SEASTAR_THREAD_TEST_CASE(test_capped_chunk_eviction) {
protected:
ss::future<> close_files(
std::vector<ss::lw_shared_ptr<ss::file>> files_to_close,
retry_chain_logger& rtc) override {
retry_chain_logger&) override {
evicted = files_to_close.size();
co_return;
}
Expand Down Expand Up @@ -154,7 +154,7 @@ SEASTAR_THREAD_TEST_CASE(test_predictive_chunk_eviction) {
protected:
ss::future<> close_files(
std::vector<ss::lw_shared_ptr<ss::file>> files_to_close,
retry_chain_logger& rtc) override {
retry_chain_logger&) override {
evicted = files_to_close.size();
co_return;
}
Expand Down
4 changes: 2 additions & 2 deletions src/v/cloud_storage_clients/tests/s3_client_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -841,7 +841,7 @@ class client_pool_fixture {
};

static ss::future<> test_client_pool_payload(
ss::shared_ptr<ss::httpd::http_server_control> server,
ss::shared_ptr<ss::httpd::http_server_control>,
cloud_storage_clients::client_pool::client_lease lease) {
auto client = lease.client;
iobuf payload;
Expand Down Expand Up @@ -877,7 +877,7 @@ FIXTURE_TEST(test_client_pool_wait_strategy, client_pool_fixture) {
}

static ss::future<bool> test_client_pool_reconnect_helper(
ss::shared_ptr<ss::httpd::http_server_control> server,
ss::shared_ptr<ss::httpd::http_server_control>,
cloud_storage_clients::client_pool::client_lease lease) {
auto client = lease.client;
co_await ss::sleep(100ms);
Expand Down

0 comments on commit 2c24041

Please sign in to comment.