Skip to content

Commit

Permalink
rptest: paramterize test_clusters_share_bucket
Browse files Browse the repository at this point in the history
Testing with ABS would have caught a bug in the ABS client during topic
recovery when there are multiple objects within a topic's manifest path
prefix (e.g. from different clusters).
  • Loading branch information
andrwng committed Dec 4, 2024
1 parent 688480d commit f92108b
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions tests/rptest/tests/remote_label_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,12 @@
from rptest.clients.types import TopicSpec
from rptest.services.cluster import cluster
from rptest.clients.rpk import RpkTool
from rptest.services.redpanda import RedpandaService, SISettings, make_redpanda_service
from rptest.services.redpanda import RedpandaService, SISettings, get_cloud_storage_type, make_redpanda_service
from rptest.services.kgo_verifier_services import KgoVerifierProducer
from rptest.tests.redpanda_test import RedpandaTest
from rptest.tests.read_replica_e2e_test import hwms_are_identical, create_read_replica_topic
from rptest.util import wait_until
from ducktape.mark import matrix
from ducktape.tests.test import TestContext
from rptest.utils.si_utils import BucketView, NT, quiesce_uploads

Expand Down Expand Up @@ -90,7 +91,8 @@ def produce(self, cluster: RedpandaService, topic_name: str,
producer.free()

@cluster(num_nodes=3)
def test_clusters_share_bucket(self) -> None:
@matrix(cloud_storage_type=get_cloud_storage_type())
def test_clusters_share_bucket(self, cloud_storage_type) -> None:
"""
cluster 1 creates topic_a
cluster 2 creates topic_a
Expand Down

0 comments on commit f92108b

Please sign in to comment.