Skip to content

Commit

Permalink
fix suggested details
Browse files Browse the repository at this point in the history
  • Loading branch information
fchapoton committed Apr 13, 2024
1 parent 0e0bb0f commit f230dbb
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/sage/modular/quasimodform/ring.py
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ def __init__(self, group=1, base_ring=QQ, name='E2'):
elif not is_CongruenceSubgroup(group):
raise ValueError("Group (=%s) should be a congruence subgroup" % group)

# Check if the base ring is the rationnal field
# Check if the base ring is the rational field
if base_ring != QQ:
raise NotImplementedError("base ring other than Q are not yet supported for quasimodular forms ring")

Expand Down Expand Up @@ -425,12 +425,12 @@ def _element_constructor_(self, datum):
NotImplementedError: conversion from q-expansion not yet implemented
"""
if isinstance(datum, list):
if len(datum) == 0:
if not datum:
raise ValueError("the given list should be non-empty")
for idx, f in enumerate(datum):
if not isinstance(f, (GradedModularFormElement, ModularFormElement)):
raise ValueError("one list element is not a modular form")
datum[idx] = self.__modular_forms_subring(f) # to ensure that every forms is a GradedModularFormElement
datum[idx] = self.__modular_forms_subring(f) # to ensure that every form is a GradedModularFormElement
datum = self.__polynomial_subring(datum)
elif isinstance(datum, (GradedModularFormElement, ModularFormElement)):
datum = self.__modular_forms_subring(datum) # GradedModularFormElement
Expand Down

0 comments on commit f230dbb

Please sign in to comment.