This repository has been archived by the owner on Dec 14, 2020. It is now read-only.
Rename Client to Conn #201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Conway <aconway@redhat.com>
alanconway
force-pushed
the
client-conn
branch
from
df8f136 to
b4ed87f
Compare
|
I'm not prepared to merge this until server support is also ready. |
alanconway
added a commit
to alanconway/vcabbage-amqp
that referenced
this pull request
Dec 5, 2019
example_server_test.go: very simple one-queue broker, tests basic send/receive. - Lots of unfinished stuff: grep for FIXME to see known holes. - Needs much more testing, performance profiling etc. Depends on the following pending PRs, must be re-based after they merge: - vcabbage#204 Improved debug logging. - vcabbage#203 Make conn.Close() wait till shutdown is complete. - vcabbage#201 Rename Client to Conn - vcabbage#198 Fix SEGV when using dynamic addresses. Signed-off-by: Alan Conway <aconway@redhat.com>
Makes sense. Server support is now working for the simplest case but not finished (a lot o f panic("FIXME") in the not-simplest case :) How long till this repo goes dormant? Need to think about whether I finish it here or consider forking/rewriting electron/something else... |
|
Closed per #205 |
alanconway
added a commit
to alanconway/vcabbage-amqp
that referenced
this pull request
Dec 11, 2019
example_server_test.go: very simple one-queue broker, tests basic send/receive. - Lots of unfinished stuff: grep for FIXME to see known holes. - Needs much more testing, performance profiling etc. Depends on the following pending PRs, must be re-based after they merge: - vcabbage#204 Improved debug logging. - vcabbage#203 Make conn.Close() wait till shutdown is complete. - vcabbage#201 Rename Client to Conn - vcabbage#198 Fix SEGV when using dynamic addresses. Signed-off-by: Alan Conway <aconway@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed Client to Conn, with alias type so backward compatible.
Did not rename client.go due to clash with existing conn.go.
Signed-off-by: Alan Conway aconway@redhat.com