Skip to content
This repository has been archived by the owner on May 17, 2020. It is now read-only.

add prefetch #5

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add prefetch #5

wants to merge 4 commits into from

Conversation

vchuravy
Copy link
Owner

@vchuravy vchuravy commented Feb 1, 2019

No description provided.

@vchuravy vchuravy force-pushed the vc/prefetch branch 2 times, most recently from 01683e7 to 125cbde Compare February 1, 2019 23:32
@vchuravy
Copy link
Owner Author

vchuravy commented Mar 5, 2019

@lcw did we decide on whether we need prefetch?

@lcw
Copy link
Collaborator

lcw commented Mar 5, 2019

We do it manually in our current CUDA kernels. I don't think I can say if we need prefetch or not until we can start optimizing some kernels. FYI, I am waiting on JuliaGPU/CUDAnative.jl#349 to land before I start optimizing kernels again.

@vchuravy
Copy link
Owner Author

bors r+

bors bot added a commit that referenced this pull request Mar 18, 2019
@bors @vchuravy @YingboMa
Merge #5
82ed52f 
5: add prefetch r=vchuravy a=vchuravy



Co-authored-by: Valentin Churavy <v.churavy@gmail.com>
Co-authored-by: Yingbo Ma <mayingbo5@gmail.com>
@bors
Copy link
Contributor

bors bot commented Mar 18, 2019

Build failed

@vchuravy
Copy link
Owner Author

bors r+

bors bot added a commit that referenced this pull request Mar 18, 2019
@bors @vchuravy
Merge #5
513474c 
5: add prefetch r=vchuravy a=vchuravy



Co-authored-by: Valentin Churavy <v.churavy@gmail.com>
@bors
Copy link
Contributor

bors bot commented Mar 18, 2019

Build failed

@vchuravy
Copy link
Owner Author

bors r+

bors bot added a commit that referenced this pull request Mar 18, 2019
@bors @vchuravy
Merge #5
2de8377 
5: add prefetch r=vchuravy a=vchuravy



Co-authored-by: Valentin Churavy <v.churavy@gmail.com>
@bors
Copy link
Contributor

bors bot commented Mar 18, 2019

Build failed

@lcw
Copy link
Collaborator

lcw commented Mar 18, 2019 •
edited
Loading

I'll give a stab at creating some docs.

@vchuravy
Copy link
Owner Author

bors try

bors bot added a commit that referenced this pull request Mar 18, 2019
@bors
Try #5:
813de82
@bors
Copy link
Contributor

bors bot commented Mar 18, 2019

try

Build failed

vchuravy and others added 4 commits March 21, 2019 15:40
@vchuravy @YingboMa
add prefetch
d0d3dcc 
Co-authored-by: Valentin Churavy <v.churavy@gmail.com>
Co-authored-by: Yingbo Ma <mayingbo5@gmail.com>
@lcw @vchuravy
Fix typo in prefetch help docs
1804315
@lcw @vchuravy
Add docs for @prefetch
45aa50f
@vchuravy
don't test prefetch on GPU
90ee086
@vchuravy vchuravy added this to the v0.0.3 milestone Mar 21, 2019
@vchuravy
Copy link
Owner Author

So I think the only thing remaining here is to make sure that it also works on the GPU.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@lcw lcw

Labels
None yet
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vchuravy @lcw