This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
Fix issues with zsh and setup.sh #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkruse
added a commit
that referenced
this pull request
Dec 5, 2012
Fix issues with zsh and setup.sh I believe the patch causes no harm, though I cannot reproduce any failure on my zsh. can you give more details on your environment and how to reproduce an error, so that I can set up a regression test?
|
I believe the patch causes no harm, though I cannot reproduce any failure on my zsh. can you give more details on your environment and how to reproduce an error, so that I can set up a regression test? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setup.zsh calls setup.sh, posix mode isn't enabled, so when it calls the main setup.sh, the loop fails, in a similar way to ros/catkin#182
This implements the same fix as was done there, except on the generated setup.zsh from rosws.