Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: module hot reload #755

Merged
merged 12 commits into from
Nov 8, 2022
Merged

fix: module hot reload #755

merged 12 commits into from
Nov 8, 2022

Conversation

2xAA
Copy link
Member

@2xAA 2xAA commented Aug 16, 2022 •
edited by TimPietrusky
Loading

Fixes #773

@2xAA 2xAA requested a review from TimPietrusky August 16, 2022 20:21
@2xAA
Copy link
Member Author

2xAA commented Aug 19, 2022

We could replace JSON.parse(JSON.stringify()) with structuredClone

@2xAA
Copy link
Member Author

2xAA commented Aug 20, 2022 •
edited
Loading

Yikes, maybe not!
https://jsbench.me/gql72as3ud/2

TimPietrusky
TimPietrusky approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@TimPietrusky TimPietrusky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested both with a simple and my heavy presets. Everything looks fine.

@TimPietrusky TimPietrusky merged commit b67cd91 into next Nov 8, 2022
@TimPietrusky TimPietrusky deleted the fix/module-hot-reload branch November 8, 2022 22:36
TimPietrusky added a commit that referenced this pull request Nov 8, 2022
@TimPietrusky
Merge pull request #786 from vcync/next
fa582e4 
fix: module hot reload (#755)
2xAA pushed a commit that referenced this pull request Nov 8, 2022
@semantic-release-bot
chore(release): 3.25.5
1681b23 
## [3.25.5](3.25.4...3.25.5) (2022-11-08)

### Bug Fixes

* module hot reload ([#755](#755)) ([b67cd91](b67cd91))
@2xAA
Copy link
Member Author

2xAA commented Nov 8, 2022

🎉 This PR is included in version 3.25.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@2xAA 2xAA added the released label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimPietrusky TimPietrusky TimPietrusky approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
2 participants
@2xAA @TimPietrusky