Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(context-menu): add electron context menu #790

Merged
merged 15 commits into from
Jun 21, 2023
Merged

feat(context-menu): add electron context menu #790

merged 15 commits into from
Jun 21, 2023

Conversation

2xAA
Copy link
Member

@2xAA 2xAA commented Nov 12, 2022

removes old context menu plugin and adds context menu with a few examples, including module duplication

re #789

removes old context menu plugin and adds context menu with a few examples, including module
duplication

re #789
@2xAA
Copy link
Member Author

2xAA commented Nov 29, 2022

For after this PR:

  • Reset active module
  • Reset per active module property
  • Group duplication
  • Add option to duplicate without inputLinks

@2xAA
Copy link
Member Author

2xAA commented Mar 15, 2023

Duplication of THREE modules causes a crash.

@2xAA
Copy link
Member Author

2xAA commented Mar 15, 2023

Right click features on existing controls interfere with context menu.
Don't bubble from existing features.

@2xAA
Copy link
Member Author

2xAA commented Mar 15, 2023

Investigate Input Config panel on duplication. (seems to be stuck)

@2xAA
Copy link
Member Author

2xAA commented Mar 16, 2023

Expressions are not duplicated.

@2xAA
Copy link
Member Author

2xAA commented Mar 16, 2023

Investigate Input Config panel on duplication. (seems to be stuck)

It's not broken, input links can be created on previously focused props even if they're not visible anymore.
We should fix this in another issue.

@2xAA 2xAA linked an issue Jun 21, 2023 that may be closed by this pull request
@2xAA 2xAA merged commit 09c28fd into next Jun 21, 2023
@2xAA 2xAA deleted the feat/contextMenu branch June 21, 2023 21:51
github-actions bot pushed a commit that referenced this pull request Jun 21, 2023
# [3.29.0](3.28.0...3.29.0) (2023-06-21)

### Bug Fixes

* exit the app properly when the main window has confirmed quit ([#863](#863)) ([e12bbe5](e12bbe5))
* **groups:** prevent occational UI jump when updating module order ([#872](#872)) ([00cd620](00cd620))

### Features

* **context-menu:** add electron context menu ([#790](#790)) ([09c28fd](09c28fd)), closes [#789](#789)
@github-actions
Copy link

🎉 This PR is included in version 3.29.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloning Modules
1 participant