Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config agent core ngt service kvs test #1223

Merged
merged 19 commits into from
May 24, 2021

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented May 11, 2021

Signed-off-by: hlts2 hiroto.funakoshi.hiroto@gmail.com

Description:

I added test for pkg/agent/core/ngt/service/kvs/test.
and I added comment

gramer check passed

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.16
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.3

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #1223 (9809d2b) into master (9a6a040) will increase coverage by 0.47%.
The diff coverage is n/a.

❗ Current head 9809d2b differs from pull request most recent head aad537f. Consider uploading reports for the commit aad537f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1223      +/-   ##
==========================================
+ Coverage   17.59%   18.06%   +0.47%     
==========================================
  Files         501      501              
  Lines       31190    31190              
==========================================
+ Hits         5488     5636     +148     
+ Misses      25416    25255     -161     
- Partials      286      299      +13     
Impacted Files Coverage Δ
pkg/agent/core/ngt/service/kvs/kvs.go 95.55% <ø> (+95.55%) ⬆️
internal/worker/queue.go 98.33% <0.00%> (-1.67%) ⬇️
internal/worker/worker.go 82.29% <0.00%> (-1.05%) ⬇️
pkg/agent/core/ngt/service/kvs/ou.go 61.33% <0.00%> (+61.33%) ⬆️
pkg/agent/core/ngt/service/kvs/uo.go 67.77% <0.00%> (+67.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36ca453...aad537f. Read the comment docs.

@github-actions github-actions bot added size/XXL and removed size/XL labels May 12, 2021
pkg/agent/core/ngt/service/kvs/kvs.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs.go Outdated Show resolved Hide resolved
@hlts2 hlts2 changed the title [WIP] Add config agent core ngt service kvs test Add config agent core ngt service kvs test May 12, 2021
@hlts2 hlts2 requested review from kevindiu and vankichi May 13, 2021 01:18
pkg/agent/core/ngt/service/kvs/kvs.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs_test.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs_test.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs_test.go Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs_test.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs_test.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs_test.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs_test.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs_test.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented minor things.

pkg/agent/core/ngt/service/kvs/kvs_test.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs_test.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs.go Outdated Show resolved Hide resolved
kevindiu
kevindiu previously approved these changes May 17, 2021
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to check the comment again

pkg/agent/core/ngt/service/kvs/kvs.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs_test.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs_test.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs_test.go Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs_test.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs_test.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs_test.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs_test.go Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs_test.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/service/kvs/kvs_test.go Outdated Show resolved Hide resolved
vankichi
vankichi previously approved these changes May 24, 2021
@kevindiu
Copy link
Contributor

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kevindiu for branch: test/pkg/add-config-agent-core-ngt-service-kvs-test

hlts2 and others added 19 commits May 24, 2021 00:52
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
@vdaas-ci vdaas-ci dismissed stale reviews from vankichi and kevindiu via aad537f May 24, 2021 00:52
@vdaas-ci vdaas-ci force-pushed the test/pkg/add-config-agent-core-ngt-service-kvs-test branch from 9809d2b to aad537f Compare May 24, 2021 00:52
@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by kevindiu.

Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by kevindiu.

@kevindiu kevindiu merged commit b18982b into master May 24, 2021
@kevindiu kevindiu deleted the test/pkg/add-config-agent-core-ngt-service-kvs-test branch May 24, 2021 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants