Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI error of copy test #1269

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Conversation

kevindiu
Copy link
Contributor

@kevindiu kevindiu commented Jun 1, 2021

Signed-off-by: kevindiu kevin_diu@yahoo.com.hk

Description:

This PR fixes CI error.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.16.4
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.3

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 1, 2021

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

"io"
"reflect"
"sync"
"testing"

"github.com/vdaas/vald/internal/errors"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
File is not gci-ed (gci)

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #1269 (feec98b) into master (7d95333) will increase coverage by 0.06%.
The diff coverage is n/a.

❗ Current head feec98b differs from pull request most recent head 470b097. Consider uploading reports for the commit 470b097 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1269      +/-   ##
==========================================
+ Coverage   17.11%   17.17%   +0.06%     
==========================================
  Files         506      508       +2     
  Lines       31776    31892     +116     
==========================================
+ Hits         5439     5478      +39     
- Misses      26049    26116      +67     
- Partials      288      298      +10     
Impacted Files Coverage Δ
internal/errgroup/group.go 92.42% <0.00%> (-1.52%) ⬇️
internal/io/io.go 0.00% <0.00%> (ø)
internal/io/copy.go 63.33% <0.00%> (ø)
internal/worker/worker.go 84.37% <0.00%> (+1.04%) ⬆️
internal/worker/queue.go 100.00% <0.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a51ce7...470b097. Read the comment docs.

@kevindiu kevindiu requested a review from kpango June 1, 2021 08:10
@kpango kpango merged commit 7eb9847 into master Jun 1, 2021
@kpango kpango deleted the test/internal/fix-copy-test-build-err branch June 1, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants