-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix race error of server package #1689
Conversation
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
[CHATOPS:HELP] ChatOps commands.
|
Codecov Report
@@ Coverage Diff @@
## master #1689 +/- ##
==========================================
+ Coverage 31.30% 31.35% +0.05%
==========================================
Files 374 374
Lines 32591 32591
==========================================
+ Hits 10203 10220 +17
+ Misses 22003 21989 -14
+ Partials 385 382 -3
Continue to review full report at Codecov.
|
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :)
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Description:
WHAT
This PR contains the following changes.
errgroup
, but whenerrgroup.Get
is used in the test case, a race condition occurs due to conflicts with other test functions.WHY
A race error was occurring in the server package.
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: