Use internal comparator instead of go-cmp #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
|
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
team/set
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2132 +/- ##
==========================================
+ Coverage 31.14% 31.15% +0.01%
==========================================
Files 339 339
Lines 32834 32834
==========================================
+ Hits 10226 10230 +4
Misses 22155 22155
+ Partials 453 449 -4 ☔ View full report in Codecov by Sentry. |
kevindiu
requested review from
a team,
kmrmt and
hlts2
and removed request for
a team
kevindiu
changed the title
|
|
Deploying with
|
| Latest commit: |
6a6b55a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2ece0955.vald.pages.dev |
| Branch Preview URL: | https://refactor-test-use-internal-g.vald.pages.dev |
kmrmt
previously approved these changes
Jul 18, 2023
|
Please check why |
|
fix deepsource warning. thank you! |
ykadowak
approved these changes
Jul 19, 2023
hlts2
approved these changes
Jul 25, 2023
kevindiu
force-pushed
the
refactor/test/use-internal-go-cmp
branch
from
9e2bb28 to
f7e8265
Compare
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
kevindiu
force-pushed
the
refactor/test/use-internal-go-cmp
branch
from
f7e8265 to
6a6b55a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Use internal comparator interface instead of directly using go-cmp library.
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: