Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add StreamListObject to LB #2203

Merged
merged 6 commits into from
Oct 11, 2023
Merged

Add StreamListObject to LB #2203

merged 6 commits into from
Oct 11, 2023

Conversation

ykadowak
Copy link
Contributor

@ykadowak ykadowak commented Oct 5, 2023 •
edited
Loading

Description:

This PR implements StreamListObject to LB. No unit test added because its in the handler layer. E2E test added.

Related Issue:

Versions:

  • Go Version: 1.21.1
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.2
  • NGT Version: 2.1.3

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Oct 5, 2023

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Oct 5, 2023 •
edited
Loading

Codecov Report

Attention: 78 lines in your changes are missing coverage. Please review.

Files Coverage Δ
pkg/gateway/lb/service/gateway.go 0.00% <ø> (ø)
internal/errors/grpc.go 60.00% <0.00%> (-15.00%) ⬇️
pkg/gateway/lb/handler/grpc/handler.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@ykadowak ykadowak force-pushed the feature/gateway/streamlistobject branch from 582f24e to 349053f Compare October 5, 2023 06:42
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 5, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e6d3176
Status: ✅  Deploy successful!
Preview URL: https://63c17052.vald.pages.dev
Branch Preview URL: https://feature-gateway-streamlistob.vald.pages.dev

View logs

@github-actions github-actions bot added the team/set SET team label Oct 5, 2023
@ykadowak ykadowak changed the title [WIP] Add StreamListObject to LB Add StreamListObject to LB Oct 5, 2023
@ykadowak ykadowak requested review from a team, kpango and vankichi and removed request for a team October 5, 2023 08:00
@ykadowak ykadowak mentioned this pull request Oct 10, 2023
Merged
2 tasks
kpango
kpango previously approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vankichi
vankichi requested changes Oct 10, 2023
View reviewed changes
internal/errors/grpc.go Outdated Show resolved Hide resolved
@ykadowak @vankichi
Update internal/errors/grpc.go
e6d3176 
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
@ykadowak ykadowak requested review from vankichi and kpango October 10, 2023 07:02
vankichi
vankichi approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykadowak ykadowak merged commit 9f27ff2 into main Oct 11, 2023
@ykadowak ykadowak deleted the feature/gateway/streamlistobject branch October 11, 2023 00:45
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add StreamListObject to LB (#2203)"
a928a96 
This reverts commit 9f27ff2.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add StreamListObject to LB (#2203)"
91cb392 
This reverts commit 9f27ff2.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add StreamListObject to LB (#2203)"
471b421 
This reverts commit 9f27ff2.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add StreamListObject to LB (#2203)"
bcc256b 
This reverts commit 9f27ff2.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add StreamListObject to LB (#2203)"
ab0f08d 
This reverts commit 9f27ff2.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add StreamListObject to LB (#2203)"
8173d8c 
This reverts commit 9f27ff2.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add StreamListObject to LB (#2203)"
6bc2dde 
This reverts commit 9f27ff2.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add StreamListObject to LB (#2203)"
0b8b617 
This reverts commit 9f27ff2.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add StreamListObject to LB (#2203)"
efbf57b 
This reverts commit 9f27ff2.
@vankichi vankichi mentioned this pull request Dec 4, 2023
Merged
kmrmt pushed a commit that referenced this pull request Dec 12, 2023
@ykadowak @vankichi @kmrmt
Add StreamListObject to LB (#2203)
fee6a3c 
* Add StreamListObject to LB

* Add E2E for StreamListObject

* Update error handling

* Fix StreamListObject e2e verification

* Update internal/errors/grpc.go

Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>

---------

Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vankichi vankichi vankichi approved these changes

@kpango kpango kpango approved these changes

Assignees
No one assigned
Labels
actions/e2e-deploy area/gateway/lb area/internal priority/medium size/L team/set SET team type/feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ykadowak @vdaas-ci @kpango @vankichi