Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add make command to update template #2212

Merged
merged 6 commits into from
Oct 23, 2023
Merged

Add make command to update template #2212

merged 6 commits into from
Oct 23, 2023

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Oct 18, 2023 •
edited
Loading

Description:

This PR contains the following changes.

  • Add update/template command to update pull_require_template and issue_template
  • Use the above command in the actions workflow
  • Update template when updated dependencies.

Related Issue:

Versions:

  • Go Version: 1.21.3
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.2
  • NGT Version: 2.1.3

Checklist:

Special notes for your reviewer:

hlts2 added 3 commits October 18, 2023 14:23
@hlts2
feat: add command to update template
ce03dad 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2
fix: use make update/template in the workflow
efde597 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2
fix: refactor variable names
dec2dff 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 hlts2 requested review from a team, kmrmt and ykadowak and removed request for a team October 18, 2023 05:45
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@hlts2 hlts2 requested a review from kpango October 18, 2023 05:46
@hlts2
fix: call make update/template in update command
f273047 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 18, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7e7598f
Status: ✅  Deploy successful!
Preview URL: https://327033ff.vald.pages.dev
Branch Preview URL: https://feature-ci-add-update-pr-tem.vald.pages.dev

View logs

kpango
kpango reviewed Oct 18, 2023
View reviewed changes
Makefile.d/dependencies.mk Outdated Show resolved Hide resolved
@hlts2
fix: use make version command to get latest dependency version
8700c53 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 hlts2 requested a review from kpango October 18, 2023 08:40
@vankichi vankichi merged commit 8197ffe into main Oct 23, 2023
@vankichi vankichi deleted the feature/ci/add-update-pr-template-command branch October 23, 2023 05:44
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add make command to update template (#2212)"
235607f 
This reverts commit 8197ffe.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add make command to update template (#2212)"
cbe04de 
This reverts commit 8197ffe.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add make command to update template (#2212)"
33dafe3 
This reverts commit 8197ffe.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add make command to update template (#2212)"
549c426 
This reverts commit 8197ffe.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add make command to update template (#2212)"
e3c7628 
This reverts commit 8197ffe.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add make command to update template (#2212)"
a2496b4 
This reverts commit 8197ffe.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add make command to update template (#2212)"
6802aa4 
This reverts commit 8197ffe.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add make command to update template (#2212)"
2ac54b3 
This reverts commit 8197ffe.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add make command to update template (#2212)"
d96e32b 
This reverts commit 8197ffe.
@vankichi vankichi mentioned this pull request Dec 4, 2023
Merged
kmrmt pushed a commit that referenced this pull request Dec 12, 2023
@hlts2 @kmrmt
Add make command to update template (#2212)
030dda9 
* feat: add command to update template

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: use make update/template in the workflow

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: refactor variable names

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: call make update/template in update command

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: use make version command to get latest dependency version

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

---------

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykadowak ykadowak ykadowak approved these changes

@kmrmt kmrmt kmrmt approved these changes

@kpango kpango Awaiting requested review from kpango

Assignees
No one assigned
Labels
area/makefile priority/medium size/S team/sre SRE team type/ci type/feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hlts2 @vdaas-ci @kmrmt @kpango @ykadowak @vankichi