Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable BUILDKIT_INLINE_CACHE on GitHub Actions #2270

Merged
merged 2 commits into from
Dec 12, 2023
Merged

disable BUILDKIT_INLINE_CACHE on GitHub Actions #2270

merged 2 commits into from
Dec 12, 2023

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Dec 12, 2023

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.21.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.4
  • NGT Version: 2.1.5

Checklist:

Special notes for your reviewer:

@kpango
disable BUILDKIT_INLINE_CACHE on GitHub Actions
d8022d2 
Signed-off-by: kpango <kpango@vdaas.org>
hlts2
hlts2 previously approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@github-actions github-actions bot added size/S type/bug Something isn't working labels Dec 12, 2023
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

vankichi
vankichi previously approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I will merge this PR after All CI passes.

@kpango kpango dismissed stale reviews from vankichi and hlts2 via b7384e2 December 12, 2023 07:18
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 12, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9f903c1
Status: ✅  Deploy successful!
Preview URL: https://ee02c026.vald.pages.dev
Branch Preview URL: https://bugfix-actions-docker-inline.vald.pages.dev

View logs

@github-actions github-actions bot added size/L and removed size/S labels Dec 12, 2023
@kpango kpango force-pushed the bugfix/actions/docker-inline-cache branch from b7384e2 to f259597 Compare December 12, 2023 07:24
@kpango
add deps update and gen-crd schema
9f903c1 
Signed-off-by: kpango <kpango@vdaas.org>
@kpango kpango force-pushed the bugfix/actions/docker-inline-cache branch from f259597 to 9f903c1 Compare December 12, 2023 07:24
@kpango kpango requested review from hlts2 and vankichi December 12, 2023 07:43
hlts2
hlts2 approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@vankichi vankichi merged commit c70ae6c into main Dec 12, 2023
105 checks passed
@vankichi vankichi deleted the bugfix/actions/docker-inline-cache branch December 12, 2023 08:00
@vankichi vankichi mentioned this pull request Dec 19, 2023
Merged
This was referenced Jan 28, 2024
Open
Open
Open
Open
Closed
@github-actions github-actions bot mentioned this pull request Jan 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlts2 hlts2 hlts2 approved these changes

@vankichi vankichi vankichi approved these changes

Assignees
No one assigned
Labels
area/makefile priority/medium size/L team/sre SRE team type/bug Something isn't working type/ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kpango @vdaas-ci @vankichi @hlts2