-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change symlink API documents #2741
Conversation
📝 Walkthrough📝 Walkthrough## Walkthrough
This pull request introduces comprehensive documentation for several Vald APIs, including Flush, Insert, Object, Remove, Search, Update, and Upsert services. Each service features multiple RPC methods with specified input and output message structures, detailing their functionalities, status codes, and troubleshooting guidance. The documentation enhances the understanding of how to interact with these APIs, providing clear definitions for requests and responses.
## Changes
| File Path | Change Summary |
|-------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| `apis/docs/v1/flush.md` | - New service `Flush` added.<br>- New RPC method `Flush` defined.<br>- New message structures `Flush.Request` and `Info.Index.Count` created. |
| `apis/docs/v1/insert.md` | - New service `Insert` added.<br>- RPC methods `Insert`, `StreamInsert`, and `MultiInsert` defined.<br>- New message structures for requests and responses created. |
| `apis/docs/v1/object.md` | - New service `Object` added.<br>- RPC methods `Exists`, `GetObject`, `StreamGetObject`, `StreamListObject`, and `GetTimestamp` defined.<br>- New message structures for requests and responses created. |
| `apis/docs/v1/remove.md` | - New service `Remove` added.<br>- RPC methods `Remove`, `RemoveByTimestamp`, `StreamRemove`, and `MultiRemove` defined.<br>- New message structures for requests and responses created. |
| `apis/docs/v1/search.md` | - New service `Search` added.<br>- Multiple RPC methods defined, including `Search`, `SearchByID`, `StreamSearch`, and others.<br>- New message structures for requests and responses created. |
| `apis/docs/v1/update.md` | - New service `Update` added.<br>- RPC methods `Update`, `StreamUpdate`, `MultiUpdate`, and `UpdateTimestamp` defined.<br>- New message structures for requests and responses created. |
| `apis/docs/v1/upsert.md` | - New service `Upsert` added.<br>- RPC methods `Upsert`, `StreamUpsert`, and `MultiUpsert` defined.<br>- New message structures for requests and responses created. |
| `Makefile` | - New variables added for managing protobuf files and documentation generation.<br>- Enhanced handling of API documentation within the build process. |
| `Makefile.d/functions.mk` | - New function `gen-api-document` added to automate API documentation generation. |
| `Makefile.d/proto.mk` | - Modifications to enhance protobuf generation and manage dependencies.<br>- New targets for generating API documentation. |
| `apis/docs/buf.gen.doc.yaml` | - New YAML configuration file created for managing API documentation generation using the Buf tool. |
| `apis/docs/buf.gen.payload.yaml` | - New YAML configuration file created for managing protocol buffer generation settings. |
| `apis/docs/buf.gen.tmpl.yaml` | - New YAML configuration file created for managing protocol buffer generation settings with templates. |
| `apis/docs/v1/filter.md` | - New service `Filter` added with multiple RPC methods for object operations documented. |
| `apis/docs/v1/index.md` | - New service `Index` added with RPC methods for index management documented. |
| `apis/docs/v1/mirror.md` | - New service `Mirror` added with the `Register` RPC method documented. |
| `apis/docs/v1/payload.md.tmpl` | - New template introduced for generating API documentation based on message definitions. |
| `apis/proto/v1/mirror/mirror.proto` | - Documentation for the `Mirror` service and `Register` RPC method enhanced. |
| `apis/proto/v1/vald/filter.proto` | - Documentation for the `Filter` service methods enhanced. |
| `apis/proto/v1/vald/flush.proto` | - Documentation for the `Flush` service enhanced. |
| `apis/proto/v1/vald/index.proto` | - New RPC methods added for index management with improved documentation. |
| `apis/proto/v1/vald/insert.proto` | - Documentation for the `Insert` service methods enhanced. |
| `apis/proto/v1/vald/object.proto` | - Documentation for the `Object` service methods enhanced. |
| `apis/proto/v1/vald/remove.proto` | - Documentation for the `Remove` service methods enhanced. |
| `apis/proto/v1/vald/search.proto` | - Documentation for the `Search` service methods enhanced. |
| `apis/proto/v1/vald/update.proto` | - Documentation for the `Update` service methods enhanced. |
| `apis/proto/v1/vald/upsert.proto` | - Documentation for the `Upsert` service methods enhanced. |
## Possibly related PRs
- **#2665**: This PR focuses on fixing gRPC error handling, which may relate to the error handling aspects of the Flush RPC method introduced in the main PR.
- **#2681**: Similar to #2665, this PR backports changes related to gRPC error handling, which could impact the robustness of the Flush RPC method's error responses.
- **#2691**: This PR involves migrating to Buf v2, which is relevant as the main PR introduces new RPC methods and message structures that may require updated documentation and generation processes.
- **#2695**: This backport of the Buf migration PR is relevant for the same reasons as #2691, ensuring that the new Flush RPC method is properly documented and generated.
- **#2724**: This PR updates the README, which may include references to the new Flush API documentation introduced in the main PR.
- **#2725**: This backport of the README update is relevant for ensuring that the documentation for the new Flush API is consistent across versions.
## Suggested labels
`size/S`, `actions/backport/release/v1.7`
## Suggested reviewers
- kpango
- hlts2 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
[CHATOPS:HELP] ChatOps commands.
|
Deploying vald with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
LanguageTool
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 354 in 2f26634
Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 355 in 2f26634
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 436 in 2f26634
Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 490 in 2f26634
Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 491 in 2f26634
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 579 in 2f26634
Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 725 in 2f26634
Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 861 in 2f26634
Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 979 in 2f26634
Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1097 in 2f26634
Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1147 in 2f26634
Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1148 in 2f26634
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1229 in 2f26634
Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1279 in 2f26634
Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1280 in 2f26634
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1368 in 2f26634
Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1510 in 2f26634
Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 28 in 2f26634
Object.Vector vector = 1 [ (validate.rules).repeated .min_items = 2 ]; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 29 in 2f26634
Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
An article may be missing. (BUNCH_OF[6])
Suggestions: a pair of
Rule: https://community.languagetool.org/rule/show/BUNCH_OF?lang=en-US&subId=6
Category: GRAMMAR
Line 119 in 2f26634
| ALREADY_EXISTS | Request pair of ID and vector is already inserted. | Change request ID. | |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 136 in 2f26634
Object.Vector vector = 1 [ (validate.rules).repeated .min_items = 2 ]; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 137 in 2f26634
Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 185 in 2f26634
Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 186 in 2f26634
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
An article may be missing. (BUNCH_OF[6])
Suggestions: a pair of
Rule: https://community.languagetool.org/rule/show/BUNCH_OF?lang=en-US&subId=6
Category: GRAMMAR
Line 248 in 2f26634
| ALREADY_EXISTS | Request pair of ID and vector is already inserted. | Change request ID. | |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 269 in 2f26634
Object.Vector vector = 1 [ (validate.rules).repeated .min_items = 2 ]; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 270 in 2f26634
Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_BEGINNING_RULE?lang=en-US
Category: REPETITIONS_STYLE
Line 337 in 2f26634
| location | Object.Location | repeated(Array[Object.Location]) | The list of `Object.Location`. | |
[LanguageTool] reported by reviewdog 🐶
An article may be missing. (BUNCH_OF[6])
Suggestions: a pair of
Rule: https://community.languagetool.org/rule/show/BUNCH_OF?lang=en-US&subId=6
Category: GRAMMAR
Line 374 in 2f26634
| ALREADY_EXISTS | Request pair of ID and vector is already inserted. | Change request ID. | |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 32 in 2f26634
Object.Vector vector = 1 [ (validate.rules).repeated .min_items = 2 ]; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 33 in 2f26634
Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Specify a number, remove phrase, or simply use “many” or “numerous” (LARGE_NUMBER_OF[1])
Suggestions: many
, numerous
URL: https://languagetool.org/insights/post/wordiness/
Rule: https://community.languagetool.org/rule/show/LARGE_NUMBER_OF?lang=en-US&subId=1
Category: REDUNDANCY
Line 129 in 2f26634
It’s the recommended method to upsert a large number of vectors. |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 138 in 2f26634
Object.Vector vector = 1 [ (validate.rules).repeated .min_items = 2 ]; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 139 in 2f26634
Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 187 in 2f26634
Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 188 in 2f26634
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 269 in 2f26634
Object.Vector vector = 1 [ (validate.rules).repeated .min_items = 2 ]; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 270 in 2f26634
Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_BEGINNING_RULE?lang=en-US
Category: REPETITIONS_STYLE
Line 337 in 2f26634
| location | Object.Location | repeated(Array[Object.Location]) | The list of `Object.Location`. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 8
🧹 Outside diff range and nitpick comments (23)
apis/docs/v1/object.md (2)
3-6
: Enhance service overview with more contextConsider expanding the overview section to include:
- The service's role in the Vald ecosystem
- Common use cases for each RPC method
- Relationship with other services (Insert, Search, etc.)
1-259
: Add usage examples for each RPC methodTo improve developer experience, consider adding:
- Example requests and responses for each RPC method
- Code snippets in multiple languages (Go, Python, etc.)
- Common usage patterns and best practices
apis/docs/v1/insert.md (4)
19-19
: Fix typo in RPC description"Inset" should be "Insert"
-Inset RPC is the method to add a new single vector. +Insert RPC is the method to add a new single vector.
17-118
: Consider adding example request/responseThe documentation is comprehensive, but adding example request and response payloads would make it more user-friendly and easier to understand.
Consider adding examples like:
### Example Request: ```json { "vector": { "id": "vector1", "vector": [0.1, 0.2, 0.3] }, "config": { "skip_strict_exist_check": false, "timestamp": 1634000000 } }Response:
{ "name": "agent-1", "uuid": "vector1", "ips": ["10.0.0.1", "10.0.0.2"] }--- `124-124`: **Improve phrasing for clarity** Consider rephrasing to be more specific or concise. ```diff -It's the recommended method to insert a large number of vectors. +It's the recommended method to insert many vectors.
🧰 Tools
🪛 LanguageTool
[style] ~124-~124: Specify a number, remove phrase, or simply use “many” or “numerous”
Context: .... It's the recommended method to insert a large number of vectors. ### Input - the scheme of `p...(LARGE_NUMBER_OF)
249-252
: Consider specifying the gRPC message size limitThe warning about gRPC message size limitation would be more helpful if it included the actual size limit.
<div class="notice"> gRPC has a message size limitation.<br> -Please be careful that the size of the request exceeds the limit. +The default maximum message size in gRPC is 4MB. Please ensure your request size does not exceed this limit, or configure a custom limit if needed. </div>apis/docs/v1/upsert.md (5)
21-123
: Consider adding usage examples.While the documentation is comprehensive, adding practical examples would help developers understand how to use the Upsert RPC effectively. Consider including:
- A basic example of upserting a single vector
- An example showing how to use the
skip_strict_exist_check
option- An example demonstrating the use of filters
129-129
: Improve clarity in the recommendation.Replace "large number of vectors" with a more specific or clearer phrase.
-It's the recommended method to upsert a large number of vectors. +It's the recommended method when upserting numerous vectors (typically thousands or more).🧰 Tools
🪛 LanguageTool
[style] ~129-~129: Specify a number, remove phrase, or simply use “many” or “numerous”
Context: .... It’s the recommended method to upsert a large number of vectors. ### Input - the scheme of `p...(LARGE_NUMBER_OF)
124-250
: Consider reducing documentation redundancy.The status codes and troubleshooting sections are identical across all RPC methods. Consider:
- Moving these common sections to a shared location
- Referencing them from each RPC method's documentation
- Only documenting method-specific status codes or troubleshooting steps in the individual sections
This would make the documentation more maintainable and reduce the risk of inconsistencies.
🧰 Tools
🪛 LanguageTool
[style] ~129-~129: Specify a number, remove phrase, or simply use “many” or “numerous”
Context: .... It’s the recommended method to upsert a large number of vectors. ### Input - the scheme of `p...(LARGE_NUMBER_OF)
255-258
: Enhance the gRPC size limitation notice.The current notice about gRPC message size limitation could be more helpful by including specific details.
<div class="notice"> -gRPC has a message size limitation.<br> -Please be careful that the size of the request exceeds the limit. +gRPC has a default message size limitation of 4MB.<br> +Please ensure your request size doesn't exceed this limit, or configure your gRPC client/server with appropriate maximum message size settings. </div>
337-337
: Improve table description readability.Rephrase to avoid repetitive sentence beginnings.
-The list of `Object.Location`. +Contains a collection of `Object.Location` objects.🧰 Tools
🪛 LanguageTool
[style] ~337-~337: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...d(Array[Object.Location]) | The list ofObject.Location
. | - Object.Location | field |...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
apis/docs/v1/update.md (5)
3-6
: Enhance the Overview section with more context.Consider expanding the overview to include:
- Key differences between Update, StreamUpdate, and MultiUpdate methods
- When to use each method
- Any prerequisites or important considerations
113-120
: Fix grammar in the troubleshooting table.Add articles where missing:
- "Request pair" → "A request pair"
🧰 Tools
🪛 LanguageTool
[grammar] ~119-~119: An article may be missing.
Context: ... | | ALREADY_EXISTS | Request pair of ID and vector is already inserted. ...(BUNCH_OF)
124-127
: Fix wording in StreamUpdate description.Replace "amount of vectors" with "number of vectors" as it's more appropriate when referring to countable items.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~127-~127: ‘Amount of’ should usually only be used with uncountable or mass nouns. Consider using “number” if this is not the case.
Context: ... recommended method to update the large amount of vectors. ### Input - the scheme of...(AMOUNTOF_TO_NUMBEROF)
236-249
: Consider consolidating duplicate troubleshooting sections.The troubleshooting sections are identical across all three RPCs. Consider moving this to a common section and referencing it to reduce duplication and maintenance overhead.
🧰 Tools
🪛 LanguageTool
[grammar] ~248-~248: An article may be missing.
Context: ... | | ALREADY_EXISTS | Request pair of ID and vector is already inserted. ...(BUNCH_OF)
255-258
: Enhance the gRPC size limitation notice.Consider adding:
- The actual size limitation (typically 4MB by default)
- How to configure custom message size limits
- Best practices for handling large updates
apis/docs/v1/remove.md (5)
3-6
: Enhance the overview section with method selection guidance.Consider adding a brief comparison of when to use each RPC method. For example:
- Remove: For single vector removal
- RemoveByTimestamp: For time-based batch removal
- StreamRemove: For high-throughput streaming removal
- MultiRemove: For batch removal with size constraints
22-119
: Add example request/response for better clarity.Consider adding a practical example showing:
- A sample Remove request with actual values
- The corresponding successful response
- A failed request scenario with error details
179-183
: Add examples for timestamp range conditions.The notice about AND conditions would be clearer with examples. Consider adding:
- Single timestamp condition example
- Multiple timestamp conditions example showing range deletion
- Complex timestamp conditions example
242-246
: Add performance guidance for streaming operations.Consider enhancing the documentation with:
- Recommended batch sizes for optimal performance
- Error handling strategies in streaming scenarios
- Connection management best practices
🧰 Tools
🪛 LanguageTool
[style] ~245-~245: Specify a number, remove phrase, or simply use “many” or “numerous”
Context: .... It's the recommended method to remove a large number of vectors. ### Input - the scheme of `p...(LARGE_NUMBER_OF)
205-205
: Improve language variety and specificity.Consider these language improvements:
- Vary sentence beginnings in the Object.Location sections
- Replace "large number" with a specific recommended range
Also applies to: 245-245, 446-446
🧰 Tools
🪛 LanguageTool
[style] ~205-~205: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...d(Array[Object.Location]) | The list ofObject.Location
. | - Object.Location | field |...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
apis/docs/v1/search.md (2)
1-43
: LGTM! Consider adding version compatibility information.The overview and service definition are well-structured. Consider adding a section about version compatibility and any breaking changes from previous versions to help users with upgrades.
1-1628
: Overall excellent API documentation with room for optimization.The documentation is comprehensive and well-structured, providing clear information about each RPC method. The consistent format and detailed explanations will help users understand and implement the APIs effectively.
A few architectural suggestions for improving the documentation:
- Consider using OpenAPI/Swagger for API documentation to enable automatic generation and testing
- Add code examples for each RPC method to demonstrate usage
- Include performance considerations and best practices for each method
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (7)
apis/docs/v1/flush.md
(1 hunks)apis/docs/v1/insert.md
(1 hunks)apis/docs/v1/object.md
(1 hunks)apis/docs/v1/remove.md
(1 hunks)apis/docs/v1/search.md
(1 hunks)apis/docs/v1/update.md
(1 hunks)apis/docs/v1/upsert.md
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- apis/docs/v1/flush.md
🧰 Additional context used
🪛 LanguageTool
apis/docs/v1/insert.md
[style] ~124-~124: Specify a number, remove phrase, or simply use “many” or “numerous”
Context: .... It's the recommended method to insert a large number of vectors. ### Input - the scheme of `p...
(LARGE_NUMBER_OF)
[style] ~330-~330: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...d(Array[Object.Location]) | The list of Object.Location
. | - Object.Location | field |...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
apis/docs/v1/remove.md
[style] ~205-~205: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...d(Array[Object.Location]) | The list of Object.Location
. | - Object.Location | field |...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~245-~245: Specify a number, remove phrase, or simply use “many” or “numerous”
Context: .... It's the recommended method to remove a large number of vectors. ### Input - the scheme of `p...
(LARGE_NUMBER_OF)
[style] ~446-~446: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...d(Array[Object.Location]) | The list of Object.Location
. | - Object.Location | field |...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
apis/docs/v1/update.md
[grammar] ~119-~119: An article may be missing.
Context: ... | | ALREADY_EXISTS | Request pair of ID and vector is already inserted. ...
(BUNCH_OF)
[uncategorized] ~127-~127: ‘Amount of’ should usually only be used with uncountable or mass nouns. Consider using “number” if this is not the case.
Context: ... recommended method to update the large amount of vectors. ### Input - the scheme of...
(AMOUNTOF_TO_NUMBEROF)
[grammar] ~248-~248: An article may be missing.
Context: ... | | ALREADY_EXISTS | Request pair of ID and vector is already inserted. ...
(BUNCH_OF)
[style] ~337-~337: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...d(Array[Object.Location]) | The list of Object.Location
. | - Object.Location | field |...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[grammar] ~374-~374: An article may be missing.
Context: ... | | ALREADY_EXISTS | Request pair of ID and vector is already inserted. ...
(BUNCH_OF)
apis/docs/v1/upsert.md
[style] ~129-~129: Specify a number, remove phrase, or simply use “many” or “numerous”
Context: .... It’s the recommended method to upsert a large number of vectors. ### Input - the scheme of `p...
(LARGE_NUMBER_OF)
[style] ~337-~337: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...d(Array[Object.Location]) | The list of Object.Location
. | - Object.Location | field |...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
🔇 Additional comments (2)
apis/docs/v1/insert.md (1)
1-366
: Documentation is comprehensive and well-structured
The API documentation provides thorough coverage of all RPC methods, including clear schemas, validation rules, status codes, and troubleshooting guidance. The suggested improvements are minor and the documentation is ready for use.
🧰 Tools
🪛 LanguageTool
[style] ~124-~124: Specify a number, remove phrase, or simply use “many” or “numerous”
Context: .... It's the recommended method to insert a large number of vectors. ### Input - the scheme of `p...
(LARGE_NUMBER_OF)
[style] ~330-~330: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...d(Array[Object.Location]) | The list of Object.Location
. | - Object.Location | field |...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
apis/docs/v1/upsert.md (1)
1-19
: LGTM! Clear and well-structured service definition.
The overview effectively explains the purpose of the Upsert Service, and the service definition clearly outlines the three available RPC methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
LanguageTool
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 28 in e3cc4ce
Insert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Specify a number, remove phrase, or simply use “many” or “numerous” (LARGE_NUMBER_OF[1])
Suggestions: many
, numerous
URL: https://languagetool.org/insights/post/wordiness/
Rule: https://community.languagetool.org/rule/show/LARGE_NUMBER_OF?lang=en-US&subId=1
Category: REDUNDANCY
Line 143 in e3cc4ce
It's the recommended method to insert a large number of vectors. |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 151 in e3cc4ce
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 152 in e3cc4ce
Insert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 220 in e3cc4ce
Object.Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 221 in e3cc4ce
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 294 in e3cc4ce
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 295 in e3cc4ce
Insert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 15 in e3cc4ce
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 94 in e3cc4ce
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 199 in e3cc4ce
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 250 in e3cc4ce
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 251 in e3cc4ce
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 329 in e3cc4ce
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 330 in e3cc4ce
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 379 in e3cc4ce
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 14 in e3cc4ce
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 28 in e3cc4ce
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 29 in e3cc4ce
Remove.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Operator
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 133 in e3cc4ce
Remove.Timestamp.Operator operator = 2; |
[LanguageTool] reported by reviewdog 🐶
Specify a number, remove phrase, or simply use “many” or “numerous” (LARGE_NUMBER_OF[1])
Suggestions: many
, numerous
URL: https://languagetool.org/insights/post/wordiness/
Rule: https://community.languagetool.org/rule/show/LARGE_NUMBER_OF?lang=en-US&subId=1
Category: REDUNDANCY
Line 225 in e3cc4ce
It's the recommended method to remove a large number of vectors. |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 233 in e3cc4ce
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 234 in e3cc4ce
Remove.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 274 in e3cc4ce
Object.Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 275 in e3cc4ce
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 348 in e3cc4ce
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 349 in e3cc4ce
Remove.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 22 in e3cc4ce
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 37 in e3cc4ce
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 180 in e3cc4ce
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 324 in e3cc4ce
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 402 in e3cc4ce
Search.Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 403 in e3cc4ce
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 480 in e3cc4ce
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 558 in e3cc4ce
Search.Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 559 in e3cc4ce
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 643 in e3cc4ce
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 810 in e3cc4ce
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 968 in e3cc4ce
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1112 in e3cc4ce
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1256 in e3cc4ce
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1334 in e3cc4ce
Search.Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1335 in e3cc4ce
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1412 in e3cc4ce
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1490 in e3cc4ce
Search.Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1491 in e3cc4ce
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1575 in e3cc4ce
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1743 in e3cc4ce
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 14 in e3cc4ce
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 28 in e3cc4ce
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 29 in e3cc4ce
Update.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
An article may be missing. (BUNCH_OF[6])
Suggestions: a pair of
Rule: https://community.languagetool.org/rule/show/BUNCH_OF?lang=en-US&subId=6
Category: GRAMMAR
Line 143 in e3cc4ce
| ALREADY_EXISTS | Request pair of ID and vector is already inserted. | Change request ID. | |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 159 in e3cc4ce
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 160 in e3cc4ce
Update.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 232 in e3cc4ce
Object.Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 233 in e3cc4ce
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
An article may be missing. (BUNCH_OF[6])
Suggestions: a pair of
Rule: https://community.languagetool.org/rule/show/BUNCH_OF?lang=en-US&subId=6
Category: GRAMMAR
Line 286 in e3cc4ce
| ALREADY_EXISTS | Request pair of ID and vector is already inserted. | Change request ID. | |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 308 in e3cc4ce
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 309 in e3cc4ce
Update.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
An article may be missing. (BUNCH_OF[6])
Suggestions: a pair of
Rule: https://community.languagetool.org/rule/show/BUNCH_OF?lang=en-US&subId=6
Category: GRAMMAR
Line 439 in e3cc4ce
| ALREADY_EXISTS | Request pair of ID and vector is already inserted. | Change request ID. | |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 13 in e3cc4ce
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 27 in e3cc4ce
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 28 in e3cc4ce
Upsert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Specify a number, remove phrase, or simply use “many” or “numerous” (LARGE_NUMBER_OF[1])
Suggestions: many
, numerous
URL: https://languagetool.org/insights/post/wordiness/
Rule: https://community.languagetool.org/rule/show/LARGE_NUMBER_OF?lang=en-US&subId=1
Category: REDUNDANCY
Line 149 in e3cc4ce
It’s the recommended method to upsert a large number of vectors. |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 157 in e3cc4ce
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 158 in e3cc4ce
Upsert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 230 in e3cc4ce
Object.Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 231 in e3cc4ce
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 305 in e3cc4ce
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 306 in e3cc4ce
Upsert.Config config = 2; |
* init auto generatation for API documents * auto-generated API documents * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in 7a36dd8 according to the output from Gofumpt and Prettier. Details: #2742 * update * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in 74dc4d6 according to the output from Gofumpt and Prettier. Details: #2742 * update * update * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in 384fc7e according to the output from Gofumpt and Prettier. Details: #2742 * update * fix * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in fa4ba75 according to the output from Gofumpt and Prettier. Details: #2742 --------- Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
e3cc4ce
to
7d7a044
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
LanguageTool
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 28 in 7d7a044
Insert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Specify a number, remove phrase, or simply use “many” or “numerous” (LARGE_NUMBER_OF[1])
Suggestions: many
, numerous
URL: https://languagetool.org/insights/post/wordiness/
Rule: https://community.languagetool.org/rule/show/LARGE_NUMBER_OF?lang=en-US&subId=1
Category: REDUNDANCY
Line 143 in 7d7a044
It's the recommended method to insert a large number of vectors. |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 151 in 7d7a044
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 152 in 7d7a044
Insert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 220 in 7d7a044
Object.Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 221 in 7d7a044
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 294 in 7d7a044
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 295 in 7d7a044
Insert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 15 in 7d7a044
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 94 in 7d7a044
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 199 in 7d7a044
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 250 in 7d7a044
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 251 in 7d7a044
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 329 in 7d7a044
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 330 in 7d7a044
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 379 in 7d7a044
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 14 in 7d7a044
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 28 in 7d7a044
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 29 in 7d7a044
Remove.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Operator
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 133 in 7d7a044
Remove.Timestamp.Operator operator = 2; |
[LanguageTool] reported by reviewdog 🐶
Specify a number, remove phrase, or simply use “many” or “numerous” (LARGE_NUMBER_OF[1])
Suggestions: many
, numerous
URL: https://languagetool.org/insights/post/wordiness/
Rule: https://community.languagetool.org/rule/show/LARGE_NUMBER_OF?lang=en-US&subId=1
Category: REDUNDANCY
Line 225 in 7d7a044
It's the recommended method to remove a large number of vectors. |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 233 in 7d7a044
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 234 in 7d7a044
Remove.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 274 in 7d7a044
Object.Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 275 in 7d7a044
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 348 in 7d7a044
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 349 in 7d7a044
Remove.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 22 in 7d7a044
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 37 in 7d7a044
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 180 in 7d7a044
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 324 in 7d7a044
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 402 in 7d7a044
Search.Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 403 in 7d7a044
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 480 in 7d7a044
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 558 in 7d7a044
Search.Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 559 in 7d7a044
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 643 in 7d7a044
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 810 in 7d7a044
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 968 in 7d7a044
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1112 in 7d7a044
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1256 in 7d7a044
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1334 in 7d7a044
Search.Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1335 in 7d7a044
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1412 in 7d7a044
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1490 in 7d7a044
Search.Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1491 in 7d7a044
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1575 in 7d7a044
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1743 in 7d7a044
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 14 in 7d7a044
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 28 in 7d7a044
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 29 in 7d7a044
Update.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
An article may be missing. (BUNCH_OF[6])
Suggestions: a pair of
Rule: https://community.languagetool.org/rule/show/BUNCH_OF?lang=en-US&subId=6
Category: GRAMMAR
Line 143 in 7d7a044
| ALREADY_EXISTS | Request pair of ID and vector is already inserted. | Change request ID. | |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 159 in 7d7a044
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 160 in 7d7a044
Update.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 232 in 7d7a044
Object.Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 233 in 7d7a044
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
An article may be missing. (BUNCH_OF[6])
Suggestions: a pair of
Rule: https://community.languagetool.org/rule/show/BUNCH_OF?lang=en-US&subId=6
Category: GRAMMAR
Line 286 in 7d7a044
| ALREADY_EXISTS | Request pair of ID and vector is already inserted. | Change request ID. | |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 308 in 7d7a044
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 309 in 7d7a044
Update.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
An article may be missing. (BUNCH_OF[6])
Suggestions: a pair of
Rule: https://community.languagetool.org/rule/show/BUNCH_OF?lang=en-US&subId=6
Category: GRAMMAR
Line 439 in 7d7a044
| ALREADY_EXISTS | Request pair of ID and vector is already inserted. | Change request ID. | |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 13 in 7d7a044
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 27 in 7d7a044
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 28 in 7d7a044
Upsert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Specify a number, remove phrase, or simply use “many” or “numerous” (LARGE_NUMBER_OF[1])
Suggestions: many
, numerous
URL: https://languagetool.org/insights/post/wordiness/
Rule: https://community.languagetool.org/rule/show/LARGE_NUMBER_OF?lang=en-US&subId=1
Category: REDUNDANCY
Line 149 in 7d7a044
It’s the recommended method to upsert a large number of vectors. |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 157 in 7d7a044
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 158 in 7d7a044
Upsert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 230 in 7d7a044
Object.Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 231 in 7d7a044
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 305 in 7d7a044
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 306 in 7d7a044
Upsert.Config config = 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
LanguageTool
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 28 in df4d79e
Insert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Specify a number, remove phrase, or simply use “many” or “numerous” (LARGE_NUMBER_OF[1])
Suggestions: many
, numerous
URL: https://languagetool.org/insights/post/wordiness/
Rule: https://community.languagetool.org/rule/show/LARGE_NUMBER_OF?lang=en-US&subId=1
Category: REDUNDANCY
Line 142 in df4d79e
It's the recommended method to insert a large number of vectors. |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 150 in df4d79e
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 151 in df4d79e
Insert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 218 in df4d79e
Object.Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 219 in df4d79e
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 292 in df4d79e
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 293 in df4d79e
Insert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 10 in df4d79e
rpc Register(payload.v1.Mirror.Targets) returns (payload.v1.Mirror.Targets) {} |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 15 in df4d79e
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 93 in df4d79e
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 197 in df4d79e
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 247 in df4d79e
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 248 in df4d79e
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 325 in df4d79e
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 326 in df4d79e
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 374 in df4d79e
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 14 in df4d79e
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 28 in df4d79e
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 29 in df4d79e
Remove.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Operator
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 132 in df4d79e
Remove.Timestamp.Operator operator = 2; |
[LanguageTool] reported by reviewdog 🐶
Specify a number, remove phrase, or simply use “many” or “numerous” (LARGE_NUMBER_OF[1])
Suggestions: many
, numerous
URL: https://languagetool.org/insights/post/wordiness/
Rule: https://community.languagetool.org/rule/show/LARGE_NUMBER_OF?lang=en-US&subId=1
Category: REDUNDANCY
Line 223 in df4d79e
It's the recommended method to remove a large number of vectors. |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 231 in df4d79e
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 232 in df4d79e
Remove.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 271 in df4d79e
Object.Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 272 in df4d79e
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 345 in df4d79e
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 346 in df4d79e
Remove.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 22 in df4d79e
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 37 in df4d79e
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 180 in df4d79e
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 324 in df4d79e
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 402 in df4d79e
Search.Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 403 in df4d79e
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 480 in df4d79e
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 558 in df4d79e
Search.Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 559 in df4d79e
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 643 in df4d79e
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 810 in df4d79e
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 968 in df4d79e
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1112 in df4d79e
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1256 in df4d79e
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1334 in df4d79e
Search.Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1335 in df4d79e
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1412 in df4d79e
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1490 in df4d79e
Search.Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1491 in df4d79e
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1575 in df4d79e
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1743 in df4d79e
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 14 in df4d79e
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 28 in df4d79e
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 29 in df4d79e
Update.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
An article may be missing. (BUNCH_OF[6])
Suggestions: a pair of
Rule: https://community.languagetool.org/rule/show/BUNCH_OF?lang=en-US&subId=6
Category: GRAMMAR
Line 142 in df4d79e
| ALREADY_EXISTS | Request pair of ID and vector is already inserted. | Change request ID. | |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 157 in df4d79e
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 158 in df4d79e
Update.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 228 in df4d79e
Object.Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 229 in df4d79e
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
An article may be missing. (BUNCH_OF[6])
Suggestions: a pair of
Rule: https://community.languagetool.org/rule/show/BUNCH_OF?lang=en-US&subId=6
Category: GRAMMAR
Line 283 in df4d79e
| ALREADY_EXISTS | Request pair of ID and vector is already inserted. | Change request ID. | |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 304 in df4d79e
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 305 in df4d79e
Update.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
An article may be missing. (BUNCH_OF[6])
Suggestions: a pair of
Rule: https://community.languagetool.org/rule/show/BUNCH_OF?lang=en-US&subId=6
Category: GRAMMAR
Line 434 in df4d79e
| ALREADY_EXISTS | Request pair of ID and vector is already inserted. | Change request ID. | |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 13 in df4d79e
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 27 in df4d79e
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 28 in df4d79e
Upsert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Specify a number, remove phrase, or simply use “many” or “numerous” (LARGE_NUMBER_OF[1])
Suggestions: many
, numerous
URL: https://languagetool.org/insights/post/wordiness/
Rule: https://community.languagetool.org/rule/show/LARGE_NUMBER_OF?lang=en-US&subId=1
Category: REDUNDANCY
Line 147 in df4d79e
It’s the recommended method to upsert a large number of vectors. |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 155 in df4d79e
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 156 in df4d79e
Upsert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 226 in df4d79e
Object.Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 227 in df4d79e
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 301 in df4d79e
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 302 in df4d79e
Upsert.Config config = 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
LanguageTool
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 28 in 32fb34c
Insert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Specify a number, remove phrase, or simply use “many” or “numerous” (LARGE_NUMBER_OF[1])
Suggestions: many
, numerous
URL: https://languagetool.org/insights/post/wordiness/
Rule: https://community.languagetool.org/rule/show/LARGE_NUMBER_OF?lang=en-US&subId=1
Category: REDUNDANCY
Line 143 in 32fb34c
It's the recommended method to insert a large number of vectors. |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 151 in 32fb34c
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 152 in 32fb34c
Insert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 220 in 32fb34c
Object.Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 221 in 32fb34c
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 294 in 32fb34c
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 295 in 32fb34c
Insert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 10 in 32fb34c
rpc Register(payload.v1.Mirror.Targets) returns (payload.v1.Mirror.Targets) {} |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 15 in 32fb34c
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 94 in 32fb34c
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 199 in 32fb34c
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 250 in 32fb34c
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 251 in 32fb34c
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 329 in 32fb34c
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 330 in 32fb34c
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 379 in 32fb34c
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 14 in 32fb34c
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 28 in 32fb34c
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 29 in 32fb34c
Remove.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Operator
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 133 in 32fb34c
Remove.Timestamp.Operator operator = 2; |
[LanguageTool] reported by reviewdog 🐶
Specify a number, remove phrase, or simply use “many” or “numerous” (LARGE_NUMBER_OF[1])
Suggestions: many
, numerous
URL: https://languagetool.org/insights/post/wordiness/
Rule: https://community.languagetool.org/rule/show/LARGE_NUMBER_OF?lang=en-US&subId=1
Category: REDUNDANCY
Line 225 in 32fb34c
It's the recommended method to remove a large number of vectors. |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 233 in 32fb34c
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 234 in 32fb34c
Remove.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 274 in 32fb34c
Object.Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 275 in 32fb34c
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 348 in 32fb34c
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 349 in 32fb34c
Remove.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 22 in 32fb34c
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 37 in 32fb34c
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 180 in 32fb34c
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 324 in 32fb34c
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 402 in 32fb34c
Search.Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 403 in 32fb34c
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 480 in 32fb34c
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 558 in 32fb34c
Search.Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 559 in 32fb34c
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 643 in 32fb34c
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 810 in 32fb34c
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 968 in 32fb34c
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1112 in 32fb34c
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1256 in 32fb34c
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1334 in 32fb34c
Search.Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1335 in 32fb34c
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1412 in 32fb34c
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1490 in 32fb34c
Search.Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1491 in 32fb34c
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1575 in 32fb34c
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1743 in 32fb34c
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 14 in 32fb34c
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 28 in 32fb34c
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 29 in 32fb34c
Update.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
An article may be missing. (BUNCH_OF[6])
Suggestions: a pair of
Rule: https://community.languagetool.org/rule/show/BUNCH_OF?lang=en-US&subId=6
Category: GRAMMAR
Line 143 in 32fb34c
| ALREADY_EXISTS | Request pair of ID and vector is already inserted. | Change request ID. | |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 159 in 32fb34c
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 160 in 32fb34c
Update.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 232 in 32fb34c
Object.Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 233 in 32fb34c
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
An article may be missing. (BUNCH_OF[6])
Suggestions: a pair of
Rule: https://community.languagetool.org/rule/show/BUNCH_OF?lang=en-US&subId=6
Category: GRAMMAR
Line 286 in 32fb34c
| ALREADY_EXISTS | Request pair of ID and vector is already inserted. | Change request ID. | |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 308 in 32fb34c
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 309 in 32fb34c
Update.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
An article may be missing. (BUNCH_OF[6])
Suggestions: a pair of
Rule: https://community.languagetool.org/rule/show/BUNCH_OF?lang=en-US&subId=6
Category: GRAMMAR
Line 439 in 32fb34c
| ALREADY_EXISTS | Request pair of ID and vector is already inserted. | Change request ID. | |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 13 in 32fb34c
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 27 in 32fb34c
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 28 in 32fb34c
Upsert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Specify a number, remove phrase, or simply use “many” or “numerous” (LARGE_NUMBER_OF[1])
Suggestions: many
, numerous
URL: https://languagetool.org/insights/post/wordiness/
Rule: https://community.languagetool.org/rule/show/LARGE_NUMBER_OF?lang=en-US&subId=1
Category: REDUNDANCY
Line 149 in 32fb34c
It’s the recommended method to upsert a large number of vectors. |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 157 in 32fb34c
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 158 in 32fb34c
Upsert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 230 in 32fb34c
Object.Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 231 in 32fb34c
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 305 in 32fb34c
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 306 in 32fb34c
Upsert.Config config = 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 13
🧹 Outside diff range and nitpick comments (28)
apis/proto/v1/mirror/mirror.proto (1)
31-39
: Consider enhancing the status code table format.The documentation content is excellent, but the status code table readability could be improved.
Consider this format for better readability:
// Overview // Register RPC is the method to register other Vald Mirror Gateway targets. // --- // Status Code - // | 0 | OK | - // | 1 | CANCELLED | - // | 3 | INVALID_ARGUMENT | - // | 4 | DEADLINE_EXCEEDED | - // | 13 | INTERNAL | + // | Code | Status | + // |------|-------------------| + // | 0 | OK | + // | 1 | CANCELLED | + // | 3 | INVALID_ARGUMENT | + // | 4 | DEADLINE_EXCEEDED| + // | 13 | INTERNAL |apis/docs/v1/doc.tmpl (2)
9-20
: Enhance service documentation with additional metadataConsider enriching the service documentation with:
- Service version information
- Deprecation notices (if applicable)
- Required permissions or authentication details
# Vald {{ .Name }} APIs ## Overview +{{ if hasKey $descs "Version" }} +## Version + +{{ $descs.Version | trim }} +{{ end }} + +{{ if hasKey $descs "Authentication" }} +## Authentication + +{{ $descs.Authentication | trim }} +{{ end }}
22-64
: Consider adding example requests and responsesThe method documentation would be more helpful with:
- Example requests and responses in JSON/YAML format
- Rate limiting information
- Common use cases or scenarios
{{ printf "{{ template \"field:%s\" }}" .ResponseFullType }} +{{ if hasKey $descs "Examples" }} +### Examples + +{{ pluck "Examples" $descs | first | trim }} +{{ end }} + +{{ if hasKey $descs "Rate Limiting" }} +### Rate Limiting + +{{ pluck "Rate Limiting" $descs | first | trim }} +{{ end }}apis/docs/v1/payload.tmpl (2)
6-25
: Add inline comments for complex template logicThe logic within the
_bfs
andbfs
templates is quite complex. Adding inline comments to explain the purpose of key variables and the control flow would enhance readability and maintainability for future developers.
38-65
: Consider optimizing the dependency traversalThe current implementation of dependency traversal in the templates may have performance implications when processing a large number of messages. Investigate if it's possible to optimize the traversal or cache intermediate results to improve efficiency.
apis/proto/v1/vald/flush.proto (1)
32-41
: Correct formatting of status code tableThe status code table in the method documentation lacks proper markdown formatting, which may lead to rendering issues in documentation tools. Ensure the table is correctly formatted with headers and separators.
apis/docs/v1/flush.md (2)
5-5
: Add missing article for grammatical correctnessIn the sentence "Flush Service is responsible for removing...", consider adding "the" before "Flush Service" for grammatical accuracy:
"The Flush Service is responsible for removing all vectors..."
24-28
: Ensure consistency in code block languagesThe code block for the
Flush.Request
message uses therpc
language identifier, which may not be recognized. Useprotobuf
orproto
for better syntax highlighting in documentation tools.Makefile.d/proto.mk (1)
19-21
: Consider optimizing target dependenciesThe
proto/all
target could be more efficient by runningproto/gen/code
andproto/gen/api/docs
in parallel since they are independent operations.proto/all: \ proto/deps \ - proto/gen/code \ - proto/gen/api/docs + proto/gen/parallel + +.PHONY: proto/gen/parallel +proto/gen/parallel: + $(MAKE) -j2 proto/gen/code proto/gen/api/docsapis/proto/v1/vald/object.proto (2)
113-120
: Complete the TODO sections in documentationThe
StreamListObject
andGetTimestamp
methods have incomplete documentation with TODO placeholders for Status Code and Troubleshooting sections. These sections should be completed to maintain consistency with other methods.Would you like me to help generate the missing documentation sections based on the method implementations?
Also applies to: 125-132
31-31
: Consider following protobuf naming conventionsAs per the static analysis tool, the service name should follow the standard naming convention by adding a "Service" suffix.
-service Object { +service ObjectService {🧰 Tools
🪛 buf (1.47.2)
31-31: Service name "Object" should be suffixed with "Service".
(SERVICE_SUFFIX)
apis/proto/v1/vald/filter.proto (1)
73-76
: Standardize gRPC message size limitation noticesThe warning about gRPC message size limitations appears in different formats across multiple methods. Consider standardizing the notice across all methods.
Use this consistent format for all size limitation notices:
// <div class="notice"> - // gRPC has a message size limitation.<br> - // Please be careful that the size of the request exceeds the limit. + // Warning: gRPC has a message size limitation of 4MB by default.<br> + // Please ensure your request size does not exceed this limit or configure your client/server accordingly. // </div>Also applies to: 172-175, 224-227
apis/proto/v1/vald/insert.proto (1)
29-31
: Consider renaming service to follow naming convention.The service name should be suffixed with "Service" to follow protobuf naming conventions.
-service Insert { +service InsertService {🧰 Tools
🪛 buf (1.47.2)
31-31: Service name "Insert" should be suffixed with "Service".
(SERVICE_SUFFIX)
apis/proto/v1/vald/remove.proto (1)
63-89
: Add missing documentation for RemoveByTimestamp RPCThe documentation for RemoveByTimestamp RPC should include:
- Example usage with multiple timestamps
- Specific timestamp format requirements
- Performance implications when using multiple timestamps
Makefile.d/functions.mk (1)
467-473
: Enhance gen-api-document function robustnessThe function should include:
- Error handling for buf commands
- Documentation of function parameters
- Cleanup in case of intermediate failures
define gen-api-document - buf generate --template=apis/docs/buf.gen.tmpl.yaml --path $2 - cat apis/docs/v1/payload.md.tmpl apis/docs/v1/_doc.md.tmpl > apis/docs/v1/doc.md.tmpl; \ - buf generate --template=apis/docs/buf.gen.doc.yaml --path $2; \ - mv $(ROOTDIR)/apis/docs/v1/doc.md $1; \ - rm apis/docs/v1/*doc.md.tmpl + @echo "Generating API documentation for path: $2" + if ! buf generate --template=apis/docs/buf.gen.tmpl.yaml --path $2; then \ + echo "Error: Failed to generate initial documentation" >&2; \ + exit 1; \ + fi + if ! cat apis/docs/v1/payload.md.tmpl apis/docs/v1/_doc.md.tmpl > apis/docs/v1/doc.md.tmpl; then \ + echo "Error: Failed to concatenate template files" >&2; \ + rm -f apis/docs/v1/doc.md.tmpl; \ + exit 1; \ + fi + if ! buf generate --template=apis/docs/buf.gen.doc.yaml --path $2; then \ + echo "Error: Failed to generate final documentation" >&2; \ + rm -f apis/docs/v1/doc.md.tmpl; \ + exit 1; \ + fi + if ! mv $(ROOTDIR)/apis/docs/v1/doc.md $1; then \ + echo "Error: Failed to move documentation to target location" >&2; \ + rm -f apis/docs/v1/doc.md.tmpl; \ + exit 1; \ + fi + rm -f apis/docs/v1/*doc.md.tmplapis/docs/v1/remove.md (2)
19-19
: Fix typo in RPC description"Inset" should be "Insert"
-Inset RPC is the method to add a new single vector. +Insert RPC is the method to add a new single vector.
225-225
: Provide specific batch size recommendationsReplace the vague "large number" with specific recommendations for optimal batch sizes based on typical use cases.
-It's the recommended method to remove a large number of vectors. +It's the recommended method to remove vectors in bulk (recommended batch size: 1000-10000 vectors).🧰 Tools
🪛 LanguageTool
[style] ~225-~225: Specify a number, remove phrase, or simply use “many” or “numerous”
Context: .... It's the recommended method to remove a large number of vectors. ### Input - the scheme of `p...(LARGE_NUMBER_OF)
apis/docs/v1/index.md (1)
63-63
: Fix grammar in agent-related descriptionsThe word "agent" should be singular when used with "each".
-for each agents +for each agentApply this change to all four instances in the file.
Also applies to: 109-109, 231-231, 304-304
🧰 Tools
🪛 LanguageTool
[grammar] ~63-~63: The noun should probably be in the singular form.
Context: ...C to get the index information for each agents. ### Input - the scheme of `payload.v...(EVERY_EACH_SINGULAR)
apis/docs/v1/insert.md (1)
143-143
: Standardize batch size recommendations across documentationUse consistent and specific batch size recommendations across all streaming RPC documentation.
-It's the recommended method to insert a large number of vectors. +It's the recommended method to insert vectors in bulk (recommended batch size: 1000-10000 vectors).🧰 Tools
🪛 LanguageTool
[style] ~143-~143: Specify a number, remove phrase, or simply use “many” or “numerous”
Context: .... It's the recommended method to insert a large number of vectors. ### Input - the scheme of `p...(LARGE_NUMBER_OF)
apis/proto/v1/vald/search.proto (1)
29-31
: Follow gRPC service naming convention.According to the buf linter, the service name should be suffixed with "Service" to follow gRPC naming conventions.
- service Search { + service SearchService {🧰 Tools
🪛 buf (1.47.2)
31-31: Service name "Search" should be suffixed with "Service".
(SERVICE_SUFFIX)
apis/docs/v1/search.md (1)
1-6
: Enhance API documentation with examples and performance considerations.Consider adding:
- Code examples for common use cases
- Performance best practices and recommendations
- Benchmarks or performance characteristics for different search methods
apis/proto/v1/vald/upsert.proto (1)
99-102
: Add warning about gRPC message size limit.Consider adding a warning about gRPC message size limitations in the HTML notice div, similar to the one in MultiUpsert (lines 99-102), as this is also relevant for single vector operations.
apis/docs/v1/upsert.md (3)
397-399
: Add missing description for locations field.The description for the
locations
field in theObject.Locations
message is empty. Consider adding a description like "List of vector locations."
72-72
: Fix code block style inconsistencies.Use fenced code blocks consistently throughout the document instead of indented code blocks.
Apply this format:
- | field | type | label | description | - | :---: | :--- | :---- | :---------- | +```markdown +| field | type | label | description | +| :---: | :--- | :---- | :---------- | +```Also applies to: 202-202, 356-356
🧰 Tools
🪛 Markdownlint (0.35.0)
72-72: Expected: fenced; Actual: indented
Code block style(MD046, code-block-style)
149-149
: Improve clarity in phrasing.Consider revising "large number of" to be more specific or use "many"/"numerous" for better clarity.
Example: "It's the recommended method to upsert numerous vectors."
🧰 Tools
🪛 LanguageTool
[style] ~149-~149: Specify a number, remove phrase, or simply use “many” or “numerous”
Context: .... It’s the recommended method to upsert a large number of vectors. ### Input - the scheme of `p...(LARGE_NUMBER_OF)
apis/docs/v1/update.md (3)
151-151
: Fix grammar in StreamUpdate description.Replace "amount of" with "number of" for better grammar when referring to countable items.
-It's the recommended method to update the large amount of vectors. +It's the recommended method to update the large number of vectors.🧰 Tools
🪛 LanguageTool
[uncategorized] ~151-~151: ‘Amount of’ should usually only be used with uncountable or mass nouns. Consider using “number” if this is not the case.
Context: ... recommended method to update the large amount of vectors. ### Input - the scheme of...(AMOUNTOF_TO_NUMBEROF)
143-143
: Fix grammar in ALREADY_EXISTS error description.Add missing article "a" before "Request pair" in multiple error descriptions.
-Request pair of ID and vector is already inserted. +A request pair of ID and vector is already inserted.Also applies to: 286-286, 439-439
🧰 Tools
🪛 LanguageTool
[grammar] ~143-~143: An article may be missing.
Context: ... | | ALREADY_EXISTS | Request pair of ID and vector is already inserted. ...(BUNCH_OF)
73-73
: Fix markdown code block style.Use fenced code blocks instead of indented code blocks for consistent formatting.
The table formatting in these sections should use consistent indentation and fenced code blocks (```) instead of indented blocks.
Also applies to: 204-204, 359-359
🧰 Tools
🪛 Markdownlint (0.35.0)
73-73: Expected: fenced; Actual: indented
Code block style(MD046, code-block-style)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (29)
Makefile
(1 hunks)Makefile.d/functions.mk
(1 hunks)Makefile.d/proto.mk
(2 hunks)apis/docs/buf.gen.doc.yaml
(1 hunks)apis/docs/buf.gen.payload.yaml
(1 hunks)apis/docs/buf.gen.tmpl.yaml
(1 hunks)apis/docs/v1/doc.tmpl
(1 hunks)apis/docs/v1/filter.md
(1 hunks)apis/docs/v1/flush.md
(1 hunks)apis/docs/v1/index.md
(1 hunks)apis/docs/v1/insert.md
(1 hunks)apis/docs/v1/mirror.md
(1 hunks)apis/docs/v1/object.md
(1 hunks)apis/docs/v1/payload.md.tmpl
(1 hunks)apis/docs/v1/payload.tmpl
(1 hunks)apis/docs/v1/remove.md
(1 hunks)apis/docs/v1/search.md
(1 hunks)apis/docs/v1/update.md
(1 hunks)apis/docs/v1/upsert.md
(1 hunks)apis/proto/v1/mirror/mirror.proto
(1 hunks)apis/proto/v1/vald/filter.proto
(1 hunks)apis/proto/v1/vald/flush.proto
(1 hunks)apis/proto/v1/vald/index.proto
(1 hunks)apis/proto/v1/vald/insert.proto
(1 hunks)apis/proto/v1/vald/object.proto
(1 hunks)apis/proto/v1/vald/remove.proto
(1 hunks)apis/proto/v1/vald/search.proto
(1 hunks)apis/proto/v1/vald/update.proto
(1 hunks)apis/proto/v1/vald/upsert.proto
(1 hunks)
✅ Files skipped from review due to trivial changes (4)
- apis/docs/buf.gen.doc.yaml
- apis/docs/buf.gen.payload.yaml
- apis/docs/buf.gen.tmpl.yaml
- apis/docs/v1/mirror.md
🧰 Additional context used
🪛 buf (1.47.2)
apis/proto/v1/vald/flush.proto
31-31: Service name "Flush" should be suffixed with "Service".
(SERVICE_SUFFIX)
apis/proto/v1/mirror/mirror.proto
30-30: Service name "Mirror" should be suffixed with "Service".
(SERVICE_SUFFIX)
apis/proto/v1/vald/upsert.proto
31-31: Service name "Upsert" should be suffixed with "Service".
(SERVICE_SUFFIX)
57-62: "payload.v1.Upsert.Request" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
57-57: RPC request type "Request" should be named "UpsertRequest" or "UpsertUpsertRequest".
(RPC_REQUEST_STANDARD_NAME)
57-57: RPC response type "Location" should be named "UpsertResponse" or "UpsertUpsertResponse".
(RPC_RESPONSE_STANDARD_NAME)
92-92: "payload.v1.Upsert.Request" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
92-92: RPC request type "Request" should be named "StreamUpsertRequest" or "UpsertStreamUpsertRequest".
(RPC_REQUEST_STANDARD_NAME)
92-92: RPC response type "StreamLocation" should be named "StreamUpsertResponse" or "UpsertStreamUpsertResponse".
(RPC_RESPONSE_STANDARD_NAME)
apis/proto/v1/vald/object.proto
31-31: Service name "Object" should be suffixed with "Service".
(SERVICE_SUFFIX)
55-57: RPC "Exists" has the same type "payload.v1.Object.ID" for the request and response.
(RPC_REQUEST_RESPONSE_UNIQUE)
55-55: RPC request type "ID" should be named "ExistsRequest" or "ObjectExistsRequest".
(RPC_REQUEST_STANDARD_NAME)
55-55: RPC response type "ID" should be named "ExistsResponse" or "ObjectExistsResponse".
(RPC_RESPONSE_STANDARD_NAME)
82-84: "payload.v1.Object.VectorRequest" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
82-82: RPC request type "VectorRequest" should be named "GetObjectRequest" or "ObjectGetObjectRequest".
(RPC_REQUEST_STANDARD_NAME)
82-82: RPC response type "Vector" should be named "GetObjectResponse" or "ObjectGetObjectResponse".
(RPC_RESPONSE_STANDARD_NAME)
111-111: "payload.v1.Object.VectorRequest" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
111-111: RPC request type "VectorRequest" should be named "StreamGetObjectRequest" or "ObjectStreamGetObjectRequest".
(RPC_REQUEST_STANDARD_NAME)
111-111: RPC response type "StreamVector" should be named "StreamGetObjectResponse" or "ObjectStreamGetObjectResponse".
(RPC_RESPONSE_STANDARD_NAME)
121-121: RPC request type "Request" should be named "StreamListObjectRequest" or "ObjectStreamListObjectRequest".
(RPC_REQUEST_STANDARD_NAME)
121-121: RPC response type "Response" should be named "StreamListObjectResponse" or "ObjectStreamListObjectResponse".
(RPC_RESPONSE_STANDARD_NAME)
apis/proto/v1/vald/index.proto
31-31: Service name "Index" should be suffixed with "Service".
(SERVICE_SUFFIX)
34-36: "payload.v1.Empty" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
34-34: RPC request type "Empty" should be named "IndexInfoRequest" or "IndexIndexInfoRequest".
(RPC_REQUEST_STANDARD_NAME)
34-34: RPC response type "Count" should be named "IndexInfoResponse" or "IndexIndexInfoResponse".
(RPC_RESPONSE_STANDARD_NAME)
40-42: "payload.v1.Empty" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
40-40: RPC request type "Empty" should be named "IndexDetailRequest" or "IndexIndexDetailRequest".
(RPC_REQUEST_STANDARD_NAME)
40-40: RPC response type "Detail" should be named "IndexDetailResponse" or "IndexIndexDetailResponse".
(RPC_RESPONSE_STANDARD_NAME)
46-48: "payload.v1.Empty" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
46-46: RPC request type "Empty" should be named "IndexStatisticsRequest" or "IndexIndexStatisticsRequest".
(RPC_REQUEST_STANDARD_NAME)
46-46: RPC response type "Statistics" should be named "IndexStatisticsResponse" or "IndexIndexStatisticsResponse".
(RPC_RESPONSE_STANDARD_NAME)
52-54: "payload.v1.Empty" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
52-52: RPC request type "Empty" should be named "IndexStatisticsDetailRequest" or "IndexIndexStatisticsDetailRequest".
(RPC_REQUEST_STANDARD_NAME)
52-52: RPC response type "StatisticsDetail" should be named "IndexStatisticsDetailResponse" or "IndexIndexStatisticsDetailResponse".
(RPC_RESPONSE_STANDARD_NAME)
apis/proto/v1/vald/insert.proto
31-31: Service name "Insert" should be suffixed with "Service".
(SERVICE_SUFFIX)
55-60: "payload.v1.Insert.Request" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
55-55: RPC request type "Request" should be named "InsertRequest" or "InsertInsertRequest".
(RPC_REQUEST_STANDARD_NAME)
55-55: RPC response type "Location" should be named "InsertResponse" or "InsertInsertResponse".
(RPC_RESPONSE_STANDARD_NAME)
89-89: "payload.v1.Insert.Request" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
89-89: RPC request type "Request" should be named "StreamInsertRequest" or "InsertStreamInsertRequest".
(RPC_REQUEST_STANDARD_NAME)
89-89: RPC response type "StreamLocation" should be named "StreamInsertResponse" or "InsertStreamInsertResponse".
(RPC_RESPONSE_STANDARD_NAME)
apis/proto/v1/vald/update.proto
31-31: Service name "Update" should be suffixed with "Service".
(SERVICE_SUFFIX)
58-63: "payload.v1.Object.Location" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
58-63: "payload.v1.Update.Request" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
58-58: RPC request type "Request" should be named "UpdateRequest" or "UpdateUpdateRequest".
(RPC_REQUEST_STANDARD_NAME)
58-58: RPC response type "Location" should be named "UpdateResponse" or "UpdateUpdateResponse".
(RPC_RESPONSE_STANDARD_NAME)
94-94: "payload.v1.Update.Request" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
94-94: RPC request type "Request" should be named "StreamUpdateRequest" or "UpdateStreamUpdateRequest".
(RPC_REQUEST_STANDARD_NAME)
94-94: RPC response type "StreamLocation" should be named "StreamUpdateResponse" or "UpdateStreamUpdateResponse".
(RPC_RESPONSE_STANDARD_NAME)
127-127: RPC request type "MultiRequest" should be named "MultiUpdateRequest" or "UpdateMultiUpdateRequest".
(RPC_REQUEST_STANDARD_NAME)
127-127: RPC response type "Locations" should be named "MultiUpdateResponse" or "UpdateMultiUpdateResponse".
(RPC_RESPONSE_STANDARD_NAME)
apis/proto/v1/vald/remove.proto
31-31: Service name "Remove" should be suffixed with "Service".
(SERVICE_SUFFIX)
56-61: "payload.v1.Remove.Request" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
56-56: RPC request type "Request" should be named "RemoveRequest" or "RemoveRemoveRequest".
(RPC_REQUEST_STANDARD_NAME)
56-56: RPC response type "Location" should be named "RemoveResponse" or "RemoveRemoveResponse".
(RPC_RESPONSE_STANDARD_NAME)
90-95: "payload.v1.Object.Locations" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
90-90: RPC request type "TimestampRequest" should be named "RemoveByTimestampRequest" or "RemoveRemoveByTimestampRequest".
(RPC_REQUEST_STANDARD_NAME)
90-90: RPC response type "Locations" should be named "RemoveByTimestampResponse" or "RemoveRemoveByTimestampResponse".
(RPC_RESPONSE_STANDARD_NAME)
126-126: "payload.v1.Remove.Request" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
126-126: RPC request type "Request" should be named "StreamRemoveRequest" or "RemoveStreamRemoveRequest".
(RPC_REQUEST_STANDARD_NAME)
126-126: RPC response type "StreamLocation" should be named "StreamRemoveResponse" or "RemoveStreamRemoveResponse".
(RPC_RESPONSE_STANDARD_NAME)
apis/proto/v1/vald/filter.proto
33-33: Service name "Filter" should be suffixed with "Service".
(SERVICE_SUFFIX)
44-49: "payload.v1.Search.ObjectRequest" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
44-44: RPC request type "ObjectRequest" should be named "SearchObjectRequest" or "FilterSearchObjectRequest".
(RPC_REQUEST_STANDARD_NAME)
44-44: RPC response type "Response" should be named "SearchObjectResponse" or "FilterSearchObjectResponse".
(RPC_RESPONSE_STANDARD_NAME)
63-63: RPC request type "MultiObjectRequest" should be named "MultiSearchObjectRequest" or "FilterMultiSearchObjectRequest".
(RPC_REQUEST_STANDARD_NAME)
63-63: RPC response type "Responses" should be named "MultiSearchObjectResponse" or "FilterMultiSearchObjectResponse".
(RPC_RESPONSE_STANDARD_NAME)
85-85: "payload.v1.Search.ObjectRequest" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
85-85: RPC request type "ObjectRequest" should be named "StreamSearchObjectRequest" or "FilterStreamSearchObjectRequest".
(RPC_REQUEST_STANDARD_NAME)
85-85: RPC response type "StreamResponse" should be named "StreamSearchObjectResponse" or "FilterStreamSearchObjectResponse".
(RPC_RESPONSE_STANDARD_NAME)
97-102: "payload.v1.Insert.ObjectRequest" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
97-102: "payload.v1.Object.Location" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
97-97: RPC request type "ObjectRequest" should be named "InsertObjectRequest" or "FilterInsertObjectRequest".
(RPC_REQUEST_STANDARD_NAME)
97-97: RPC response type "Location" should be named "InsertObjectResponse" or "FilterInsertObjectResponse".
(RPC_RESPONSE_STANDARD_NAME)
118-118: "payload.v1.Insert.ObjectRequest" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
118-118: "payload.v1.Object.StreamLocation" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
118-118: RPC request type "ObjectRequest" should be named "StreamInsertObjectRequest" or "FilterStreamInsertObjectRequest".
(RPC_REQUEST_STANDARD_NAME)
118-118: RPC response type "StreamLocation" should be named "StreamInsertObjectResponse" or "FilterStreamInsertObjectResponse".
(RPC_RESPONSE_STANDARD_NAME)
130-135: "payload.v1.Object.Locations" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
130-130: RPC request type "MultiObjectRequest" should be named "MultiInsertObjectRequest" or "FilterMultiInsertObjectRequest".
(RPC_REQUEST_STANDARD_NAME)
130-130: RPC response type "Locations" should be named "MultiInsertObjectResponse" or "FilterMultiInsertObjectResponse".
(RPC_RESPONSE_STANDARD_NAME)
147-152: "payload.v1.Object.Location" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
147-152: "payload.v1.Update.ObjectRequest" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
147-147: RPC request type "ObjectRequest" should be named "UpdateObjectRequest" or "FilterUpdateObjectRequest".
(RPC_REQUEST_STANDARD_NAME)
147-147: RPC response type "Location" should be named "UpdateObjectResponse" or "FilterUpdateObjectResponse".
(RPC_RESPONSE_STANDARD_NAME)
167-167: "payload.v1.Object.StreamLocation" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
167-167: "payload.v1.Update.ObjectRequest" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
167-167: RPC request type "ObjectRequest" should be named "StreamUpdateObjectRequest" or "FilterStreamUpdateObjectRequest".
(RPC_REQUEST_STANDARD_NAME)
167-167: RPC response type "StreamLocation" should be named "StreamUpdateObjectResponse" or "FilterStreamUpdateObjectResponse".
(RPC_RESPONSE_STANDARD_NAME)
185-190: "payload.v1.Object.Locations" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
185-185: RPC request type "MultiObjectRequest" should be named "MultiUpdateObjectRequest" or "FilterMultiUpdateObjectRequest".
(RPC_REQUEST_STANDARD_NAME)
185-185: RPC response type "Locations" should be named "MultiUpdateObjectResponse" or "FilterMultiUpdateObjectResponse".
(RPC_RESPONSE_STANDARD_NAME)
202-207: "payload.v1.Object.Location" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
202-207: "payload.v1.Upsert.ObjectRequest" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
202-202: RPC request type "ObjectRequest" should be named "UpsertObjectRequest" or "FilterUpsertObjectRequest".
(RPC_REQUEST_STANDARD_NAME)
202-202: RPC response type "Location" should be named "UpsertObjectResponse" or "FilterUpsertObjectResponse".
(RPC_RESPONSE_STANDARD_NAME)
219-219: "payload.v1.Object.StreamLocation" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
219-219: "payload.v1.Upsert.ObjectRequest" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
219-219: RPC request type "ObjectRequest" should be named "StreamUpsertObjectRequest" or "FilterStreamUpsertObjectRequest".
(RPC_REQUEST_STANDARD_NAME)
219-219: RPC response type "StreamLocation" should be named "StreamUpsertObjectResponse" or "FilterStreamUpsertObjectResponse".
(RPC_RESPONSE_STANDARD_NAME)
apis/proto/v1/vald/search.proto
31-31: Service name "Search" should be suffixed with "Service".
(SERVICE_SUFFIX)
56-61: "payload.v1.Search.Request" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
56-61: "payload.v1.Search.Response" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
56-56: RPC request type "Request" should be named "SearchRequest" or "SearchSearchRequest".
(RPC_REQUEST_STANDARD_NAME)
56-56: RPC response type "Response" should be named "SearchResponse" or "SearchSearchResponse".
(RPC_RESPONSE_STANDARD_NAME)
88-93: "payload.v1.Search.IDRequest" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
88-93: "payload.v1.Search.Response" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
88-88: RPC request type "IDRequest" should be named "SearchByIDRequest" or "SearchSearchByIDRequest".
(RPC_REQUEST_STANDARD_NAME)
88-88: RPC response type "Response" should be named "SearchByIDResponse" or "SearchSearchByIDResponse".
(RPC_RESPONSE_STANDARD_NAME)
121-121: "payload.v1.Search.Request" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
121-121: "payload.v1.Search.StreamResponse" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
121-121: RPC request type "Request" should be named "StreamSearchRequest" or "SearchStreamSearchRequest".
(RPC_REQUEST_STANDARD_NAME)
121-121: RPC response type "StreamResponse" should be named "StreamSearchResponse" or "SearchStreamSearchResponse".
(RPC_RESPONSE_STANDARD_NAME)
149-149: "payload.v1.Search.IDRequest" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
149-149: "payload.v1.Search.StreamResponse" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
149-149: RPC request type "IDRequest" should be named "StreamSearchByIDRequest" or "SearchStreamSearchByIDRequest".
(RPC_REQUEST_STANDARD_NAME)
149-149: RPC response type "StreamResponse" should be named "StreamSearchByIDResponse" or "SearchStreamSearchByIDResponse".
(RPC_RESPONSE_STANDARD_NAME)
180-185: "payload.v1.Search.MultiRequest" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
180-185: "payload.v1.Search.Responses" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
180-180: RPC request type "MultiRequest" should be named "MultiSearchRequest" or "SearchMultiSearchRequest".
(RPC_REQUEST_STANDARD_NAME)
180-180: RPC response type "Responses" should be named "MultiSearchResponse" or "SearchMultiSearchResponse".
(RPC_RESPONSE_STANDARD_NAME)
216-221: "payload.v1.Search.MultiIDRequest" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
216-221: "payload.v1.Search.Responses" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
216-216: RPC request type "MultiIDRequest" should be named "MultiSearchByIDRequest" or "SearchMultiSearchByIDRequest".
(RPC_REQUEST_STANDARD_NAME)
216-216: RPC response type "Responses" should be named "MultiSearchByIDResponse" or "SearchMultiSearchByIDResponse".
(RPC_RESPONSE_STANDARD_NAME)
247-252: "payload.v1.Search.Request" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
247-252: "payload.v1.Search.Response" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
247-247: RPC request type "Request" should be named "LinearSearchRequest" or "SearchLinearSearchRequest".
(RPC_REQUEST_STANDARD_NAME)
247-247: RPC response type "Response" should be named "LinearSearchResponse" or "SearchLinearSearchResponse".
(RPC_RESPONSE_STANDARD_NAME)
280-285: "payload.v1.Search.IDRequest" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
280-285: "payload.v1.Search.Response" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
280-280: RPC request type "IDRequest" should be named "LinearSearchByIDRequest" or "SearchLinearSearchByIDRequest".
(RPC_REQUEST_STANDARD_NAME)
280-280: RPC response type "Response" should be named "LinearSearchByIDResponse" or "SearchLinearSearchByIDResponse".
(RPC_RESPONSE_STANDARD_NAME)
313-313: "payload.v1.Search.Request" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
313-313: "payload.v1.Search.StreamResponse" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
313-313: RPC request type "Request" should be named "StreamLinearSearchRequest" or "SearchStreamLinearSearchRequest".
(RPC_REQUEST_STANDARD_NAME)
313-313: RPC response type "StreamResponse" should be named "StreamLinearSearchResponse" or "SearchStreamLinearSearchResponse".
(RPC_RESPONSE_STANDARD_NAME)
341-341: "payload.v1.Search.IDRequest" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
341-341: "payload.v1.Search.StreamResponse" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
341-341: RPC request type "IDRequest" should be named "StreamLinearSearchByIDRequest" or "SearchStreamLinearSearchByIDRequest".
(RPC_REQUEST_STANDARD_NAME)
341-341: RPC response type "StreamResponse" should be named "StreamLinearSearchByIDResponse" or "SearchStreamLinearSearchByIDResponse".
(RPC_RESPONSE_STANDARD_NAME)
372-377: "payload.v1.Search.MultiRequest" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
372-377: "payload.v1.Search.Responses" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
372-372: RPC request type "MultiRequest" should be named "MultiLinearSearchRequest" or "SearchMultiLinearSearchRequest".
(RPC_REQUEST_STANDARD_NAME)
372-372: RPC response type "Responses" should be named "MultiLinearSearchResponse" or "SearchMultiLinearSearchResponse".
(RPC_RESPONSE_STANDARD_NAME)
🪛 LanguageTool
apis/docs/v1/flush.md
[uncategorized] ~4-~4: You might be missing the article “the” here.
Context: # Vald Flush APIs ## Overview Flush Service is responsible for removing all...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
apis/docs/v1/update.md
[grammar] ~143-~143: An article may be missing.
Context: ... | | ALREADY_EXISTS | Request pair of ID and vector is already inserted. ...
(BUNCH_OF)
[uncategorized] ~151-~151: ‘Amount of’ should usually only be used with uncountable or mass nouns. Consider using “number” if this is not the case.
Context: ... recommended method to update the large amount of vectors. ### Input - the scheme of...
(AMOUNTOF_TO_NUMBEROF)
[grammar] ~286-~286: An article may be missing.
Context: ... | | ALREADY_EXISTS | Request pair of ID and vector is already inserted. ...
(BUNCH_OF)
[grammar] ~439-~439: An article may be missing.
Context: ... | | ALREADY_EXISTS | Request pair of ID and vector is already inserted. ...
(BUNCH_OF)
apis/docs/v1/upsert.md
[style] ~149-~149: Specify a number, remove phrase, or simply use “many” or “numerous”
Context: .... It’s the recommended method to upsert a large number of vectors. ### Input - the scheme of `p...
(LARGE_NUMBER_OF)
apis/docs/v1/insert.md
[style] ~143-~143: Specify a number, remove phrase, or simply use “many” or “numerous”
Context: .... It's the recommended method to insert a large number of vectors. ### Input - the scheme of `p...
(LARGE_NUMBER_OF)
apis/docs/v1/index.md
[grammar] ~63-~63: The noun should probably be in the singular form.
Context: ...C to get the index information for each agents. ### Input - the scheme of `payload.v...
(EVERY_EACH_SINGULAR)
[grammar] ~109-~109: The noun should probably be in the singular form.
Context: ...Entry | repeated | count infos for each agents | | replica | uint32 ...
(EVERY_EACH_SINGULAR)
[grammar] ~231-~231: The noun should probably be in the singular form.
Context: ...PC to get the index statistics for each agents. ### Input - the scheme of `payload.v...
(EVERY_EACH_SINGULAR)
[grammar] ~304-~304: The noun should probably be in the singular form.
Context: ...Entry | repeated | count infos for each agents | - Info.Index.StatisticsDetail.Deta...
(EVERY_EACH_SINGULAR)
apis/docs/v1/filter.md
[style] ~567-~567: Specify a number, remove phrase, or simply use “many” or “numerous”
Context: .... It's the recommended method to insert a large number of objects. ### Input - the scheme of `p...
(LARGE_NUMBER_OF)
[uncategorized] ~927-~927: ‘Amount of’ should usually only be used with uncountable or mass nouns. Consider using “number” if this is not the case.
Context: ... recommended method to update the large amount of objects. ### Input - the scheme of...
(AMOUNTOF_TO_NUMBEROF)
apis/docs/v1/remove.md
[style] ~225-~225: Specify a number, remove phrase, or simply use “many” or “numerous”
Context: .... It's the recommended method to remove a large number of vectors. ### Input - the scheme of `p...
(LARGE_NUMBER_OF)
🪛 Markdownlint (0.35.0)
apis/docs/v1/update.md
73-73: Expected: fenced; Actual: indented
Code block style
(MD046, code-block-style)
204-204: Expected: fenced; Actual: indented
Code block style
(MD046, code-block-style)
359-359: Expected: fenced; Actual: indented
Code block style
(MD046, code-block-style)
apis/docs/v1/upsert.md
72-72: Expected: fenced; Actual: indented
Code block style
(MD046, code-block-style)
202-202: Expected: fenced; Actual: indented
Code block style
(MD046, code-block-style)
356-356: Expected: fenced; Actual: indented
Code block style
(MD046, code-block-style)
apis/docs/v1/filter.md
866-866: Expected: fenced; Actual: indented
Code block style
(MD046, code-block-style)
980-980: Expected: fenced; Actual: indented
Code block style
(MD046, code-block-style)
1118-1118: Expected: fenced; Actual: indented
Code block style
(MD046, code-block-style)
1239-1239: Expected: fenced; Actual: indented
Code block style
(MD046, code-block-style)
1350-1350: Expected: fenced; Actual: indented
Code block style
(MD046, code-block-style)
1488-1488: Expected: fenced; Actual: indented
Code block style
(MD046, code-block-style)
apis/docs/v1/remove.md
149-149: Expected: fenced; Actual: indented
Code block style
(MD046, code-block-style)
🔇 Additional comments (14)
apis/proto/v1/mirror/mirror.proto (2)
28-29
: LGTM! Clear and well-structured service documentation.
The overview section effectively describes the Mirror service's responsibility and follows the project's documentation standards.
30-30
: Verify service naming convention across the project.
Static analysis suggests that the service name "Mirror" should be suffixed with "Service" according to protobuf best practices.
Let's check if this naming convention is consistently applied across other services in the project:
🧰 Tools
🪛 buf (1.47.2)
30-30: Service name "Mirror" should be suffixed with "Service".
(SERVICE_SUFFIX)
apis/docs/v1/doc.tmpl (2)
1-8
: Consider adding validation for malformed documentation sections
The template assumes well-formed documentation with proper "---" delimiters. Consider adding validation or error handling for:
- Empty documentation sections
- Malformed section headers
- Missing required sections
38-40
: Verify referenced template definitions exist
The template references external templates for schemes and fields. Please ensure these templates exist and are properly defined:
scheme:*
field:*
Also applies to: 46-48
✅ Verification successful
Template definitions are properly structured and available
The template system is correctly set up with all necessary template definitions:
- The
scheme:*
andfield:*
templates are defined inpayload.md.tmpl
- Each template has a corresponding underscore-prefixed implementation (e.g.
scheme:foo
calls_scheme:foo
) - The template hierarchy is complete and consistent
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check for referenced template definitions
rg -l 'define "scheme:' .
rg -l 'define "field:' .
Length of output: 116
Script:
#!/bin/bash
# Check the actual template definitions in payload.md.tmpl
rg 'define "(?:scheme|field):' -A 5 ./apis/docs/v1/payload.md.tmpl
Length of output: 37572
Script:
#!/bin/bash
# Check for the referenced underscore templates that are being used
rg 'template "_(?:scheme|field):' -A 1 ./apis/docs/v1/payload.md.tmpl
Length of output: 29647
Script:
#!/bin/bash
# Check for the definition of underscore templates
rg 'define "_(?:scheme|field):' ./apis/docs/v1/
Length of output: 17056
Makefile.d/proto.mk (1)
74-77
: 🛠️ Refactor suggestion
Add error handling for template generation
The template generation process should handle potential errors when the template file is missing or invalid.
proto/gen/api/docs/payload: $(ROOTDIR)/apis/docs/v1/payload.md.tmpl
+ @if [ ! -f "$(ROOTDIR)/apis/docs/v1/payload.md.tmpl" ]; then \
+ echo "Error: Template file not found"; \
+ exit 1; \
+ fi
Likely invalid or redundant comment.
apis/docs/v1/object.md (1)
191-191
:
Fix incorrect reference in StreamGetObject documentation
The documentation incorrectly refers to "Upsert" instead of "GetObject".
-Each Upsert request and response are independent.
+Each GetObject request and response are independent.
Likely invalid or redundant comment.
apis/docs/v1/remove.md (1)
333-336
: Enhance the gRPC message size limitation notice
The notice should include specific details about:
- Default gRPC message size limit
- Recommended maximum number of vectors per request
- How to configure custom message size limits
apis/docs/v1/insert.md (1)
279-282
: Enhance the gRPC message size limitation notice
The notice should include specific details about:
- Default gRPC message size limit
- Recommended maximum number of vectors per request
- How to configure custom message size limits
apis/proto/v1/vald/search.proto (2)
32-166
: Reduce documentation duplication.
The status codes and troubleshooting sections are identical across all RPC methods. Consider consolidating these common sections into a shared documentation area.
🧰 Tools
🪛 buf (1.47.2)
56-61: "payload.v1.Search.Request" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
56-61: "payload.v1.Search.Response" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
56-56: RPC request type "Request" should be named "SearchRequest" or "SearchSearchRequest".
(RPC_REQUEST_STANDARD_NAME)
56-56: RPC response type "Response" should be named "SearchResponse" or "SearchSearchResponse".
(RPC_RESPONSE_STANDARD_NAME)
88-93: "payload.v1.Search.IDRequest" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
88-93: "payload.v1.Search.Response" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
88-88: RPC request type "IDRequest" should be named "SearchByIDRequest" or "SearchSearchByIDRequest".
(RPC_REQUEST_STANDARD_NAME)
88-88: RPC response type "Response" should be named "SearchByIDResponse" or "SearchSearchByIDResponse".
(RPC_RESPONSE_STANDARD_NAME)
121-121: "payload.v1.Search.Request" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
121-121: "payload.v1.Search.StreamResponse" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
121-121: RPC request type "Request" should be named "StreamSearchRequest" or "SearchStreamSearchRequest".
(RPC_REQUEST_STANDARD_NAME)
121-121: RPC response type "StreamResponse" should be named "StreamSearchResponse" or "SearchStreamSearchResponse".
(RPC_RESPONSE_STANDARD_NAME)
149-149: "payload.v1.Search.IDRequest" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
149-149: "payload.v1.Search.StreamResponse" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
149-149: RPC request type "IDRequest" should be named "StreamSearchByIDRequest" or "SearchStreamSearchByIDRequest".
(RPC_REQUEST_STANDARD_NAME)
149-149: RPC response type "StreamResponse" should be named "StreamSearchByIDResponse" or "SearchStreamSearchByIDResponse".
(RPC_RESPONSE_STANDARD_NAME)
Line range hint 627-630
: Enhance gRPC message size limitation notice.
The notice about gRPC message size limitations lacks specific details that would help developers.
🧰 Tools
🪛 buf (1.47.2)
31-31: Service name "Search" should be suffixed with "Service".
(SERVICE_SUFFIX)
56-61: "payload.v1.Search.Request" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
56-61: "payload.v1.Search.Response" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
56-56: RPC request type "Request" should be named "SearchRequest" or "SearchSearchRequest".
(RPC_REQUEST_STANDARD_NAME)
56-56: RPC response type "Response" should be named "SearchResponse" or "SearchSearchResponse".
(RPC_RESPONSE_STANDARD_NAME)
88-93: "payload.v1.Search.IDRequest" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
88-93: "payload.v1.Search.Response" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
88-88: RPC request type "IDRequest" should be named "SearchByIDRequest" or "SearchSearchByIDRequest".
(RPC_REQUEST_STANDARD_NAME)
88-88: RPC response type "Response" should be named "SearchByIDResponse" or "SearchSearchByIDResponse".
(RPC_RESPONSE_STANDARD_NAME)
121-121: "payload.v1.Search.Request" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
121-121: "payload.v1.Search.StreamResponse" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
121-121: RPC request type "Request" should be named "StreamSearchRequest" or "SearchStreamSearchRequest".
(RPC_REQUEST_STANDARD_NAME)
121-121: RPC response type "StreamResponse" should be named "StreamSearchResponse" or "SearchStreamSearchResponse".
(RPC_RESPONSE_STANDARD_NAME)
149-149: "payload.v1.Search.IDRequest" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
149-149: "payload.v1.Search.StreamResponse" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
149-149: RPC request type "IDRequest" should be named "StreamSearchByIDRequest" or "SearchStreamSearchByIDRequest".
(RPC_REQUEST_STANDARD_NAME)
149-149: RPC response type "StreamResponse" should be named "StreamSearchByIDResponse" or "SearchStreamSearchByIDResponse".
(RPC_RESPONSE_STANDARD_NAME)
180-185: "payload.v1.Search.MultiRequest" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
180-185: "payload.v1.Search.Responses" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
180-180: RPC request type "MultiRequest" should be named "MultiSearchRequest" or "SearchMultiSearchRequest".
(RPC_REQUEST_STANDARD_NAME)
180-180: RPC response type "Responses" should be named "MultiSearchResponse" or "SearchMultiSearchResponse".
(RPC_RESPONSE_STANDARD_NAME)
216-221: "payload.v1.Search.MultiIDRequest" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
216-221: "payload.v1.Search.Responses" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
216-216: RPC request type "MultiIDRequest" should be named "MultiSearchByIDRequest" or "SearchMultiSearchByIDRequest".
(RPC_REQUEST_STANDARD_NAME)
216-216: RPC response type "Responses" should be named "MultiSearchByIDResponse" or "SearchMultiSearchByIDResponse".
(RPC_RESPONSE_STANDARD_NAME)
247-252: "payload.v1.Search.Request" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
247-252: "payload.v1.Search.Response" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
247-247: RPC request type "Request" should be named "LinearSearchRequest" or "SearchLinearSearchRequest".
(RPC_REQUEST_STANDARD_NAME)
247-247: RPC response type "Response" should be named "LinearSearchResponse" or "SearchLinearSearchResponse".
(RPC_RESPONSE_STANDARD_NAME)
280-285: "payload.v1.Search.IDRequest" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
280-285: "payload.v1.Search.Response" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
280-280: RPC request type "IDRequest" should be named "LinearSearchByIDRequest" or "SearchLinearSearchByIDRequest".
(RPC_REQUEST_STANDARD_NAME)
280-280: RPC response type "Response" should be named "LinearSearchByIDResponse" or "SearchLinearSearchByIDResponse".
(RPC_RESPONSE_STANDARD_NAME)
313-313: "payload.v1.Search.Request" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
313-313: "payload.v1.Search.StreamResponse" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
313-313: RPC request type "Request" should be named "StreamLinearSearchRequest" or "SearchStreamLinearSearchRequest".
(RPC_REQUEST_STANDARD_NAME)
313-313: RPC response type "StreamResponse" should be named "StreamLinearSearchResponse" or "SearchStreamLinearSearchResponse".
(RPC_RESPONSE_STANDARD_NAME)
341-341: "payload.v1.Search.IDRequest" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
341-341: "payload.v1.Search.StreamResponse" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
341-341: RPC request type "IDRequest" should be named "StreamLinearSearchByIDRequest" or "SearchStreamLinearSearchByIDRequest".
(RPC_REQUEST_STANDARD_NAME)
341-341: RPC response type "StreamResponse" should be named "StreamLinearSearchByIDResponse" or "SearchStreamLinearSearchByIDResponse".
(RPC_RESPONSE_STANDARD_NAME)
372-377: "payload.v1.Search.MultiRequest" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
372-377: "payload.v1.Search.Responses" is used as the request or response type for multiple RPCs.
(RPC_REQUEST_RESPONSE_UNIQUE)
372-372: RPC request type "MultiRequest" should be named "MultiLinearSearchRequest" or "SearchMultiLinearSearchRequest".
(RPC_REQUEST_STANDARD_NAME)
372-372: RPC response type "Responses" should be named "MultiLinearSearchResponse" or "SearchMultiLinearSearchResponse".
(RPC_RESPONSE_STANDARD_NAME)
408-408: RPC request type "MultiIDRequest" should be named "MultiLinearSearchByIDRequest" or "SearchMultiLinearSearchByIDRequest".
(RPC_REQUEST_STANDARD_NAME)
408-408: RPC response type "Responses" should be named "MultiLinearSearchByIDResponse" or "SearchMultiLinearSearchByIDResponse".
(RPC_RESPONSE_STANDARD_NAME)
apis/docs/v1/filter.md (1)
1-8
: Documentation follows consistent structure.
The documentation maintains consistency with other API docs, which is good for maintainability and usability.
apis/proto/v1/vald/upsert.proto (2)
29-30
: LGTM! Clear service overview.
The service overview effectively describes the dual responsibility of the Upsert service (update existing vectors or insert new ones).
32-57
: LGTM! Comprehensive method documentation.
The Upsert method documentation is well-structured with:
- Clear overview
- Detailed status code table
- Practical troubleshooting guidance
🧰 Tools
🪛 buf (1.47.2)
57-57: RPC request type "Request" should be named "UpsertRequest" or "UpsertUpsertRequest".
(RPC_REQUEST_STANDARD_NAME)
57-57: RPC response type "Location" should be named "UpsertResponse" or "UpsertUpsertResponse".
(RPC_RESPONSE_STANDARD_NAME)
Makefile (1)
156-159
: LGTM! Well-structured protobuf documentation variables.
The new variables are well-organized and follow consistent naming patterns:
PROTO_VALD_APIS
: Correctly filters protobuf files from vald directoryPROTO_VALD_API_DOCS
: Properly maps proto files to documentation pathsPROTO_MIRROR_APIS
: Correctly filters protobuf files from mirror directoryPROTO_MIRROR_API_DOCS
: Properly maps proto files to documentation paths
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
LanguageTool
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 28 in 252a0cd
Insert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Specify a number, remove phrase, or simply use “many” or “numerous” (LARGE_NUMBER_OF[1])
Suggestions: many
, numerous
URL: https://languagetool.org/insights/post/wordiness/
Rule: https://community.languagetool.org/rule/show/LARGE_NUMBER_OF?lang=en-US&subId=1
Category: REDUNDANCY
Line 143 in 252a0cd
It's the recommended method to insert a large number of vectors. |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 151 in 252a0cd
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 152 in 252a0cd
Insert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 220 in 252a0cd
Object.Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 221 in 252a0cd
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 294 in 252a0cd
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 295 in 252a0cd
Insert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 10 in 252a0cd
rpc Register(payload.v1.Mirror.Targets) returns (payload.v1.Mirror.Targets) {} |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 15 in 252a0cd
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 94 in 252a0cd
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 199 in 252a0cd
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 250 in 252a0cd
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 251 in 252a0cd
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 329 in 252a0cd
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 330 in 252a0cd
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 379 in 252a0cd
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 14 in 252a0cd
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 28 in 252a0cd
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 29 in 252a0cd
Remove.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Operator
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 133 in 252a0cd
Remove.Timestamp.Operator operator = 2; |
[LanguageTool] reported by reviewdog 🐶
Specify a number, remove phrase, or simply use “many” or “numerous” (LARGE_NUMBER_OF[1])
Suggestions: many
, numerous
URL: https://languagetool.org/insights/post/wordiness/
Rule: https://community.languagetool.org/rule/show/LARGE_NUMBER_OF?lang=en-US&subId=1
Category: REDUNDANCY
Line 225 in 252a0cd
It's the recommended method to remove a large number of vectors. |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 233 in 252a0cd
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 234 in 252a0cd
Remove.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 274 in 252a0cd
Object.Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 275 in 252a0cd
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 348 in 252a0cd
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 349 in 252a0cd
Remove.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 22 in 252a0cd
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 37 in 252a0cd
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 180 in 252a0cd
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 324 in 252a0cd
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 402 in 252a0cd
Search.Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 403 in 252a0cd
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 480 in 252a0cd
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 558 in 252a0cd
Search.Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 559 in 252a0cd
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 643 in 252a0cd
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 810 in 252a0cd
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 968 in 252a0cd
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1112 in 252a0cd
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1256 in 252a0cd
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1334 in 252a0cd
Search.Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1335 in 252a0cd
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1412 in 252a0cd
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1490 in 252a0cd
Search.Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1491 in 252a0cd
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1575 in 252a0cd
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1743 in 252a0cd
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 14 in 252a0cd
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 28 in 252a0cd
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 29 in 252a0cd
Update.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
An article may be missing. (BUNCH_OF[6])
Suggestions: a pair of
Rule: https://community.languagetool.org/rule/show/BUNCH_OF?lang=en-US&subId=6
Category: GRAMMAR
Line 143 in 252a0cd
| ALREADY_EXISTS | Request pair of ID and vector is already inserted. | Change request ID. | |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 159 in 252a0cd
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 160 in 252a0cd
Update.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 232 in 252a0cd
Object.Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 233 in 252a0cd
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
An article may be missing. (BUNCH_OF[6])
Suggestions: a pair of
Rule: https://community.languagetool.org/rule/show/BUNCH_OF?lang=en-US&subId=6
Category: GRAMMAR
Line 286 in 252a0cd
| ALREADY_EXISTS | Request pair of ID and vector is already inserted. | Change request ID. | |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 308 in 252a0cd
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 309 in 252a0cd
Update.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
An article may be missing. (BUNCH_OF[6])
Suggestions: a pair of
Rule: https://community.languagetool.org/rule/show/BUNCH_OF?lang=en-US&subId=6
Category: GRAMMAR
Line 439 in 252a0cd
| ALREADY_EXISTS | Request pair of ID and vector is already inserted. | Change request ID. | |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 13 in 252a0cd
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 27 in 252a0cd
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 28 in 252a0cd
Upsert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Specify a number, remove phrase, or simply use “many” or “numerous” (LARGE_NUMBER_OF[1])
Suggestions: many
, numerous
URL: https://languagetool.org/insights/post/wordiness/
Rule: https://community.languagetool.org/rule/show/LARGE_NUMBER_OF?lang=en-US&subId=1
Category: REDUNDANCY
Line 149 in 252a0cd
It’s the recommended method to upsert a large number of vectors. |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 157 in 252a0cd
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 158 in 252a0cd
Upsert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 230 in 252a0cd
Object.Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 231 in 252a0cd
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 305 in 252a0cd
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 306 in 252a0cd
Upsert.Config config = 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
LanguageTool
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 28 in 1554911
Insert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Specify a number, remove phrase, or simply use “many” or “numerous” (LARGE_NUMBER_OF[1])
Suggestions: many
, numerous
URL: https://languagetool.org/insights/post/wordiness/
Rule: https://community.languagetool.org/rule/show/LARGE_NUMBER_OF?lang=en-US&subId=1
Category: REDUNDANCY
Line 143 in 1554911
It's the recommended method to insert a large number of vectors. |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 151 in 1554911
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 152 in 1554911
Insert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 220 in 1554911
Object.Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 221 in 1554911
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 294 in 1554911
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 295 in 1554911
Insert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 10 in 1554911
rpc Register(payload.v1.Mirror.Targets) returns (payload.v1.Mirror.Targets) {} |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 15 in 1554911
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 94 in 1554911
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 199 in 1554911
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 250 in 1554911
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 251 in 1554911
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 329 in 1554911
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 330 in 1554911
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 379 in 1554911
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 14 in 1554911
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 28 in 1554911
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 29 in 1554911
Remove.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Operator
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 133 in 1554911
Remove.Timestamp.Operator operator = 2; |
[LanguageTool] reported by reviewdog 🐶
Specify a number, remove phrase, or simply use “many” or “numerous” (LARGE_NUMBER_OF[1])
Suggestions: many
, numerous
URL: https://languagetool.org/insights/post/wordiness/
Rule: https://community.languagetool.org/rule/show/LARGE_NUMBER_OF?lang=en-US&subId=1
Category: REDUNDANCY
Line 225 in 1554911
It's the recommended method to remove a large number of vectors. |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 233 in 1554911
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 234 in 1554911
Remove.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 274 in 1554911
Object.Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 275 in 1554911
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 348 in 1554911
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 349 in 1554911
Remove.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 22 in 1554911
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 37 in 1554911
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 180 in 1554911
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 324 in 1554911
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 402 in 1554911
Search.Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 403 in 1554911
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 480 in 1554911
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 558 in 1554911
Search.Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 559 in 1554911
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 643 in 1554911
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 810 in 1554911
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 968 in 1554911
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1112 in 1554911
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1256 in 1554911
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1334 in 1554911
Search.Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1335 in 1554911
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1412 in 1554911
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1490 in 1554911
Search.Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1491 in 1554911
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1575 in 1554911
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1743 in 1554911
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 14 in 1554911
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 28 in 1554911
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 29 in 1554911
Update.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
An article may be missing. (BUNCH_OF[6])
Suggestions: a pair of
Rule: https://community.languagetool.org/rule/show/BUNCH_OF?lang=en-US&subId=6
Category: GRAMMAR
Line 143 in 1554911
| ALREADY_EXISTS | Request pair of ID and vector is already inserted. | Change request ID. | |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 159 in 1554911
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 160 in 1554911
Update.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 232 in 1554911
Object.Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 233 in 1554911
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
An article may be missing. (BUNCH_OF[6])
Suggestions: a pair of
Rule: https://community.languagetool.org/rule/show/BUNCH_OF?lang=en-US&subId=6
Category: GRAMMAR
Line 286 in 1554911
| ALREADY_EXISTS | Request pair of ID and vector is already inserted. | Change request ID. | |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 308 in 1554911
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 309 in 1554911
Update.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
An article may be missing. (BUNCH_OF[6])
Suggestions: a pair of
Rule: https://community.languagetool.org/rule/show/BUNCH_OF?lang=en-US&subId=6
Category: GRAMMAR
Line 439 in 1554911
| ALREADY_EXISTS | Request pair of ID and vector is already inserted. | Change request ID. | |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 13 in 1554911
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 27 in 1554911
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 28 in 1554911
Upsert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Specify a number, remove phrase, or simply use “many” or “numerous” (LARGE_NUMBER_OF[1])
Suggestions: many
, numerous
URL: https://languagetool.org/insights/post/wordiness/
Rule: https://community.languagetool.org/rule/show/LARGE_NUMBER_OF?lang=en-US&subId=1
Category: REDUNDANCY
Line 149 in 1554911
It’s the recommended method to upsert a large number of vectors. |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 157 in 1554911
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 158 in 1554911
Upsert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 230 in 1554911
Object.Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 231 in 1554911
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 305 in 1554911
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 306 in 1554911
Upsert.Config config = 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
LanguageTool
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 28 in d9ee0a9
Insert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Specify a number, remove phrase, or simply use “many” or “numerous” (LARGE_NUMBER_OF[1])
Suggestions: many
, numerous
URL: https://languagetool.org/insights/post/wordiness/
Rule: https://community.languagetool.org/rule/show/LARGE_NUMBER_OF?lang=en-US&subId=1
Category: REDUNDANCY
Line 143 in d9ee0a9
It's the recommended method to insert a large number of vectors. |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 151 in d9ee0a9
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 152 in d9ee0a9
Insert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 220 in d9ee0a9
Object.Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 221 in d9ee0a9
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 294 in d9ee0a9
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 295 in d9ee0a9
Insert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 10 in d9ee0a9
rpc Register(payload.v1.Mirror.Targets) returns (payload.v1.Mirror.Targets) {} |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 15 in d9ee0a9
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 94 in d9ee0a9
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 199 in d9ee0a9
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 250 in d9ee0a9
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 251 in d9ee0a9
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 329 in d9ee0a9
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 330 in d9ee0a9
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 379 in d9ee0a9
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 14 in d9ee0a9
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 28 in d9ee0a9
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 29 in d9ee0a9
Remove.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Operator
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 133 in d9ee0a9
Remove.Timestamp.Operator operator = 2; |
[LanguageTool] reported by reviewdog 🐶
Specify a number, remove phrase, or simply use “many” or “numerous” (LARGE_NUMBER_OF[1])
Suggestions: many
, numerous
URL: https://languagetool.org/insights/post/wordiness/
Rule: https://community.languagetool.org/rule/show/LARGE_NUMBER_OF?lang=en-US&subId=1
Category: REDUNDANCY
Line 225 in d9ee0a9
It's the recommended method to remove a large number of vectors. |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 233 in d9ee0a9
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 234 in d9ee0a9
Remove.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 274 in d9ee0a9
Object.Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 275 in d9ee0a9
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 348 in d9ee0a9
Object.ID id = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 349 in d9ee0a9
Remove.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 22 in d9ee0a9
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 37 in d9ee0a9
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 180 in d9ee0a9
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 324 in d9ee0a9
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 402 in d9ee0a9
Search.Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 403 in d9ee0a9
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 480 in d9ee0a9
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 558 in d9ee0a9
Search.Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 559 in d9ee0a9
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 643 in d9ee0a9
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 810 in d9ee0a9
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 968 in d9ee0a9
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1112 in d9ee0a9
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1256 in d9ee0a9
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1334 in d9ee0a9
Search.Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1335 in d9ee0a9
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1412 in d9ee0a9
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Response
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1490 in d9ee0a9
Search.Response response = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1491 in d9ee0a9
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1575 in d9ee0a9
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 1743 in d9ee0a9
Search.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 14 in d9ee0a9
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 28 in d9ee0a9
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 29 in d9ee0a9
Update.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
An article may be missing. (BUNCH_OF[6])
Suggestions: a pair of
Rule: https://community.languagetool.org/rule/show/BUNCH_OF?lang=en-US&subId=6
Category: GRAMMAR
Line 143 in d9ee0a9
| ALREADY_EXISTS | Request pair of ID and vector is already inserted. | Change request ID. | |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 159 in d9ee0a9
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 160 in d9ee0a9
Update.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 232 in d9ee0a9
Object.Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 233 in d9ee0a9
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
An article may be missing. (BUNCH_OF[6])
Suggestions: a pair of
Rule: https://community.languagetool.org/rule/show/BUNCH_OF?lang=en-US&subId=6
Category: GRAMMAR
Line 286 in d9ee0a9
| ALREADY_EXISTS | Request pair of ID and vector is already inserted. | Change request ID. | |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 308 in d9ee0a9
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 309 in d9ee0a9
Update.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
An article may be missing. (BUNCH_OF[6])
Suggestions: a pair of
Rule: https://community.languagetool.org/rule/show/BUNCH_OF?lang=en-US&subId=6
Category: GRAMMAR
Line 439 in d9ee0a9
| ALREADY_EXISTS | Request pair of ID and vector is already inserted. | Change request ID. | |
[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION
Line 13 in d9ee0a9
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 27 in d9ee0a9
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 28 in d9ee0a9
Upsert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Specify a number, remove phrase, or simply use “many” or “numerous” (LARGE_NUMBER_OF[1])
Suggestions: many
, numerous
URL: https://languagetool.org/insights/post/wordiness/
Rule: https://community.languagetool.org/rule/show/LARGE_NUMBER_OF?lang=en-US&subId=1
Category: REDUNDANCY
Line 149 in d9ee0a9
It’s the recommended method to upsert a large number of vectors. |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 157 in d9ee0a9
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 158 in d9ee0a9
Upsert.Config config = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Location
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 230 in d9ee0a9
Object.Location location = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Status
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 231 in d9ee0a9
google.rpc.Status status = 2; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Vector
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 305 in d9ee0a9
Object.Vector vector = 1; |
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Config
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Line 306 in d9ee0a9
Upsert.Config config = 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
Makefile (1)
156-159
: LGTM! Consider adding documentation.The implementation of the new protobuf documentation variables is correct and follows the established patterns. Consider adding a comment block above these variables explaining their purpose for better maintainability.
+# Variables for API documentation generation +# PROTO_VALD_APIS: List of protobuf files from vald API directory +# PROTO_VALD_API_DOCS: Generated documentation paths for vald APIs +# PROTO_MIRROR_APIS: List of protobuf files from mirror API directory +# PROTO_MIRROR_API_DOCS: Generated documentation paths for mirror APIs PROTO_VALD_APIS := $(eval PROTO_VALD_APIS := $(filter $(ROOTDIR)/apis/proto/v1/vald/%.proto,$(PROTOS)))$(PROTO_VALD_APIS)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
Makefile
(1 hunks)Makefile.d/functions.mk
(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- Makefile.d/functions.mk
🔇 Additional comments (1)
Makefile (1)
156-159
: Verify usage in included makefiles.
Let's verify how these new variables are used in the included makefiles to ensure proper integration.
✅ Verification successful
The variables are properly integrated and used in the Makefile system
The verification shows that PROTO_VALD_API_DOCS
and PROTO_MIRROR_API_DOCS
are correctly used in Makefile.d/proto.mk
as dependencies for the proto/gen/api/docs
target, which is part of the main protobuf generation workflow. The variables are used alongside corresponding pattern rules that handle the document generation for both Vald and Mirror APIs.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check usage of the new proto documentation variables in included makefiles
# Search for variable usage in Makefile.d/*.mk files
echo "Checking usage in Makefile.d/*.mk files:"
rg -A 5 "PROTO_(VALD|MIRROR)_(APIS|API_DOCS)" Makefile.d/
# Specifically check proto.mk since it's most likely to use these variables
echo "Checking proto.mk specifically:"
cat Makefile.d/proto.mk
Length of output: 4579
Description
SSIA
Related Issue
Versions
Checklist
Special notes for your reviewer
Summary by CodeRabbit
Release Notes
New Features
Documentation