Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patch] feature/internal/cassandra/add option #358

Merged
merged 8 commits into from
Apr 30, 2020
Merged

[patch] feature/internal/cassandra/add option #358

merged 8 commits into from
Apr 30, 2020

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Apr 30, 2020

Description:

Add Cassandra 2 Option

  • TokenAwareHostPolicy
  • SerialConsistency

Related Issue:

How Has This Been Tested?:

Environment:

  • Golang Version: 1.14
  • Docker Version: 19.03.5
  • Kubernetes Version: 1.17.3
  • NGT Version: 1.9.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

kpango added 2 commits April 30, 2020 12:01
[patch] add cassandra options
c837097 
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
fix
b2ea83f 
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
@kpango kpango changed the title [pathc] feature/internal/cassandra/add option [patch] feature/internal/cassandra/add option Apr 30, 2020
@pull-assistant
Copy link

pull-assistant bot commented Apr 30, 2020 •
edited
Loading

Score: 0.98

Best reviewed: commit by commit

Optimal code review plan (2 warnings)

[patch] add cassandra options

charts/vald/values.yaml 50% changes removed in Update charts/vald/v...

fix

charts/vald/values.yaml 75% changes removed in Update charts/vald/v...

     Update charts/vald/values.yaml

     Update charts/vald/values.yaml

     Update charts/vald/values.yaml

     Update charts/vald/values.yaml

     Update charts/vald/values.yaml

     Update charts/vald/values.yaml

Powered by Pull Assistant. Last update c837097 ... 47afc74. Read the comment docs.

rinx
rinx reviewed Apr 30, 2020
View reviewed changes
charts/vald/values.yaml Outdated Show resolved Hide resolved
charts/vald/values.yaml Outdated Show resolved Hide resolved
charts/vald/values.yaml Outdated Show resolved Hide resolved
charts/vald/values.yaml Outdated Show resolved Hide resolved
charts/vald/values.yaml Outdated Show resolved Hide resolved
Yusuke Kato and others added 2 commits April 30, 2020 12:44
@rinx
Update charts/vald/values.yaml
675f263 
Co-Authored-By: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx
Update charts/vald/values.yaml
4bb9ba5 
Co-Authored-By: Rintaro Okamura <rintaro.okamura@gmail.com>
@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

Yusuke Kato and others added 2 commits April 30, 2020 12:45
@rinx
Update charts/vald/values.yaml
fa7d3fe 
Co-Authored-By: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx
Update charts/vald/values.yaml
e9aae49 
Co-Authored-By: Rintaro Okamura <rintaro.okamura@gmail.com>
@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

2 similar comments
@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@codecov
Copy link

codecov bot commented Apr 30, 2020 •
edited
Loading

Codecov Report

Merging #358 into master will decrease coverage by 0.01%.
The diff coverage is 6.17%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #358      +/-   ##
=========================================
- Coverage    8.12%   8.10%   -0.02%     
=========================================
  Files         327     327              
  Lines       17670   17731      +61     
=========================================
+ Hits         1435    1437       +2     
- Misses      16037   16094      +57     
- Partials      198     200       +2
Impacted Files Coverage Δ
internal/config/cassandra.go 0.00% <0.00%> (ø)
internal/db/nosql/cassandra/cassandra.go 0.00% <0.00%> (ø)
internal/db/nosql/cassandra/option.go 10.61% <12.82%> (-0.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a77af37...47afc74. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@kpango kpango force-pushed the feature/internal/cassandra/add-option branch from 966ff8c to e8ae365 Compare April 30, 2020 04:05
@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@github-actions github-actions bot removed the size/L label Apr 30, 2020
@rinx
Update charts/vald/values.yaml
421e529 
Co-Authored-By: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
@kpango kpango force-pushed the feature/internal/cassandra/add-option branch from e8ae365 to 421e529 Compare April 30, 2020 04:10
@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

rinx
rinx reviewed Apr 30, 2020
View reviewed changes
charts/vald/values.yaml Outdated Show resolved Hide resolved
@rinx
Copy link
Contributor

rinx commented Apr 30, 2020

Others OK 👍

@rinx
Update charts/vald/values.yaml
47afc74 
Co-Authored-By: Rintaro Okamura <rintaro.okamura@gmail.com>
@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@rinx
Copy link
Contributor

rinx commented Apr 30, 2020

/approve

vdaas-ci
vdaas-ci approved these changes Apr 30, 2020
View reviewed changes
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by rinx.

@rinx rinx merged commit a4b4a02 into master Apr 30, 2020
@rinx rinx deleted the feature/internal/cassandra/add-option branch April 30, 2020 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rinx rinx rinx left review comments

@vdaas-ci vdaas-ci vdaas-ci approved these changes

Assignees
No one assigned
Labels
area/helm area/internal priority/medium size/XL team/set SET team type/feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpango @vdaas-ci @rinx