✨ Add internal/db/storage/blob #388

rinx · 2020-05-19T02:00:45Z

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

Added internal/db/storage/blob & internal/db/storage/blob/s3 packages
already tested using blob_test.go

Related Issue:

Nothing.

How Has This Been Tested?:

Running blob_test.go

Environment:

Golang Version: 1.14.3
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.11.5

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

pull-assistant · 2020-05-19T02:00:47Z

Best reviewed: commit by commit

Optimal code review plan

✨ Add internal/db/storage/blob

♻️ Revise name of objects / Use aws-sdk's session.NewSession fu...

🐧 Add use legacy list flag

Powered by Pull Assistant. Last update aa9f28e ... 52564ae. Read the comment docs.

vdaas-ci · 2020-05-19T02:01:02Z

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

github-actions · 2020-05-19T02:05:30Z

internal/db/storage/blob/blob_test.go

+	if err != nil {
+		t.Fatalf("fetch writer failed: %s", err)
+	}
+	defer func() {


[golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before defer statement (wsl)

github-actions · 2020-05-19T02:05:30Z

internal/db/storage/blob/blob_test.go

+	if err != nil {
+		t.Fatalf("fetch reader failed: %s", err)
+	}
+	defer func() {


[golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before defer statement (wsl)

github-actions · 2020-05-19T02:05:31Z

internal/config/blob.go

+)
+
+func (bst BlobStorageType) String() string {
+	switch bst {


[golangci] _{reported by reviewdog 🐶}
singleCaseSwitch: should rewrite switch statement to if statement (gocritic)

internal/db/storage/blob/s3/s3.go

codecov · 2020-05-19T02:08:15Z

Codecov Report

Merging #388 into master will increase coverage by 0.06%.
The diff coverage is 30.18%.

@@            Coverage Diff            @@
##           master    #388      +/-   ##
=========================================
+ Coverage    7.85%   7.91%   +0.06%     
=========================================
  Files         353     356       +3     
  Lines       18266   18319      +53     
=========================================
+ Hits         1434    1450      +16     
- Misses      16625   16660      +35     
- Partials      207     209       +2

Impacted Files	Coverage Δ
internal/config/blob.go	`0.00% <0.00%> (ø)`
internal/db/storage/blob/blob.go	`40.00% <40.00%> (ø)`
internal/db/storage/blob/option.go	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36efe03...52564ae. Read the comment docs.

internal/config/blob.go

internal/db/storage/blob/s3/s3.go

vdaas-ci · 2020-05-19T02:45:53Z

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

rinx · 2020-05-19T02:49:03Z

@kpango Thanks for your suggestions. I've revised them.

vdaas-ci · 2020-05-19T02:54:07Z

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

rinx · 2020-05-19T02:54:12Z

/rebase

vdaas-ci · 2020-05-19T02:55:24Z

[REBASE] Rebase triggered by rinx for branch: feature/internal/add-db-storage-blob-s3-implementation

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

vdaas-ci · 2020-05-19T02:56:02Z

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

github-actions · 2020-05-19T03:02:32Z

internal/config/blob.go

+}
+
+func AtoBST(bst string) BlobStorageType {
+	switch strings.ToLower(bst) {


[golangci] _{reported by reviewdog 🐶}
singleCaseSwitch: should rewrite switch statement to if statement (gocritic)

kpango · 2020-05-19T09:23:15Z

LGTM

github-actions bot added area/internal team/set SET team size/L type/feature New feature priority/medium labels May 19, 2020

github-actions bot reviewed May 19, 2020

View reviewed changes

kpango requested changes May 19, 2020

View reviewed changes

rinx added 3 commits May 19, 2020 02:55

✨ Add internal/db/storage/blob

aa9f28e

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

♻️ Revise name of objects / Use aws-sdk's session.NewSession func

94b0992

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

🐧 Add use legacy list flag

52564ae

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

vdaas-ci force-pushed the feature/internal/add-db-storage-blob-s3-implementation branch from bd77569 to 52564ae Compare May 19, 2020 02:55

github-actions bot reviewed May 19, 2020

View reviewed changes

kpango merged commit df143c9 into master May 19, 2020

kpango deleted the feature/internal/add-db-storage-blob-s3-implementation branch May 19, 2020 09:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Add internal/db/storage/blob #388

✨ Add internal/db/storage/blob #388

rinx commented May 19, 2020

pull-assistant bot commented May 19, 2020 •

edited

Loading

vdaas-ci commented May 19, 2020

github-actions bot May 19, 2020

github-actions bot May 19, 2020

github-actions bot May 19, 2020

codecov bot commented May 19, 2020 •

edited

Loading

vdaas-ci commented May 19, 2020

rinx commented May 19, 2020

vdaas-ci commented May 19, 2020

rinx commented May 19, 2020

vdaas-ci commented May 19, 2020

vdaas-ci commented May 19, 2020

github-actions bot May 19, 2020

kpango commented May 19, 2020

✨ Add internal/db/storage/blob #388

✨ Add internal/db/storage/blob #388

Conversation

rinx commented May 19, 2020

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

pull-assistant bot commented May 19, 2020 • edited Loading

vdaas-ci commented May 19, 2020

github-actions bot May 19, 2020

Choose a reason for hiding this comment

github-actions bot May 19, 2020

Choose a reason for hiding this comment

github-actions bot May 19, 2020

Choose a reason for hiding this comment

codecov bot commented May 19, 2020 • edited Loading

Codecov Report

vdaas-ci commented May 19, 2020

rinx commented May 19, 2020

vdaas-ci commented May 19, 2020

rinx commented May 19, 2020

vdaas-ci commented May 19, 2020

vdaas-ci commented May 19, 2020

github-actions bot May 19, 2020

Choose a reason for hiding this comment

kpango commented May 19, 2020

pull-assistant bot commented May 19, 2020 •

edited

Loading

codecov bot commented May 19, 2020 •

edited

Loading