-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix coding style for mock #806
Conversation
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
[CHATOPS:HELP] ChatOps commands.
|
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
type MockEncoder struct { | ||
EncoderFunc func(interface{}) ([]byte, error) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[LanguageTool] reported by reviewdog 🐶
This sentence does not start with an uppercase letter (UPPERCASE_SENTENCE_START)
Suggestions: Func
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/contributing/coding-style.md
Outdated
|
||
- Incomplete implementation | ||
- I/O | ||
- e. g. Network access, disk operation, or etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- e. g. Network access, disk operation, or etc. | |
- e.g. Network access, disk operation, etc. |
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
/rebase |
[REBASE] Rebase triggered by vankichi for branch: documentation/fix-mock-codingstyle |
[REBASE] Failed to rebase. |
Signed-off-by: hlts2 hiroto.funakoshi.hiroto@gmail.com
Description:
I fixed coding style for mock and GitHub action.
WHY
In Vald, There are a lot of dependencies between libraries.
As a result, the complexity of the test has increased, and it has become more difficult to determine whether or not to mock dependent objects and how to create mock.
if there are a lot of review dog comment, we can not see pr page. (review dog output warning because document has alot of example code. but we want to ignore it)
WHAT
Add document for mock
Add
TYPOGRAPY
to action yamlRelated Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: