[sync] prod to quotation-enginge-v0 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor addition, truth be told, it's still not clear why the font encoding thing is happening; just going to make this change first.
ks0m1c
pushed a commit
that referenced
this pull request
Jan 15, 2024
* Add route to show specific <chap, verse> * Add JS-hook for WebShare-API/clipboard-copy QQ: seems like I can only use buttons to do click events, how might I go about emitting click events from icons? * Cleanups based on PR review suggestions Added a /hooks subdir to throw in js-hooks and an indexer file for that. * Use external heex template for show_verse Just playing around with things... * Support the addition of meta tags in the html head This gets validated by just observing the html source code. The next step would be to add in the image generation. For a first pass, the image generation shall be done just-in-time, will add in some cacheing thereafter as a v1. * Add meta tags to other views in gita_live * Add image generation & routing * Attempt minor fixes * Navigate from chapter to individual verse * Improve clipboard content Things added: 1. chapter, verse number 2. both text and transliteration 3. url dump * Add just-in-time image creation for og-images * enable 404 templates * Consolidate Fallback Controller * Fix text * Add OgAdapter with filename encoder-decoder pair * Temporarily use atoms as text-id * [sync] prod to quotation-enginge-v0 (#14) syncs commits in the prod branch with this feature branch Co-authored-by: ks0m1c_dharma <sakiyamuni@sams.ara> Co-authored-by: ks0m1c_dharma <johndoe@dharma.in> * [WIP] Attempt @ YT Iframe Embed Things done: 1. Added a livecomponent which has a div. The div calls a js hook 2. the js hook creates a new script tag which inserts itself as the first script of the html document. * this is the most probable source of error because I think the callback functions are not being passed to the correct html element. I should explore this when I get back to this problem. The ideal case should be how it is shown on the iframe documentation that we see. 3. The cors issues have been resolved by adding the CORS plug that we saw. This CORS plug allows youtube.com/iframe_api to be a valid source. This actually works for all browsers. 4. If I embed this script tag directly to the heex template, it will work. However, it won't work when I'm attempting to create do it via a JS-Hook. There's a high likelyhood that it's just me being noob at Elixir/LiveView and that's why I can't get it to work yet. REF: https://developers.google.com/youtube/iframe_api_reference Hunch(es): 1. I might have to just insert things into the correct script tag properly. I had already tried inserting innerthtml but it just got parsed as a string. Maybe I should relook at that. 2. Kinda related to point 2 above * Successfully use iframe embed * Add reference to obj via window.youtubePlayer As long as this reference exists, we will be able to invoke JS API calls that the youtube player exposes. * Add examples of interfacing w playr's playback fns Currently, I've just supported "seekTo" and "loadVideoById" callbacks. * Add examples of playr's videoStats APIs Got a bunch of video stats that gets spit out onhover of a button. * Add basic version of a mini-player * Make improvements from code review * Cleanup code --------- Co-authored-by: ks0m1c_dharma <sakiyamuni@sams.ara> Co-authored-by: ks0m1c_dharma <johndoe@dharma.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.