Add seeder for Hanuman Chalisa #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - cleans up the pattern for adding new seeders - groups seed functions within SourceSeeders
There's an odd behaviour with translations. tldr; 1. I create chapter properly 2. I create translation for chapter properly 3. i query chapter, then preload the translations for the chap, then i get both the one I actually inserted + the gita chap 1 translation
Observations: 1. Reminder about the case where if the user has multiple browser tabs open pointing to our application, then the handshake will get messed up, the player views will crash -- it's even more apparent when there are more than one voices 2. the player still does the pre-load behaviour, where the playback continues until the player is interacted with, when I navigate from one chapter to another. Steps: 1. play hanuman chalisa chapter's audio 2. instead of a refresh, navigate to gita::chapter1 3. observe that the playback for chalisa continues (but the player is actually in a !playing? state [as seen by the play button being displayed]) 4. observe that the new handshake actually is handled properly 5. the audio player only starts playing the gita chapter's audio once the user interacts with the player and clicks on the play button
rtshkmr
force-pushed
the
chore/add-hanuman-chalisa-seeder
branch
from
c60957a to
b008965
Compare
Conflicts: - lib/vyasa/written.ex: minor, kept the sensible one
This commit finally made me feel that I understood the lang & the framework to a working-degree of familiarity. Really happy with myself. The seeking by clicking works well !!!
ks0m1c
reviewed
Feb 28, 2024
Support playback seeking by clicking on the verse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: Completed
Key things done & learnings: